RFR: 8328977: JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Tue Feb 3 04:03:12 UTC 2026
On Wed, 5 Feb 2025 12:18:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rearranged if based on suggesion
>
> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 480:
>
>> 478: final String reference = page.getRef();
>> 479:
>> 480: if ((postData == null) && page.sameFile(loaded)) {
>
> This line of code causes lots of test failures because `page.sameFile(loaded)` doesn't accept a `null` parameter, which results in `NullPointerException`.
Post **null** check and bringing back missing code at [482](https://github.com/Renjithkannath/jdk/blob/d1d1f448bfd196913039cbb822eada9b98a5e557/src/java.desktop/share/classes/javax/swing/JEditorPane.java#L482) there is no failure on tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18670#discussion_r2757076163
More information about the client-libs-dev
mailing list