RFR: 8377183: Impossible or redundant condition in AwtFrame::_NotifyModalBlocked of awt_Frame.cpp:1635

Damon Nguyen dnguyen at openjdk.org
Mon Feb 9 21:59:46 UTC 2026


In awt_Frame.cpp, there is a conditional that includes a "not-null" check in a scenario where null is impossible. Starting on line 1589, each conditional ends in a return statement. The only possibility in awt_Frame.cpp's line 1635 is peer is not null and f is not null. So, checking for `f != NULL` is redundant and unnecessary. And the fix is simply to remove this extraneous check in the conditional.

-------------

Commit messages:
 - Update copyright year
 - Initial commit

Changes: https://git.openjdk.org/jdk/pull/29625/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29625&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8377183
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/29625.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29625/head:pull/29625

PR: https://git.openjdk.org/jdk/pull/29625


More information about the client-libs-dev mailing list