Integrated: 8377183: Impossible or redundant condition in AwtFrame::_NotifyModalBlocked of awt_Frame.cpp:1635
Damon Nguyen
dnguyen at openjdk.org
Wed Feb 11 09:45:58 UTC 2026
On Mon, 9 Feb 2026 06:26:56 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> In awt_Frame.cpp, there is a conditional that includes a "not-null" check in a scenario where null is impossible. Starting on line 1589, each conditional ends in a return statement. The only possibility in awt_Frame.cpp's line 1635 is peer is not null and f is not null. So, checking for `f != NULL` is redundant and unnecessary. And the fix is simply to remove this extraneous check in the conditional.
This pull request has now been integrated.
Changeset: 3de6dbab
Author: Damon Nguyen <dnguyen at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3de6dbab14e950c1725a48686478e4155c8d93c7
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
8377183: Impossible or redundant condition in AwtFrame::_NotifyModalBlocked of awt_Frame.cpp:1635
Reviewed-by: serb, prr
-------------
PR: https://git.openjdk.org/jdk/pull/29625
More information about the client-libs-dev
mailing list