RFR: 6434110: Color constructor parameter name is misleading [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Feb 17 20:23:39 UTC 2026


On Tue, 17 Feb 2026 19:49:29 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> test/jdk/java/awt/ColorClass/ColorARGBConstructorTest.java line 49:
>> 
>>> 47:         int expA = hasAlpha ? (argb >>> 24) : 0xFF;
>>> 48:         int expR = (argb >> 16) & 0xFF;
>>> 49:         int expG = (argb >> 8) & 0xFF;
>> 
>> This was not what I meant:
>> 
>> Suggestion:
>> 
>>         int expA = hasAlpha ? (argb >>> 24) : 0xFF;
>>         int expR = (argb >>> 16);
>>         int expG = (argb >>> 8);
>> 
>> 
>> or 
>> 
>> 
>> Suggestion:
>> 
>>         int expA = hasAlpha ? ((argb >> 24)  & 0xFF) : 0xFF;
>>         int expR = (argb >> 16) & 0xFF;
>>         int expG = (argb >> 8) & 0xFF;
>
> I understand that, but prefer >>> for alpha only. "()" is added to make operation order clear.

You can still use `>>>` for other components, it will look consistent at least. Otherwise, you can't help wondering why different operators are used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29734#discussion_r2818896177


More information about the client-libs-dev mailing list