RFR: 6434110: Color constructor parameter name is misleading [v2]
Alexey Ivanov
aivanov at openjdk.org
Fri Feb 20 13:54:45 UTC 2026
On Tue, 17 Feb 2026 20:46:30 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Not necessary, but using `>>>` doesn't change the result, and using the same operator in all the three cases looks *consistent*.
>
> Why should it use the same operator for all of them if some are unnecessary? I prefer >>> for alpha because it works well without additional masking, and masking only for blue, which does not need a shift by zero. It is short and clean, and there is no need to align it beautifully just to make it look better.
I'd still go for the same operator in all the color components so that all of the cases look *consistently*.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29734#discussion_r2833301384
More information about the client-libs-dev
mailing list