RFR: 8377568: DataBuffer constructors and methods do not specify required exceptions [v3]

Phil Race prr at openjdk.org
Fri Feb 20 21:40:50 UTC 2026


On Fri, 20 Feb 2026 14:13:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> They are (now) consistently 4. I don't think I've ever used 8 for continuation.
>> I use 4 (more) unless there's a natural alignment that seems attractive.
>
>> I don't think I've ever used 8 for continuation.
> 
> Odd. Your original code in this code review used 8 spaces for continuation, it was like this in another PR too, but you also changed it to 4 spaces after I pointed out at the inconsistent indentation.
> 
> 8 spaces for continuations is the most standard indentation—increasing from the regular 4 spaces signals it's a continuation line.
> 
>> there's a natural alignment that seems attractive.
> 
> I usually choose this option if it's viable, if such an alignment doesn't make the code harder to read.

So I think I've fixed indentation now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r2834901054


More information about the client-libs-dev mailing list