RFR: 6328248: JProgessBar doesn't show if printed on paper with PrintJob (1.1 Graphics API) [v3]
Phil Race
prr at openjdk.org
Sat Feb 21 05:06:09 UTC 2026
On Fri, 20 Feb 2026 08:59:18 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> src/java.desktop/share/classes/sun/print/PrintJobDelegate.java line 532:
>>
>>> 530: int[][] members = range.getMembers();
>>> 531: jobAttributes.setPageRanges(members);
>>> 532: }
>>
>> Hmm. This seems a very odd thing to include in this PR. It it is unrelated.
>> I don't think it should be here and we've managed for 20 years without this null check, so why now ?
>>
>> Is it a regression caused by https://github.com/openjdk/jdk/pull/29312/ ?
>
> Yes, it seems so..Clicking "All" will result in NPE so resolved that here..
This needs to be in a separate bug. If someone wants to back port that other fix and then finds the NPE, I'm quite sure they don't want to back port a Swing fix to get the portion of it that includes the printing fix.
How did we miss this in the other fix ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29752#discussion_r2835838508
More information about the client-libs-dev
mailing list