RFR: 8378297: Remove AppContext from several Swing component and related classes [v2]
Damon Nguyen
dnguyen at openjdk.org
Tue Feb 24 20:40:03 UTC 2026
On Tue, 24 Feb 2026 19:31:25 GMT, Phil Race <prr at openjdk.org> wrote:
>> Remove AppContext usage from several Swing classes that use it via Swing utility (still used by other cases so can't remove that yet).
>>
>> One ToolTipManager test for the AppContext is removed.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>
> 8378297
Changes requested by dnguyen (Reviewer).
Original issue I saw was due to my end. Deleted that change request comment after looking at this again and seeing it was correct in the `Files Changed`. Copied your changes again and it LGTM.
src/java.desktop/share/classes/javax/swing/JFrame.java line 752:
> 750:
> 751: private static boolean defaultLAFDecorated;
> 752: /**
Suggestion:
private static boolean defaultLAFDecorated;
/**
Nit but you have added a newline after similar `private static vars` for JDialog and JPopupMenu.
-------------
PR Review: https://git.openjdk.org/jdk/pull/29830#pullrequestreview-3850358168
Marked as reviewed by dnguyen (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29830#pullrequestreview-3850388210
PR Review Comment: https://git.openjdk.org/jdk/pull/29830#discussion_r2849411110
More information about the client-libs-dev
mailing list