RFR: 8376152: Test javax/sound/sampled/Clip/bug5070081.java timed out then completed
Alexey Ivanov
aivanov at openjdk.org
Wed Feb 25 15:09:49 UTC 2026
On Tue, 24 Feb 2026 18:27:24 GMT, Phil Race <prr at openjdk.org> wrote:
> I've run this test and it definitely needs a sound device.
> So I've added the jtreg key for sound, so we can always run it where there's sound support.
Marked as reviewed by aivanov (Reviewer).
Looks good except for a minor comment about the bug id.
test/jdk/javax/sound/sampled/Clip/bug5070081.java line 35:
> 33: * @test
> 34: * @key sound
> 35: * @bug 5070081 8376152
No need to add 8376152, in my opinion. It's a test only change as opposed to product bugs, and we agreed to add only product bugs into the `@bug` jtreg tag.
-------------
PR Review: https://git.openjdk.org/jdk/pull/29901#pullrequestreview-3854864716
PR Comment: https://git.openjdk.org/jdk/pull/29901#issuecomment-3959947725
PR Review Comment: https://git.openjdk.org/jdk/pull/29901#discussion_r2853602125
More information about the client-libs-dev
mailing list