RFR: 6562639: Wrong pixel bounds from TextLayout with white font [v2]
Sergey Bylokhov
serb at openjdk.org
Fri Jan 2 10:46:50 UTC 2026
On Fri, 2 Jan 2026 10:43:20 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:
>> One of the possible code paths for `TextLayout.getPixelBounds(...)` actually draws the text on a `Graphics2D` and checks the image pixels afterwards. The text is drawn over a white background, so if the user sets the font's foreground color to white then the text pixels cannot be detected (white on white).
>>
>> This PR fixes the issue by removing the code that sets the background to white, leaving the background as the default ARGB color (0 = transparent black). This does not cause a new problem for users who might set their font foreground color to transparent black, because transparent font foreground colors always return an empty bounds anyway (by virtue of being transparent).
>>
>> The updated code should also be slightly faster since it's doing less work, though I haven't run any performance tests.
>
> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
>
> Update copyright year 2025 -> 2026
Marked as reviewed by serb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28809#pullrequestreview-3622904219
More information about the client-libs-dev
mailing list