RFR: 8373650: Test javax/swing/JMenuItem/6458123/ManualBug6458123.java fails because the check icons are not aligned properly as expected [v3]

Alexey Ivanov aivanov at openjdk.org
Thu Jan 15 12:41:49 UTC 2026


On Thu, 15 Jan 2026 00:39:24 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Although the if/else branches look strange, it works. I don't see a clear way to clean up and condense the conditionals so lgtm unless someone else has an idea.

I haven't looked at the updated code yet.

I wonder why the logic in `MenuItemLayoutHelper.java` isn't enough, why adjustments are needed.

As I posted in [my previous comment](https://github.com/openjdk/jdk/pull/28889#discussion_r2694197701), I'm not against this approach as long as it works and fixes the layout, yet I'd like to clean up the code if possible… in a follow-up issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28889#issuecomment-3754543967


More information about the client-libs-dev mailing list