RFR: 8297191: [macos] Printing a page range with starting page > 1 results in missing pages [v7]
Christian Heilmann
duke at openjdk.org
Mon Jan 19 09:03:31 UTC 2026
> This PR fixes a bug that caused no or the wrong set of pages to be printed when using page ranges on macOS.
>
> The main fix is to change the 'location' value of the returned NSRange from the knowsPageRange method to 1 in the native class PrinterView.m.
Christian Heilmann has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
- Merge branch 'master' of https://github.com/christianheilmann/jdk into pr/11266
# Conflicts:
# src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m
- Changed copyright year to 2026
- Merge branch 'pr/8297191' of https://github.com/christianheilmann/jdk into pr/11266
- Merge branch 'openjdk:master' into pr/8297191
- added 8297191 to @bug
- Update PrinterView.m
- Update PrinterView.h
- Update CPrinterJob.m
- 8297191 fixed printing page range for e.g. page 2 to 2 on macOS
- 8297191 fixed printing page range for e.g. page 2 to 2 on macOS
- ... and 3 more: https://git.openjdk.org/jdk/compare/1d4bb75b...4de8582f
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11266/files
- new: https://git.openjdk.org/jdk/pull/11266/files/64fbbd84..4de8582f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11266&range=06
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11266&range=05-06
Stats: 137693 lines in 4317 files changed: 78048 ins; 31140 del; 28505 mod
Patch: https://git.openjdk.org/jdk/pull/11266.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/11266/head:pull/11266
PR: https://git.openjdk.org/jdk/pull/11266
More information about the client-libs-dev
mailing list