RFR: 8376420: Remove AppContext from javax/swing/ImageIcon.java [v2]
Phil Race
prr at openjdk.org
Wed Jan 28 21:12:00 UTC 2026
On Wed, 28 Jan 2026 20:09:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> I am pretty sure this was AppContext related, since we could not return a MediaTracker stored in one AppContext to another AppContext and now we are doing exactly that, but ok not a big issue.
>
Not a big issue because only tests create 2 ACs now and the tests and AC itself will be removed as soon as I can get past these leaf issues.
Going further back it still doesn't seem to be the case that it was an AC fix.
It was actually due to a security issue with ACC (AccessControlContext).
That fix is now no longer there because we removed SM code a couple of releases ago.
Now we can simplify it even further.
But it still doesn't seem like we need to resurrect using the visible field.
> The only difference between the two is that the old MediaTracker component was created using createComponent, which resets the AppContext, should we drop that AppContext usage there as well?
Yes, I don't know why I didn't do that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29433#discussion_r2738608359
More information about the client-libs-dev
mailing list