<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
That would be nice but I suspect it would not be easy to get
agreement on that.<br>
<br>
At least the dev guide also says "<span style="caret-color: rgb(0,
0, 0); color: rgb(0, 0, 0); font-family: "DejaVu Sans",
"Bitstream Vera Sans", "Luxi Sans", Verdana,
Arial, Helvetica; font-size: 13.333333px; font-style: normal;
font-variant-caps: normal; font-weight: 400; letter-spacing:
normal; orphans: auto; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; display: inline !important; float: none;">Some
teams may require more Reviewers."</span><br>
<a class="moz-txt-link-freetext" href="https://openjdk.org/guide/#fixing-a-bug">https://openjdk.org/guide/#fixing-a-bug</a><br>
<br>
And it recommends 24 business hrs as well ..<br>
<br>
"<span style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);
font-family: "DejaVu Sans", "Bitstream Vera
Sans", "Luxi Sans", Verdana, Arial, Helvetica;
font-size: 13.333333px; font-style: normal; font-variant-caps:
normal; font-weight: 400; letter-spacing: normal; orphans: auto;
text-align: left; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; text-decoration: none; display:
inline !important; float: none;">In general all PRs should be open
for at least 24 hours to allow for reviewers in all time zones to
get a chance to see it. It may actually happen that even 24 hours
isn’t enough. Take into account weekends, holidays, and vacation
times throughout the world and you’ll realize that a change that
requires more than just a trivial review may have to be open for a
while. In some areas<span class="Apple-converted-space"> </span></span><a href="https://openjdk.org/guide/#trivial" style="text-decoration:
none; color: rgb(102, 102, 102); font-family: "DejaVu
Sans", "Bitstream Vera Sans", "Luxi
Sans", Verdana, Arial, Helvetica; font-size: 13.333333px;
font-style: normal; font-variant-caps: normal; font-weight: 400;
letter-spacing: normal; orphans: auto; text-align: left;
text-indent: 0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">trivial</a><span style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);
font-family: "DejaVu Sans", "Bitstream Vera
Sans", "Luxi Sans", Verdana, Arial, Helvetica;
font-size: 13.333333px; font-style: normal; font-variant-caps:
normal; font-weight: 400; letter-spacing: normal; orphans: auto;
text-align: left; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; text-decoration: none; display:
inline !important; float: none;"><span class="Apple-converted-space"> </span>changes are allowed to be
pushed without the 24 hour delay. Ask your reviewers if you think
this applies to your change."<br>
<br>
</span><a class="moz-txt-link-freetext" href="https://openjdk.org/guide/#life-of-a-pr">https://openjdk.org/guide/#life-of-a-pr</a><br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 7/13/23 1:24 PM, Thomas Stüfe wrote:<br>
</div>
<blockquote type="cite" cite="mid:CAA-vtUy_R0dC1A1W9-F3f9O6vB4T0NpKOEeM7Q2-9Uh8mo6aBw@mail.gmail.com">
<div dir="ltr">I think it would be less confusing all around to
have a general requirement for 2 reviewers across the whole
OpenJDK.<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Jul 13, 2023 at
5:28 PM Philip Race <<a href="mailto:philip.race@oracle.com" moz-do-not-send="true" class="moz-txt-link-freetext">philip.race@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div> Please see "Code Reviews" on the Group page <br>
<a href="https://openjdk.org/groups/client-libs/" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://openjdk.org/groups/client-libs/</a>
where it says<br>
<br>
<span>The Java Client Library Group has always standardized
on two approvals - where at least one must have the
Reviewer role.<br>
Historically this was addressed entirely by social
conventions but today the tooling plays a role - and the
JDK project is set up to mark a PR as ready for
integration after a single approval by a person with the
Reviewer role - which is not consistent with the Client
Libraries policy.<br>
The tooling cannot automatically enforce this on a
per-module basis and it is not reasonable to expect others
to add "/reviewers 2" to every PR.<br>
The fixer therefore needs to understand the policies and
wait for a second approval.<br>
<br>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^<br>
<br>
As an example of a PR about which there was zero urgency
and should have had a 2nd approval see<br>
<br>
</span><a href="https://github.com/openjdk/jdk/pull/14795" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jdk/pull/14795</a><br>
<br>
-phil.<br>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>