<html><head>
<style id="css_styles" type="text/css"><!--blockquote.cite { margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc }
blockquote.cite2 {margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc; margin-top: 3px; padding-top: 0px; }
a img { border: 0px; }
li[style='text-align: center;'], li[style='text-align: center; '], li[style='text-align: right;'], li[style='text-align: right; '] { list-style-position: inside;}
body { font-family: Helvetica; font-size: 9pt; }
.quote { margin-left: 1em; margin-right: 1em; border-left: 5px #ebebeb solid; padding-left: 0.3em; }
a.em-mention[href] { text-decoration: none; color: inherit; border-radius: 3px; padding-left: 2px; padding-right: 2px; background-color: #e2e2e2; }
._em_placeholder {color: gray; border-bottom: 1px dotted lightblue;} ._em_placeholder:before{color:gray; content: '{{ ';} ._em_placeholder:after{color:gray; content: ' }}';}
--></style></head>
<body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div>Thanks.</div><div><br /></div><div>I have <a href="https://github.com/openjdk/jdk/compare/master...mickleness:JDK-8344697?expand=1" class="__cef_visited">a branch</a> for this work that is ready for feedback, but I assume I shouldn’t make a PR until I have a new ticket number to use.</div><div><br /></div><div>I submitted a new OpenJDK ticket a week or so ago. Hopefully after couple of weeks I’ll see it in the ticket database.</div><div><br /></div><div> - Jeremy</div>
<div x-em-replyforwardheader=""><br /></div>
<div>
<div>------ Original Message ------</div>
<div>From "Philip Race" <<a href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>></div>
<div>To "Jeremy Wood" <<a href="mailto:mickleness@gmail.com">mickleness@gmail.com</a>>; "client-libs-dev@openjdk.org" <<a href="mailto:client-libs-dev@openjdk.org">client-libs-dev@openjdk.org</a>></div>
<div>Date 4/11/2025 1:41:33 PM</div>
<div>Subject Re: Removing obsolete Aqua code</div></div><div x-em-quote=""><br /></div>
<div id="xf34ebaa5e53641f"><blockquote cite="b0ebf1cf-434e-4b45-9fc0-369c0b19029c@oracle.com" type="cite" class="cite2">
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.org/browse/JDK-8344697">https://bugs.openjdk.org/browse/JDK-8344697</a> is closed as a dup.<br />
At this point I'd say A, although re-opening and renaming is
possible.
<br />
<br />
-phil<br />
<br />
<br />
<div class="moz-cite-prefix">On 4/11/25 9:58 AM, Jeremy Wood wrote:<br />
</div>
<blockquote type="cite" cite="mid:em05939e17-3f66-47b3-a990-949a2afbca11@f434645e.com" class="cite">
<style type="text/css"><!--#xf34ebaa5e53641f blockquote.cite
{margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right: 0px; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204);}
#xf34ebaa5e53641f blockquote.cite2
{margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right: 0px; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); margin-top: 3px; padding-top: 0px;}
#xf34ebaa5e53641f a img
{border: 0px;}
#xf34ebaa5e53641f li#xf34ebaa5e53641f [style="'text-align: center;'"], #xf34ebaa5e53641f li#xf34ebaa5e53641f [style="'text-align: center; '"], #xf34ebaa5e53641f li#xf34ebaa5e53641f [style="'text-align: right;'"], #xf34ebaa5e53641f li#xf34ebaa5e53641f [style="'text-align: right; '"]
{list-style-position: inside;}
#xf34ebaa5e53641f
{font-family: Helvetica; font-size: 9pt;}
#xf34ebaa5e53641f .quote
{margin-left: 1em; margin-right: 1em; border-left-width: 5px; border-left-style: solid; border-left-color: rgb(235, 235, 235); padding-left: 0.3em;}
#xf34ebaa5e53641f a.em-mention#xf34ebaa5e53641f [href]
{text-decoration: none; color: inherit; border-radius: 3px; padding-left: 2px; padding-right: 2px; background-color: rgb(226, 226, 226);}
#xf34ebaa5e53641f ._em_placeholder
{color: gray; border-bottom-width: 1px; border-bottom-style: dotted; border-bottom-color: lightblue;}
#xf34ebaa5e53641f ._em_placeholder::before
{color: gray; content: "{{ ";}
#xf34ebaa5e53641f ._em_placeholder::after
{color: gray; content: " }}";}
--></style>
in <a href="https://bugs.openjdk.org/browse/JDK-8344697" moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/JDK-8344697</a> I
pointed out that in Mac's Aqua L&F: we’re using
AncestorListeners to help repaint JRootPane default buttons.
<div><br />
</div>
<div>Over a decade ago this logic was needed to emulate the native
Aqua experience, but since around 2016 the default button in
Aqua does NOT continually pulse.
</div>
<div><br />
</div>
<div>I’d like to remove this code, but I’m not sure how to
proceed.
</div>
<div><br />
</div>
<div>Originally I planned to make a PR for <a href="https://bugs.openjdk.org/browse/JDK-8344697" style="font-size: 9pt;" moz-do-not-send="true">8344697</a> that
removes the unused code. But after rebalancing the
AWTEventMulticaster (in
<a href="https://bugs.openjdk.org/browse/JDK-8342782" style="font-size: 9pt;" moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/JDK-8342782</a> ),
the performance problems observed in
<span> </span><a href="https://bugs.openjdk.org/browse/JDK-8344697" style="font-size: 9pt; margin: 0px;" moz-do-not-send="true">8344697</a> do
not reproduce.
</div>
<div><br />
</div>
<div>Should I:</div>
<div>A. File a new ticket just to remove the obsolete code?</div>
<div>B. Go ahead and name this new PR after<span> </span><a href="https://bugs.openjdk.org/browse/JDK-8344697" style="font-size: 9pt; margin: 0px;" moz-do-not-send="true">8344697</a> ,
even though that’s a little misleading now?
</div>
<div>C. Don’t pursue this, because without a concrete problem /
business case the OpenJDK community shouldn’t focus on this tech
debt.
</div>
<div><br />
</div>
<div>Thoughts?</div>
<div><br />
</div>
<div>Regards,</div>
<div> - Jeremy</div>
</blockquote>
<br />
</blockquote></div>
</body></html>