<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Go ahead.<br>
<br>
BTW this doesn't mean I've done a "pre-review" of the specifics, I'm
just saying OK to the idea.<br>
So in review it may be found that there's a reason to keep some of
these as they are.<br>
<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 2/12/26 12:49 AM, Jeremy Wood wrote:<br>
</div>
<blockquote type="cite" cite="mid:em4ace0b31-2dd5-4809-b554-5f989a1e9ae5@gmail.com">
<style id="css_styles">blockquote.cite { margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc }blockquote.cite2 {margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc; margin-top: 3px; padding-top: 0px; }a img { border: 0px; }li[style='text-align: center;'], li[style='text-align: center; '], li[style='text-align: right;'], li[style='text-align: right; '] { list-style-position: inside;}body { font-family: Helvetica; font-size: 9pt; }.quote { margin-left: 1em; margin-right: 1em; border-left: 5px #ebebeb solid; padding-left: 0.3em; }a.em-mention[href] { text-decoration: none; color: inherit; border-radius: 3px; padding-left: 2px; padding-right: 2px; background-color: #e2e2e2; }._em_placeholder {color: gray; border-bottom: 1px dotted lightblue;}._em_placeholder:before{color:gray; content: '{{ ';}._em_placeholder:after{color:gray; content: ' }}';}</style>
If I open a PR to clean up CAccessibility.java: is there any
interest in code reviewing it?
<div><br>
</div>
<div>Just tonight I think I’ve identified three topics to explore:</div>
<div><br>
</div>
<div>A. The native method `roleKey(AccessibleRole)` looks
redundant compared to
`AWTAccessor.getAccessibleBundleAccessor().getKey(AccessibleRole)`.
I think we can remove one. (Or at least better document when to
use each.)</div>
<div><br>
</div>
<div>B. There’s an if statement: `if (“label”.equals(…`. This
looks like it will break if the Locale is not English. However
it (mostly) doesn’t, because…</div>
<div><br>
</div>
<div>C. The method getAccessibleRoleForLabel also appears mostly
redundant compared to AccessibleJLabel#getAccessibleRole. (See
2021 commit 70bad89b012eb200ca1e76f384a6e5fb307cf26d for 8277497
).</div>
<div><br>
</div>
<div>I could submit a PR to clean these up, but I know sometime’s
it's hard to justify maintenance work without a customer-facing
issue.</div>
<div><br>
</div>
<div>Any thoughts?</div>
<div><br>
</div>
<div>Regards,</div>
<div> - Jeremy</div>
</blockquote>
<br>
</body>
</html>