From dalibor.topic at oracle.com Mon Jul 1 07:24:59 2013 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 01 Jul 2013 16:24:59 +0200 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51C0019B.4070103@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> Message-ID: <51D1913B.1020801@oracle.com> On 6/18/13 8:43 AM, Aleksey Shipilev wrote: > +1. > > On the related note, do we want to set up the Sonar [1] instance to > analyze OpenJDK codebase? In my experience, _that_ really highlights the > problematic areas. See http://mail.openjdk.java.net/pipermail/discuss/2011-November/002204.html cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From aleksey.shipilev at oracle.com Mon Jul 1 08:11:35 2013 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Mon, 01 Jul 2013 19:11:35 +0400 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D1913B.1020801@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> Message-ID: <51D19C27.20402@oracle.com> On 07/01/2013 06:24 PM, Dalibor Topic wrote: > On 6/18/13 8:43 AM, Aleksey Shipilev wrote: >> +1. >> >> On the related note, do we want to set up the Sonar [1] instance to >> analyze OpenJDK codebase? In my experience, _that_ really highlights the >> problematic areas. > > See http://mail.openjdk.java.net/pipermail/discuss/2011-November/002204.html Right. I should have asked Evgeny directly. Thanks! Is there a place where we can put the links to things like these? (Henry Gomez's build factory comes to mind next) -Aleksey. From dalibor.topic at oracle.com Mon Jul 1 13:13:08 2013 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 01 Jul 2013 22:13:08 +0200 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D19C27.20402@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> <51D19C27.20402@oracle.com> Message-ID: <51D1E2D4.4030302@oracle.com> On 7/1/13 5:11 PM, Aleksey Shipilev wrote: > Is there a place where we can put the links to things like these? I'd suggest putting them in the wiki, when they make sense for a Project/Group. cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From jonathan.gibbons at oracle.com Wed Jul 3 03:09:37 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 03 Jul 2013 03:09:37 -0700 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D1913B.1020801@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> Message-ID: <51D3F861.6090506@oracle.com> On 07/01/2013 07:24 AM, Dalibor Topic wrote: > On 6/18/13 8:43 AM, Aleksey Shipilev wrote: >> +1. >> >> On the related note, do we want to set up the Sonar [1] instance to >> analyze OpenJDK codebase? In my experience, _that_ really highlights the >> problematic areas. > See http://mail.openjdk.java.net/pipermail/discuss/2011-November/002204.html > > cheers, > dalibor topic > > > The main issue is getting manageable reports that people can handle. There's no point generating a report that shows we have ten gazillion issues to fix, because there will be no significant reward for anyone working to reduce the numbers. You need to be able to target specific areas for which there is a hope of making progress. -- Jon From jonathan.gibbons at oracle.com Wed Jul 3 03:10:18 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 03 Jul 2013 03:10:18 -0700 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D19C27.20402@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> <51D19C27.20402@oracle.com> Message-ID: <51D3F88A.2090706@oracle.com> On 07/01/2013 08:11 AM, Aleksey Shipilev wrote: > On 07/01/2013 06:24 PM, Dalibor Topic wrote: >> On 6/18/13 8:43 AM, Aleksey Shipilev wrote: >>> +1. >>> >>> On the related note, do we want to set up the Sonar [1] instance to >>> analyze OpenJDK codebase? In my experience, _that_ really highlights the >>> problematic areas. >> See http://mail.openjdk.java.net/pipermail/discuss/2011-November/002204.html > Right. I should have asked Evgeny directly. Thanks! > > Is there a place where we can put the links to things like these? > (Henry Gomez's build factory comes to mind next) > > -Aleksey. > OpenJDK wiki? -- Jon From aleksey.shipilev at oracle.com Wed Jul 3 03:45:04 2013 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Wed, 03 Jul 2013 14:45:04 +0400 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D3F861.6090506@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> <51D3F861.6090506@oracle.com> Message-ID: <51D400B0.90205@oracle.com> On 07/03/2013 02:09 PM, Jonathan Gibbons wrote: > On 07/01/2013 07:24 AM, Dalibor Topic wrote: >> On 6/18/13 8:43 AM, Aleksey Shipilev wrote: >>> +1. >>> >>> On the related note, do we want to set up the Sonar [1] instance to >>> analyze OpenJDK codebase? In my experience, _that_ really highlights the >>> problematic areas. >> See >> http://mail.openjdk.java.net/pipermail/discuss/2011-November/002204.html >> >> cheers, >> dalibor topic > > The main issue is getting manageable reports that people can handle. > There's no point generating a report that shows we have ten gazillion > issues to fix, because there will be no significant reward for anyone > working to reduce the numbers. You need to be able to target specific > areas for which there is a hope of making progress. Sure. BTW, I asked Evgeny for the JDK 8 instance, where the development is going on: https://twitter.com/shipilev/status/351719579724161026 -Aleksey. From jonathan.gibbons at oracle.com Wed Jul 3 04:24:44 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 03 Jul 2013 04:24:44 -0700 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D400B0.90205@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> <51D3F861.6090506@oracle.com> <51D400B0.90205@oracle.com> Message-ID: <51D409FC.3070503@oracle.com> On 07/03/2013 03:45 AM, Aleksey Shipilev wrote: > On 07/03/2013 02:09 PM, Jonathan Gibbons wrote: >> On 07/01/2013 07:24 AM, Dalibor Topic wrote: >>> On 6/18/13 8:43 AM, Aleksey Shipilev wrote: >>>> +1. >>>> >>>> On the related note, do we want to set up the Sonar [1] instance to >>>> analyze OpenJDK codebase? In my experience, _that_ really highlights the >>>> problematic areas. >>> See >>> http://mail.openjdk.java.net/pipermail/discuss/2011-November/002204.html >>> >>> cheers, >>> dalibor topic >> The main issue is getting manageable reports that people can handle. >> There's no point generating a report that shows we have ten gazillion >> issues to fix, because there will be no significant reward for anyone >> working to reduce the numbers. You need to be able to target specific >> areas for which there is a hope of making progress. > Sure. BTW, I asked Evgeny for the JDK 8 instance, where the development > is going on: > https://twitter.com/shipilev/status/351719579724161026 > > -Aleksey. > I scanned through some of this report. It is hard to know how we can best make use of it. In addition, some of the "major issues" don't seem so major to me -- like "superfluous parentheses". And "security issues" come up as just "info". I don't think one report for the JDK is the best way to go. If we could configure a report for each of the major component areas, and configure the messages that are generated, then we might start to get somewhere. I see some of the issues are close to "code style" issues. These can sometimes be very difficult to fix, because of the risk of making it hard to integrate changes in progress in other repos, and making it harder to backport changes to other releases. -- Jon From aleksey.shipilev at oracle.com Wed Jul 3 04:27:41 2013 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Wed, 03 Jul 2013 15:27:41 +0400 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D409FC.3070503@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> <51D3F861.6090506@oracle.com> <51D400B0.90205@oracle.com> <51D409FC.3070503@oracle.com> Message-ID: <51D40AAD.4000909@oracle.com> On 07/03/2013 03:24 PM, Jonathan Gibbons wrote: > I scanned through some of this report. It is hard to know how we can > best make use of it. In addition, some of the "major issues" don't seem > so major to me -- like "superfluous parentheses". And "security issues" > come up as just "info". Yes, because JDK is somewhat special when it comes to code style, issues to track, etc. This can be handled by fine tuning the warnings we are looking for. > I don't think one report for the JDK is the best way to go. If we could > configure a report for each of the major component areas, and configure > the messages that are generated, then we might start to get somewhere. I agree. But, that is harder to do when you don't own the Sonar instance. Hence, my original question floats up again: is there a merit to have public Sonar instance within OpenJDK, where we can fine-tune the reports? -Aleksey. From jonathan.gibbons at oracle.com Wed Jul 3 04:43:46 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 03 Jul 2013 04:43:46 -0700 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D40AAD.4000909@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> <51D3F861.6090506@oracle.com> <51D400B0.90205@oracle.com> <51D409FC.3070503@oracle.com> <51D40AAD.4000909@oracle.com> Message-ID: <51D40E72.3030706@oracle.com> On 07/03/2013 04:27 AM, Aleksey Shipilev wrote: > On 07/03/2013 03:24 PM, Jonathan Gibbons wrote: >> I scanned through some of this report. It is hard to know how we can >> best make use of it. In addition, some of the "major issues" don't seem >> so major to me -- like "superfluous parentheses". And "security issues" >> come up as just "info". > Yes, because JDK is somewhat special when it comes to code style, issues > to track, etc. This can be handled by fine tuning the warnings we are > looking for. > >> I don't think one report for the JDK is the best way to go. If we could >> configure a report for each of the major component areas, and configure >> the messages that are generated, then we might start to get somewhere. > I agree. But, that is harder to do when you don't own the Sonar > instance. Hence, my original question floats up again: is there a merit > to have public Sonar instance within OpenJDK, where we can fine-tune the > reports? > > -Aleksey. > I think the answer is a qualified "yes". Right now, there is a lot of activity to fix javac warnings and doclint warnings, so I'm not sure there is bandwidth available for people to deal with Sonar issues as well. But I think there is scope for people to investigate how best to configure Sonar to generate useful reports that people may be interested in. -- Jon From aleksey.shipilev at oracle.com Wed Jul 3 04:47:12 2013 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Wed, 03 Jul 2013 15:47:12 +0400 Subject: CodeTools proposal: "friday stats" In-Reply-To: <51D40E72.3030706@oracle.com> References: <51BF56D4.9020603@oracle.com> <51C0019B.4070103@oracle.com> <51D1913B.1020801@oracle.com> <51D3F861.6090506@oracle.com> <51D400B0.90205@oracle.com> <51D409FC.3070503@oracle.com> <51D40AAD.4000909@oracle.com> <51D40E72.3030706@oracle.com> Message-ID: <51D40F40.8020606@oracle.com> On 07/03/2013 03:43 PM, Jonathan Gibbons wrote: > On 07/03/2013 04:27 AM, Aleksey Shipilev wrote: >> On 07/03/2013 03:24 PM, Jonathan Gibbons wrote: >>> I scanned through some of this report. It is hard to know how we can >>> best make use of it. In addition, some of the "major issues" don't seem >>> so major to me -- like "superfluous parentheses". And "security issues" >>> come up as just "info". >> Yes, because JDK is somewhat special when it comes to code style, issues >> to track, etc. This can be handled by fine tuning the warnings we are >> looking for. >> >>> I don't think one report for the JDK is the best way to go. If we could >>> configure a report for each of the major component areas, and configure >>> the messages that are generated, then we might start to get somewhere. >> I agree. But, that is harder to do when you don't own the Sonar >> instance. Hence, my original question floats up again: is there a merit >> to have public Sonar instance within OpenJDK, where we can fine-tune the >> reports? > I think the answer is a qualified "yes". Right now, there is a lot of > activity to fix javac warnings and doclint warnings, so I'm not sure > there is bandwidth available for people to deal with Sonar issues > as well. But I think there is scope for people to investigate how > best to configure Sonar to generate useful reports that people may > be interested in. Sounds good. I'll work with Evgeny in background to get the rulesets adjusted. -Aleksey. P.S. Now stop responding to the mail, and go enjoy the semi-vacation! From sadhak001 at gmail.com Thu Jul 11 14:57:50 2013 From: sadhak001 at gmail.com (Mani Sarkar) Date: Thu, 11 Jul 2013 22:57:50 +0100 Subject: Sonar / coverity for OpenJDK Message-ID: Hi, I have been following your messages, and understand that you are working on a Sonar instance to do Code Coverage (static analysis) on the OpenJDK code base - especially the Java bits. I have been successful in setting up a sonar instance for a number of these projects and happy to share know-how and configuration details on them - if requested. To reduce any noise in the analysis we can configure each project directly and only target the aspects that interest us most - all profiles are constumisable in this fashion, i.e CheckStyle, PMD, etc... Any other progress in this area, would love to know. Thanks. Cheers, mani -- *Twitter:* @theNeomatrix369 *Blog:* http://neomatrix369.wordpress.com *JUG activity:* LJC Advocate (@adoptopenjdk & @adoptajsr programs) *Meet-a-Project:* https://github.com/MutabilityDetector *Bitbucket:* https://bitbucket.org/neomatrix369 * **Github:* https://github .com/neomatrix369 *LinkedIn:* http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b *Devoxx UK 2013* was a grand success: http://www.devoxx.com/display/UK13/Home *Don't chase success, rather aim for "Excellence", and success will come chasing after you!*