From magnus.ihse.bursie at oracle.com  Mon Nov 11 12:26:07 2013
From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie)
Date: Mon, 11 Nov 2013 21:26:07 +0100
Subject: CodeTool proposal: Webrev
Message-ID: <52813D5F.5070408@oracle.com>

Name: WebRev

Summary: A tool for generating a bunch of static html pages, widely 
accepted as the default way of performing code reviews in the OpenJDK 
project.

Proposed by: Magnus Ihse Bursie

Rationale:

The WebRev tool has existed a long time. It is the de-facto way of 
requesting code reviews in the OpenJDK project.

However, the tool has been versioned alongside the code itself, in 
make/scripts/webrev.ksh. This means that there are different versions of 
the script around in different forests. Any new fixes or features must 
be propagated to all forests, or the functionality will not be available 
everywhere. This is unlikely to happen.

Because of this, people tend to keep their own private copies, and 
update them manually. Also, these private copies do in some cases 
include patches or additions that might be beneficial to all users of 
WebRev.

Moving the tool to a separate repository would solve all these problems.

There is a bug on JBS tracking the removal of WebRev from the JDK repos, 
see https://bugs.openjdk.java.net/browse/JDK-8028145. For this to be 
able to happen, a new home must first be found for the WebRev script.

/Magnus

From jonathan.gibbons at oracle.com  Mon Nov 11 13:54:44 2013
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Mon, 11 Nov 2013 13:54:44 -0800
Subject: CodeTool proposal: Webrev
In-Reply-To: <52813D5F.5070408@oracle.com>
References: <52813D5F.5070408@oracle.com>
Message-ID: <52815224.3090201@oracle.com>

On 11/11/2013 12:26 PM, Magnus Ihse Bursie wrote:
> Name: WebRev
>
> Summary: A tool for generating a bunch of static html pages, widely 
> accepted as the default way of performing code reviews in the OpenJDK 
> project.
>
> Proposed by: Magnus Ihse Bursie
>
> Rationale:
>
> The WebRev tool has existed a long time. It is the de-facto way of 
> requesting code reviews in the OpenJDK project.
>
> However, the tool has been versioned alongside the code itself, in 
> make/scripts/webrev.ksh. This means that there are different versions 
> of the script around in different forests. Any new fixes or features 
> must be propagated to all forests, or the functionality will not be 
> available everywhere. This is unlikely to happen.
>
> Because of this, people tend to keep their own private copies, and 
> update them manually. Also, these private copies do in some cases 
> include patches or additions that might be beneficial to all users of 
> WebRev.
>
> Moving the tool to a separate repository would solve all these problems.
>
> There is a bug on JBS tracking the removal of WebRev from the JDK 
> repos, see https://bugs.openjdk.java.net/browse/JDK-8028145. For this 
> to be able to happen, a new home must first be found for the WebRev 
> script.
>
> /Magnus

This seems like a fine idea.

-- Jon

From jonathan.gibbons at oracle.com  Wed Nov 13 12:12:56 2013
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Wed, 13 Nov 2013 12:12:56 -0800
Subject: CodeTool proposal: Webrev
In-Reply-To: <52813D5F.5070408@oracle.com>
References: <52813D5F.5070408@oracle.com>
Message-ID: <5283DD48.3060402@oracle.com>

On 11/11/2013 12:26 PM, Magnus Ihse Bursie wrote:
> Name: WebRev
>
> Summary: A tool for generating a bunch of static html pages, widely 
> accepted as the default way of performing code reviews in the OpenJDK 
> project.
>
> Proposed by: Magnus Ihse Bursie
>
> Rationale:
>
> The WebRev tool has existed a long time. It is the de-facto way of 
> requesting code reviews in the OpenJDK project.
>
> However, the tool has been versioned alongside the code itself, in 
> make/scripts/webrev.ksh. This means that there are different versions 
> of the script around in different forests. Any new fixes or features 
> must be propagated to all forests, or the functionality will not be 
> available everywhere. This is unlikely to happen.
>
> Because of this, people tend to keep their own private copies, and 
> update them manually. Also, these private copies do in some cases 
> include patches or additions that might be beneficial to all users of 
> WebRev.
>
> Moving the tool to a separate repository would solve all these problems.
>
> There is a bug on JBS tracking the removal of WebRev from the JDK 
> repos, see https://bugs.openjdk.java.net/browse/JDK-8028145. For this 
> to be able to happen, a new home must first be found for the WebRev 
> script.
>
> /Magnus

In the absence of any reasons to the contrary, I suggest we move forward 
on hosting webrev within the code-tools project.

-- Jon