CodeTool proposal: Webrev

Jonathan Gibbons jonathan.gibbons at
Wed Nov 13 12:12:56 PST 2013

On 11/11/2013 12:26 PM, Magnus Ihse Bursie wrote:
> Name: WebRev
> Summary: A tool for generating a bunch of static html pages, widely 
> accepted as the default way of performing code reviews in the OpenJDK 
> project.
> Proposed by: Magnus Ihse Bursie
> Rationale:
> The WebRev tool has existed a long time. It is the de-facto way of 
> requesting code reviews in the OpenJDK project.
> However, the tool has been versioned alongside the code itself, in 
> make/scripts/webrev.ksh. This means that there are different versions 
> of the script around in different forests. Any new fixes or features 
> must be propagated to all forests, or the functionality will not be 
> available everywhere. This is unlikely to happen.
> Because of this, people tend to keep their own private copies, and 
> update them manually. Also, these private copies do in some cases 
> include patches or additions that might be beneficial to all users of 
> WebRev.
> Moving the tool to a separate repository would solve all these problems.
> There is a bug on JBS tracking the removal of WebRev from the JDK 
> repos, see For this 
> to be able to happen, a new home must first be found for the WebRev 
> script.
> /Magnus

In the absence of any reasons to the contrary, I suggest we move forward 
on hosting webrev within the code-tools project.

-- Jon

More information about the code-tools-dev mailing list