From volker.simonis at gmail.com Fri May 2 05:48:44 2014 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 2 May 2014 07:48:44 +0200 Subject: Proposal: Javac Abstract Syntax Tree Viewer In-Reply-To: <535E98E0.8050307@oracle.com> References: <535E98E0.8050307@oracle.com> Message-ID: Hi Jan, will this new tool integrate with and/or reuse parts of the Ideal Graph Visualizer [1], [2] already used in HotSpot and Graal? Thanks, Volker [1] http://ssw.jku.at/General/Staff/TW/igv.html [2] https://wikis.oracle.com/display/HotSpotInternals/IdealGraphVisualizer On Monday, April 28, 2014, Jan Lahoda wrote: > Hi, > > I would like to propose a tool for inclusion to the Code Tools project: > > --- > Tool Name: Javac Abstract Syntax Tree Viewer > > Summary: Graphical viewer for inspection of AST, and other data, produced > by the standard Java compiler, javac. > > Proposed By: Jan Lahoda > > Rationale: > The way javac models source code is not always easy to grasp, despite all > attempts to make it as convenient as possible. Being able to actually see > and inspect the AST and related information using a convenient UI is > therefore very useful. > > Hereby, a GUI tool to visualize javac ASTs and related information is > proposed for the Code Tools project. The primary target audience of the > tool are clients using the javac source code modeling APIs. Secondary > target audience are javac developers themselves. The tool should therefore > also support inspection of javac internal aspects of the model. > --- > > Thanks, > Jan > From jan.lahoda at oracle.com Fri May 2 11:10:51 2014 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 02 May 2014 13:10:51 +0200 Subject: Proposal: Javac Abstract Syntax Tree Viewer In-Reply-To: References: <535E98E0.8050307@oracle.com> Message-ID: <53637D3B.6030503@oracle.com> Hi Volker, I was not considering that so far. I might have been confusing saying "graphical". What I meant so far was a GUI, not painting the AST as a graph. My current prototype is simply a text pane showing the source code and a tree view showing the AST for the source code. Thanks, Jan On 05/02/2014 07:48 AM, Volker Simonis wrote: > Hi Jan, > > will this new tool integrate with and/or reuse parts of the Ideal Graph > Visualizer [1], [2] already used in HotSpot and Graal? > > Thanks, > Volker > > [1] http://ssw.jku.at/General/Staff/TW/igv.html > [2] https://wikis.oracle.com/display/HotSpotInternals/IdealGraphVisualizer > > On Monday, April 28, 2014, Jan Lahoda > wrote: > > Hi, > > I would like to propose a tool for inclusion to the Code Tools project: > > --- > Tool Name: Javac Abstract Syntax Tree Viewer > > Summary: Graphical viewer for inspection of AST, and other data, > produced by the standard Java compiler, javac. > > Proposed By: Jan Lahoda > > Rationale: > The way javac models source code is not always easy to grasp, > despite all attempts to make it as convenient as possible. Being > able to actually see and inspect the AST and related information > using a convenient UI is therefore very useful. > > Hereby, a GUI tool to visualize javac ASTs and related information > is proposed for the Code Tools project. The primary target audience > of the tool are clients using the javac source code modeling APIs. > Secondary target audience are javac developers themselves. The tool > should therefore also support inspection of javac internal aspects > of the model. > --- > > Thanks, > Jan > From cnewland at chrisnewland.com Fri May 2 12:55:35 2014 From: cnewland at chrisnewland.com (Chris Newland) Date: Fri, 2 May 2014 13:55:35 +0100 Subject: Proposal: Javac Abstract Syntax Tree Viewer In-Reply-To: <53637D3B.6030503@oracle.com> References: <535E98E0.8050307@oracle.com> <53637D3B.6030503@oracle.com> Message-ID: <32377be58fd30319f06cf7c5cbc5f823.squirrel@excalibur.xssl.net> Hi Jan, Do you mean something like this: http://www.eclipse.org/jdt/ui/astview/index.php I'm also working on a tool as part of the Adoption Group (https://wiki.openjdk.java.net/display/Adoption/Main) that may be suitable for code-tools. I don't mean to hijack the thread but there may be some crossover. I've built a tool called JITWatch[1] for visualising the result of HotSpot's LogCompilation output but it can also be used for more general bytecode analysis and I think an AST viewer would be a great addition. Happy to work together on this if you like? Kind regards, Chris Newland @chriswhocodes [1] https://github.com/AdoptOpenJDK/jitwatch/wiki > Hi Volker, > > I was not considering that so far. I might have been confusing saying > "graphical". What I meant so far was a GUI, not painting the AST as a > graph. My current prototype is simply a text pane showing the source > code and a tree view showing the AST for the source code. > > Thanks, > Jan > > On 05/02/2014 07:48 AM, Volker Simonis wrote: >> Hi Jan, >> >> will this new tool integrate with and/or reuse parts of the Ideal Graph >> Visualizer [1], [2] already used in HotSpot and Graal? >> >> Thanks, >> Volker >> >> [1] http://ssw.jku.at/General/Staff/TW/igv.html >> [2] >> https://wikis.oracle.com/display/HotSpotInternals/IdealGraphVisualizer >> >> On Monday, April 28, 2014, Jan Lahoda > > wrote: >> >> Hi, >> >> I would like to propose a tool for inclusion to the Code Tools >> project: >> >> --- >> Tool Name: Javac Abstract Syntax Tree Viewer >> >> Summary: Graphical viewer for inspection of AST, and other data, >> produced by the standard Java compiler, javac. >> >> Proposed By: Jan Lahoda >> >> Rationale: >> The way javac models source code is not always easy to grasp, >> despite all attempts to make it as convenient as possible. Being >> able to actually see and inspect the AST and related information >> using a convenient UI is therefore very useful. >> >> Hereby, a GUI tool to visualize javac ASTs and related information >> is proposed for the Code Tools project. The primary target audience >> of the tool are clients using the javac source code modeling APIs. >> Secondary target audience are javac developers themselves. The tool >> should therefore also support inspection of javac internal aspects >> of the model. >> --- >> >> Thanks, >> Jan >> > From fweimer at redhat.com Mon May 5 09:54:43 2014 From: fweimer at redhat.com (Florian Weimer) Date: Mon, 05 May 2014 11:54:43 +0200 Subject: JMH does not compile on JDK 8 due to Javadocs errors Message-ID: <53675FE3.3010200@redhat.com> Do you want patches to fix this? Should they just drop the Javadocs that are incomplete and do not any values? In the meantime, you could update the wiki to recommend compiling with -Dmaven.javadoc.skip=true. -- Florian Weimer / Red Hat Product Security Team From jan.lahoda at oracle.com Mon May 5 14:25:25 2014 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Mon, 05 May 2014 16:25:25 +0200 Subject: Proposal: Javac Abstract Syntax Tree Viewer In-Reply-To: <32377be58fd30319f06cf7c5cbc5f823.squirrel@excalibur.xssl.net> References: <535E98E0.8050307@oracle.com> <53637D3B.6030503@oracle.com> <32377be58fd30319f06cf7c5cbc5f823.squirrel@excalibur.xssl.net> Message-ID: <53679F55.30200@oracle.com> Hi Chris, On 05/02/2014 02:55 PM, Chris Newland wrote: > Hi Jan, > > Do you mean something like this: > http://www.eclipse.org/jdt/ui/astview/index.php Yes, something like that (inspired more by the NetBeans version of thereof, and providing some more information about javac internal states). > > I'm also working on a tool as part of the Adoption Group > (https://wiki.openjdk.java.net/display/Adoption/Main) that may be suitable > for code-tools. > > I don't mean to hijack the thread but there may be some crossover. > > I've built a tool called JITWatch[1] for visualising the result of > HotSpot's LogCompilation output but it can also be used for more general > bytecode analysis and I think an AST viewer would be a great addition. > > Happy to work together on this if you like? Not sure how big is the overlap (analysis of compile-time data compared to analysis of run-time data), but if it would make sense, we should collaborate. What are your plans on this? Thanks, Jan > > Kind regards, > > Chris Newland > @chriswhocodes > > [1] https://github.com/AdoptOpenJDK/jitwatch/wiki > > >> Hi Volker, >> >> I was not considering that so far. I might have been confusing saying >> "graphical". What I meant so far was a GUI, not painting the AST as a >> graph. My current prototype is simply a text pane showing the source >> code and a tree view showing the AST for the source code. >> >> Thanks, >> Jan >> >> On 05/02/2014 07:48 AM, Volker Simonis wrote: >>> Hi Jan, >>> >>> will this new tool integrate with and/or reuse parts of the Ideal Graph >>> Visualizer [1], [2] already used in HotSpot and Graal? >>> >>> Thanks, >>> Volker >>> >>> [1] http://ssw.jku.at/General/Staff/TW/igv.html >>> [2] >>> https://wikis.oracle.com/display/HotSpotInternals/IdealGraphVisualizer >>> >>> On Monday, April 28, 2014, Jan Lahoda >> > wrote: >>> >>> Hi, >>> >>> I would like to propose a tool for inclusion to the Code Tools >>> project: >>> >>> --- >>> Tool Name: Javac Abstract Syntax Tree Viewer >>> >>> Summary: Graphical viewer for inspection of AST, and other data, >>> produced by the standard Java compiler, javac. >>> >>> Proposed By: Jan Lahoda >>> >>> Rationale: >>> The way javac models source code is not always easy to grasp, >>> despite all attempts to make it as convenient as possible. Being >>> able to actually see and inspect the AST and related information >>> using a convenient UI is therefore very useful. >>> >>> Hereby, a GUI tool to visualize javac ASTs and related information >>> is proposed for the Code Tools project. The primary target audience >>> of the tool are clients using the javac source code modeling APIs. >>> Secondary target audience are javac developers themselves. The tool >>> should therefore also support inspection of javac internal aspects >>> of the model. >>> --- >>> >>> Thanks, >>> Jan >>> >> > > From cnewland at chrisnewland.com Tue May 6 10:12:36 2014 From: cnewland at chrisnewland.com (Chris Newland) Date: Tue, 6 May 2014 11:12:36 +0100 Subject: Proposal: Javac Abstract Syntax Tree Viewer In-Reply-To: <53679F55.30200@oracle.com> References: <535E98E0.8050307@oracle.com> <53637D3B.6030503@oracle.com> <32377be58fd30319f06cf7c5cbc5f823.squirrel@excalibur.xssl.net> <53679F55.30200@oracle.com> Message-ID: Hi Jan, Would your AST tool be written in Java? JITWatch is uses Java 7 features and has a JavaFX UI which may be a hurdle to getting it into code-tools. Given that the other code tools are tightly focussed perhaps we'd be better keeping them as separate projects and looking at a possible integration further down the line? Kind regards, Chris > Hi Chris, > > On 05/02/2014 02:55 PM, Chris Newland wrote: >> Hi Jan, >> >> Do you mean something like this: >> http://www.eclipse.org/jdt/ui/astview/index.php > > Yes, something like that (inspired more by the NetBeans version of > thereof, and providing some more information about javac internal states). > >> >> I'm also working on a tool as part of the Adoption Group >> (https://wiki.openjdk.java.net/display/Adoption/Main) that may be >> suitable >> for code-tools. >> >> I don't mean to hijack the thread but there may be some crossover. >> >> I've built a tool called JITWatch[1] for visualising the result of >> HotSpot's LogCompilation output but it can also be used for more general >> bytecode analysis and I think an AST viewer would be a great addition. >> >> Happy to work together on this if you like? > > Not sure how big is the overlap (analysis of compile-time data compared > to analysis of run-time data), but if it would make sense, we should > collaborate. What are your plans on this? > > Thanks, > Jan > >> >> Kind regards, >> >> Chris Newland >> @chriswhocodes >> >> [1] https://github.com/AdoptOpenJDK/jitwatch/wiki >> >> >>> Hi Volker, >>> >>> I was not considering that so far. I might have been confusing saying >>> "graphical". What I meant so far was a GUI, not painting the AST as a >>> graph. My current prototype is simply a text pane showing the source >>> code and a tree view showing the AST for the source code. >>> >>> Thanks, >>> Jan >>> >>> On 05/02/2014 07:48 AM, Volker Simonis wrote: >>>> Hi Jan, >>>> >>>> will this new tool integrate with and/or reuse parts of the Ideal >>>> Graph >>>> Visualizer [1], [2] already used in HotSpot and Graal? >>>> >>>> Thanks, >>>> Volker >>>> >>>> [1] http://ssw.jku.at/General/Staff/TW/igv.html >>>> [2] >>>> https://wikis.oracle.com/display/HotSpotInternals/IdealGraphVisualizer >>>> >>>> On Monday, April 28, 2014, Jan Lahoda >>> > wrote: >>>> >>>> Hi, >>>> >>>> I would like to propose a tool for inclusion to the Code Tools >>>> project: >>>> >>>> --- >>>> Tool Name: Javac Abstract Syntax Tree Viewer >>>> >>>> Summary: Graphical viewer for inspection of AST, and other data, >>>> produced by the standard Java compiler, javac. >>>> >>>> Proposed By: Jan Lahoda >>>> >>>> Rationale: >>>> The way javac models source code is not always easy to grasp, >>>> despite all attempts to make it as convenient as possible. Being >>>> able to actually see and inspect the AST and related information >>>> using a convenient UI is therefore very useful. >>>> >>>> Hereby, a GUI tool to visualize javac ASTs and related >>>> information >>>> is proposed for the Code Tools project. The primary target >>>> audience >>>> of the tool are clients using the javac source code modeling >>>> APIs. >>>> Secondary target audience are javac developers themselves. The >>>> tool >>>> should therefore also support inspection of javac internal >>>> aspects >>>> of the model. >>>> --- >>>> >>>> Thanks, >>>> Jan >>>> >>> >> >> > From jan.lahoda at oracle.com Wed May 7 21:30:32 2014 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Wed, 07 May 2014 23:30:32 +0200 Subject: Proposal: Javac Abstract Syntax Tree Viewer In-Reply-To: References: <535E98E0.8050307@oracle.com> <53637D3B.6030503@oracle.com> <32377be58fd30319f06cf7c5cbc5f823.squirrel@excalibur.xssl.net> <53679F55.30200@oracle.com> Message-ID: <536AA5F8.4040802@oracle.com> Hi Chris, On 6.5.2014 12:12, Chris Newland wrote: > Hi Jan, > > Would your AST tool be written in Java? JITWatch is uses Java 7 features Yes, written in Java. > and has a JavaFX UI which may be a hurdle to getting it into code-tools. > > Given that the other code tools are tightly focussed perhaps we'd be > better keeping them as separate projects and looking at a possible > integration further down the line? That sounds good to me. Thanks, Jan > > Kind regards, > > Chris > >> Hi Chris, >> >> On 05/02/2014 02:55 PM, Chris Newland wrote: >>> Hi Jan, >>> >>> Do you mean something like this: >>> http://www.eclipse.org/jdt/ui/astview/index.php >> >> Yes, something like that (inspired more by the NetBeans version of >> thereof, and providing some more information about javac internal states). >> >>> >>> I'm also working on a tool as part of the Adoption Group >>> (https://wiki.openjdk.java.net/display/Adoption/Main) that may be >>> suitable >>> for code-tools. >>> >>> I don't mean to hijack the thread but there may be some crossover. >>> >>> I've built a tool called JITWatch[1] for visualising the result of >>> HotSpot's LogCompilation output but it can also be used for more general >>> bytecode analysis and I think an AST viewer would be a great addition. >>> >>> Happy to work together on this if you like? >> >> Not sure how big is the overlap (analysis of compile-time data compared >> to analysis of run-time data), but if it would make sense, we should >> collaborate. What are your plans on this? >> >> Thanks, >> Jan >> >>> >>> Kind regards, >>> >>> Chris Newland >>> @chriswhocodes >>> >>> [1] https://github.com/AdoptOpenJDK/jitwatch/wiki >>> >>> >>>> Hi Volker, >>>> >>>> I was not considering that so far. I might have been confusing saying >>>> "graphical". What I meant so far was a GUI, not painting the AST as a >>>> graph. My current prototype is simply a text pane showing the source >>>> code and a tree view showing the AST for the source code. >>>> >>>> Thanks, >>>> Jan >>>> >>>> On 05/02/2014 07:48 AM, Volker Simonis wrote: >>>>> Hi Jan, >>>>> >>>>> will this new tool integrate with and/or reuse parts of the Ideal >>>>> Graph >>>>> Visualizer [1], [2] already used in HotSpot and Graal? >>>>> >>>>> Thanks, >>>>> Volker >>>>> >>>>> [1] http://ssw.jku.at/General/Staff/TW/igv.html >>>>> [2] >>>>> https://wikis.oracle.com/display/HotSpotInternals/IdealGraphVisualizer >>>>> >>>>> On Monday, April 28, 2014, Jan Lahoda >>>> > wrote: >>>>> >>>>> Hi, >>>>> >>>>> I would like to propose a tool for inclusion to the Code Tools >>>>> project: >>>>> >>>>> --- >>>>> Tool Name: Javac Abstract Syntax Tree Viewer >>>>> >>>>> Summary: Graphical viewer for inspection of AST, and other data, >>>>> produced by the standard Java compiler, javac. >>>>> >>>>> Proposed By: Jan Lahoda >>>>> >>>>> Rationale: >>>>> The way javac models source code is not always easy to grasp, >>>>> despite all attempts to make it as convenient as possible. Being >>>>> able to actually see and inspect the AST and related information >>>>> using a convenient UI is therefore very useful. >>>>> >>>>> Hereby, a GUI tool to visualize javac ASTs and related >>>>> information >>>>> is proposed for the Code Tools project. The primary target >>>>> audience >>>>> of the tool are clients using the javac source code modeling >>>>> APIs. >>>>> Secondary target audience are javac developers themselves. The >>>>> tool >>>>> should therefore also support inspection of javac internal >>>>> aspects >>>>> of the model. >>>>> --- >>>>> >>>>> Thanks, >>>>> Jan >>>>> >>>> >>> >>> >> > > From julius.gb at gmail.com Mon May 26 16:18:13 2014 From: julius.gb at gmail.com (Julius Gamanyi) Date: Mon, 26 May 2014 17:18:13 +0100 Subject: Suggestion: re-structure the wiki instructions to install and configure jtreg Message-ID: Hi, The suggestion I have in mind is to change the structure of the instructions to install and configure jtreg; the instruction in this useful guide "Adopt OpenJDK Intermediate & Advance experience," ( https://docs.google.com/document/d/17cgYBD_rIkj9xdqTR0CJfb_cBJe8radM2iaPZG3W4y0/edit?pli=1#) and the InstallJtreg wiki page ( https://java.net/projects/adoptopenjdk/pages/InstallJtreg). I was getting somewhat lost, other times needing to work out why some dependencies are installed via apt-get whereas others are downloaded and installed in the /opt directory. That way, after someone follows the steps, they would be able to: * know the relationship between the guide, the installJtreg wiki page ( https://java.net/projects/adoptopenjdk/pages/InstallJtreg), the top-level-steps-of-jtreg (http://openjdk.java.net/jtreg/), the top-level-steps-of-building-jtreg (http://openjdk.java.net/jtreg/build.html), and the Eclipse Project for JTReg wiki page ( https://java.net/projects/adoptopenjdk/pages/EclipseProjectForJTReg); * know the trade-offs between using a pre-built artifact and building from the latest Mercurial repositories; * have a consistent way of installing dependencies, and working out where to find the dependencies that have been installed - E.g., you need the path to set some variables in jtreg/make/build.properties; you also need to ensure that the ant version that Eclipse is using is the same one used when running on CLI; * some steps in the wiki page for setting up Eclipse are needed whether or not you're going to be using Eclipse; they also match the top-level-steps-of-building-jtreg (http://openjdk.java.net/jtreg/build.html) but do not explicitly refer to that site. Perhaps I can help with this. Thanks, Julius