From volker.simonis at gmail.com  Mon Jun  8 17:59:15 2015
From: volker.simonis at gmail.com (Volker Simonis)
Date: Mon, 8 Jun 2015 19:59:15 +0200
Subject: Webrev: "arithmetic syntax error" when working with non-commited
	changes
In-Reply-To: <5562F21F.4090201@oracle.com>
References: <1952342.tG88LHOKTp@thinkpad.hell> <5552958D.2090805@oracle.com>
	<8626727.vX7Ee776rh@thinkpad.hell>
	<4106910.qMKm2oGpkj@thinkpad.hell> <555D365B.2000105@oracle.com>
	<5562F21F.4090201@oracle.com>
Message-ID: <CA+3eh11u=TgJd53Bfi7yL+HNRs8ybatMY-SFzj=qP9+umkeKng@mail.gmail.com>

I've just run into this myself on OpenSuse 13.2 / ppc64le with the
exact same ksh version as reported above.

Can you please push this before it also affects other people.

Thanks,
Volker


On Mon, May 25, 2015 at 11:57 AM, Magnus Ihse Bursie
<magnus.ihse.bursie at oracle.com> wrote:
> On 2015-05-21 03:35, Jonathan Gibbons wrote:
>>
>>
>> On 05/20/2015 01:26 AM, Stanislav Baiduzhyi wrote:
>>>
>>> On Wednesday 13 May 2015 10:01:39 Stanislav Baiduzhyi wrote:
>>>>
>>>> On Tuesday 12 May 2015 17:06:37 Jonathan Gibbons wrote:
>>>>>
>>>>> There has been some churn recently with respect to the variable
>>>>> HG_LIST_FROM_COMMIT.
>>>>>
>>>>> See
>>>>> http://hg.openjdk.java.net/code-tools/webrev/rev/935f1eaa4691
>>>>> http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a
>>>>>
>>>>> Therefore, I would suggest whether this needs to be re-investigated in
>>>>> the light of those recent changes.  In particular, the tip has changed
>>>>> since this thread started.
>>>>
>>>> Issue still exists in current tip. I've updated the webrev, link is the
>>>> same:
>>>>
>>>> https://e5decb045a719fb58df46fd7e03c2f98cddc1ac6.googledrive.com/host/0B5Kp
>>>>
>>>> -cB1sXJrfk9NQTVHMTJTdWpYX3dWaExreWN0V0hQZ3d0eGIyZDltdHBCbmhYcXpzRFk/fix-arit
>>>> hmetic/
>>>
>>> I've experimented more with that empty value check because I still had a
>>> feeling that it was not logical. Looks like changing from classical shell
>>> braces [ to double braces [[ solves the issue already, no need for
>>> additional
>>> check. So now it's literally 3 bytes change. Please apply it before any
>>> other
>>> changes are going upstream.
>>>
>>
>> Interesting. I see the webrev man page specifies the use of [[ ]]
>> (e.g. here http://www2.research.att.com/sw/download/man/man1/ksh.html)
>> and I see the webrev script already has other instances of [[ ]].
>>
>> So, the change certainly looks reasonable. Does anyone wish to confirm
>> this behavior?  If no one objects, I'll push the change.
>
>
> Fix looks good to me.
>
> /Magnus

From volker.simonis at gmail.com  Fri Jun 26 09:09:49 2015
From: volker.simonis at gmail.com (Volker Simonis)
Date: Fri, 26 Jun 2015 11:09:49 +0200
Subject: [TESTBUG]: Syntax error in test description of
	jdk8u-dev/.../JcmdWithNMTDisabled.java ?
Message-ID: <CA+3eh13C-57mOBk6Wo_wx2gOM9O0Di6MQkMr0HpMkNqNv=qFLA@mail.gmail.com>

Hi,

after I've upgraded to the latest and greatest version of JTreg
(168:055251d38f29 "minor naming cleanup in Agent") I get an error when
executing the hotspot test:

runtime/NMT/JcmdWithNMTDisabled.java

from the jdk8u-dev (notice that the same test from the jdk9 forest
runs just fine because it was already refactored).

I think this is because of the strange tag syntax the test uses:

/*
 * @test
 * @key nmt jcmd
 * @summary Verify that jcmd correctly reports that NMT is not enabled
 * @library /testlibrary
 * First run without enabling NMT
 * @run main/othervm JcmdWithNMTDisabled
 * Then run with explicitly disabling NMT, should not be any difference
 * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled
 */

The problem is that the comment line "First run without enabling NMT"
will be appended to the "@library" tag like this:

@library /testlibrary First run without enabling NMT

yielding in strange class paths during execution which contain
"<path>/First:<path>/run:<path>/without:...". But apparently this
doesn't confuse older version of JTreg too much because the test
succeeded nevertheless.

However with the newest JTreg version the test badly fails with the error:

test result: Error. Test Class Exception: Can't find library: First

Notice that "First" is the first word of the comment line "First run
without enabling NMT" in the tag description.

So is this indeed an error in the test description of
JcmdWithNMTDisabled.java and should it be fixed by removing the two
lines:

  * @library /testlibrary
- * First run without enabling NMT
  * @run main/othervm JcmdWithNMTDisabled
- * Then run with explicitly disabling NMT, should not be any difference
  * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled

from the test description to make it runnable with newer JTreg versions as well?

Regards,
Volker

From volker.simonis at gmail.com  Fri Jun 26 12:33:17 2015
From: volker.simonis at gmail.com (Volker Simonis)
Date: Fri, 26 Jun 2015 14:33:17 +0200
Subject: [TESTBUG]: Syntax error in test description of
	jdk8u-dev/.../JcmdWithNMTDisabled.java ?
In-Reply-To: <558D3D4A.9090701@oracle.com>
References: <CA+3eh13C-57mOBk6Wo_wx2gOM9O0Di6MQkMr0HpMkNqNv=qFLA@mail.gmail.com>
	<558D3D4A.9090701@oracle.com>
Message-ID: <CA+3eh11a03d68-e7P3_Jn_CAPvdCn57fPjLfUfqxyF-QzU-P7w@mail.gmail.com>

Thanks David,

It's also amazing that this actually did run with older versions of
jtreg without producing an error (altough it produced a lot of
useless, empty directories  - on for each word in the 'comment' lines
:)

So I assume somebody is taking care of this issue.

Regards,
Volker


On Fri, Jun 26, 2015 at 1:53 PM, David Holmes <david.holmes at oracle.com> wrote:
> Hi Volker,
>
> Known issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8098541 (not public sorry)
>
> but mis-processed in my opinion so I'm trying to get it re-addressed.
>
> It's amazing how many people had no idea that tags spanned multiple lines,
> and that there was no commenting mechanism. :(
>
> David
>
>
> On 26/06/2015 7:09 PM, Volker Simonis wrote:
>>
>> Hi,
>>
>> after I've upgraded to the latest and greatest version of JTreg
>> (168:055251d38f29 "minor naming cleanup in Agent") I get an error when
>> executing the hotspot test:
>>
>> runtime/NMT/JcmdWithNMTDisabled.java
>>
>> from the jdk8u-dev (notice that the same test from the jdk9 forest
>> runs just fine because it was already refactored).
>>
>> I think this is because of the strange tag syntax the test uses:
>>
>> /*
>>   * @test
>>   * @key nmt jcmd
>>   * @summary Verify that jcmd correctly reports that NMT is not enabled
>>   * @library /testlibrary
>>   * First run without enabling NMT
>>   * @run main/othervm JcmdWithNMTDisabled
>>   * Then run with explicitly disabling NMT, should not be any difference
>>   * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled
>>   */
>>
>> The problem is that the comment line "First run without enabling NMT"
>> will be appended to the "@library" tag like this:
>>
>> @library /testlibrary First run without enabling NMT
>>
>> yielding in strange class paths during execution which contain
>> "<path>/First:<path>/run:<path>/without:...". But apparently this
>> doesn't confuse older version of JTreg too much because the test
>> succeeded nevertheless.
>>
>> However with the newest JTreg version the test badly fails with the error:
>>
>> test result: Error. Test Class Exception: Can't find library: First
>>
>> Notice that "First" is the first word of the comment line "First run
>> without enabling NMT" in the tag description.
>>
>> So is this indeed an error in the test description of
>> JcmdWithNMTDisabled.java and should it be fixed by removing the two
>> lines:
>>
>>    * @library /testlibrary
>> - * First run without enabling NMT
>>    * @run main/othervm JcmdWithNMTDisabled
>> - * Then run with explicitly disabling NMT, should not be any difference
>>    * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled
>>
>> from the test description to make it runnable with newer JTreg versions as
>> well?
>>
>> Regards,
>> Volker
>>
>

From david.holmes at oracle.com  Fri Jun 26 11:53:46 2015
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 26 Jun 2015 21:53:46 +1000
Subject: [TESTBUG]: Syntax error in test description of
	jdk8u-dev/.../JcmdWithNMTDisabled.java ?
In-Reply-To: <CA+3eh13C-57mOBk6Wo_wx2gOM9O0Di6MQkMr0HpMkNqNv=qFLA@mail.gmail.com>
References: <CA+3eh13C-57mOBk6Wo_wx2gOM9O0Di6MQkMr0HpMkNqNv=qFLA@mail.gmail.com>
Message-ID: <558D3D4A.9090701@oracle.com>

Hi Volker,

Known issue:

https://bugs.openjdk.java.net/browse/JDK-8098541 (not public sorry)

but mis-processed in my opinion so I'm trying to get it re-addressed.

It's amazing how many people had no idea that tags spanned multiple 
lines, and that there was no commenting mechanism. :(

David

On 26/06/2015 7:09 PM, Volker Simonis wrote:
> Hi,
>
> after I've upgraded to the latest and greatest version of JTreg
> (168:055251d38f29 "minor naming cleanup in Agent") I get an error when
> executing the hotspot test:
>
> runtime/NMT/JcmdWithNMTDisabled.java
>
> from the jdk8u-dev (notice that the same test from the jdk9 forest
> runs just fine because it was already refactored).
>
> I think this is because of the strange tag syntax the test uses:
>
> /*
>   * @test
>   * @key nmt jcmd
>   * @summary Verify that jcmd correctly reports that NMT is not enabled
>   * @library /testlibrary
>   * First run without enabling NMT
>   * @run main/othervm JcmdWithNMTDisabled
>   * Then run with explicitly disabling NMT, should not be any difference
>   * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled
>   */
>
> The problem is that the comment line "First run without enabling NMT"
> will be appended to the "@library" tag like this:
>
> @library /testlibrary First run without enabling NMT
>
> yielding in strange class paths during execution which contain
> "<path>/First:<path>/run:<path>/without:...". But apparently this
> doesn't confuse older version of JTreg too much because the test
> succeeded nevertheless.
>
> However with the newest JTreg version the test badly fails with the error:
>
> test result: Error. Test Class Exception: Can't find library: First
>
> Notice that "First" is the first word of the comment line "First run
> without enabling NMT" in the tag description.
>
> So is this indeed an error in the test description of
> JcmdWithNMTDisabled.java and should it be fixed by removing the two
> lines:
>
>    * @library /testlibrary
> - * First run without enabling NMT
>    * @run main/othervm JcmdWithNMTDisabled
> - * Then run with explicitly disabling NMT, should not be any difference
>    * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled
>
> from the test description to make it runnable with newer JTreg versions as well?
>
> Regards,
> Volker
>

From david.holmes at oracle.com  Fri Jun 26 12:38:26 2015
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 26 Jun 2015 22:38:26 +1000
Subject: [TESTBUG]: Syntax error in test description of
	jdk8u-dev/.../JcmdWithNMTDisabled.java ?
In-Reply-To: <CA+3eh11a03d68-e7P3_Jn_CAPvdCn57fPjLfUfqxyF-QzU-P7w@mail.gmail.com>
References: <CA+3eh13C-57mOBk6Wo_wx2gOM9O0Di6MQkMr0HpMkNqNv=qFLA@mail.gmail.com>
	<558D3D4A.9090701@oracle.com>
	<CA+3eh11a03d68-e7P3_Jn_CAPvdCn57fPjLfUfqxyF-QzU-P7w@mail.gmail.com>
Message-ID: <558D47C2.2010407@oracle.com>

On 26/06/2015 10:33 PM, Volker Simonis wrote:
> Thanks David,
>
> It's also amazing that this actually did run with older versions of
> jtreg without producing an error (altough it produced a lot of
> useless, empty directories  - on for each word in the 'comment' lines
> :)
>
> So I assume somebody is taking care of this issue.

I hope so. Unfortunately the timing is bad. jdk8u/hs-dev is now closed 
for 8u60 changes as the final snapshot has been taken before 8u60 hits 
RDP2. That means this change must either quickly zip in via jdk8u/dev 
before RDP2, or it will either miss 8u60 or else require special 
approval (which is unlikely as it isn't a P1 or P2 issue).

David

> Regards,
> Volker
>
>
> On Fri, Jun 26, 2015 at 1:53 PM, David Holmes <david.holmes at oracle.com> wrote:
>> Hi Volker,
>>
>> Known issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8098541 (not public sorry)
>>
>> but mis-processed in my opinion so I'm trying to get it re-addressed.
>>
>> It's amazing how many people had no idea that tags spanned multiple lines,
>> and that there was no commenting mechanism. :(
>>
>> David
>>
>>
>> On 26/06/2015 7:09 PM, Volker Simonis wrote:
>>>
>>> Hi,
>>>
>>> after I've upgraded to the latest and greatest version of JTreg
>>> (168:055251d38f29 "minor naming cleanup in Agent") I get an error when
>>> executing the hotspot test:
>>>
>>> runtime/NMT/JcmdWithNMTDisabled.java
>>>
>>> from the jdk8u-dev (notice that the same test from the jdk9 forest
>>> runs just fine because it was already refactored).
>>>
>>> I think this is because of the strange tag syntax the test uses:
>>>
>>> /*
>>>    * @test
>>>    * @key nmt jcmd
>>>    * @summary Verify that jcmd correctly reports that NMT is not enabled
>>>    * @library /testlibrary
>>>    * First run without enabling NMT
>>>    * @run main/othervm JcmdWithNMTDisabled
>>>    * Then run with explicitly disabling NMT, should not be any difference
>>>    * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled
>>>    */
>>>
>>> The problem is that the comment line "First run without enabling NMT"
>>> will be appended to the "@library" tag like this:
>>>
>>> @library /testlibrary First run without enabling NMT
>>>
>>> yielding in strange class paths during execution which contain
>>> "<path>/First:<path>/run:<path>/without:...". But apparently this
>>> doesn't confuse older version of JTreg too much because the test
>>> succeeded nevertheless.
>>>
>>> However with the newest JTreg version the test badly fails with the error:
>>>
>>> test result: Error. Test Class Exception: Can't find library: First
>>>
>>> Notice that "First" is the first word of the comment line "First run
>>> without enabling NMT" in the tag description.
>>>
>>> So is this indeed an error in the test description of
>>> JcmdWithNMTDisabled.java and should it be fixed by removing the two
>>> lines:
>>>
>>>     * @library /testlibrary
>>> - * First run without enabling NMT
>>>     * @run main/othervm JcmdWithNMTDisabled
>>> - * Then run with explicitly disabling NMT, should not be any difference
>>>     * @run main/othervm -XX:NativeMemoryTracking=off JcmdWithNMTDisabled
>>>
>>> from the test description to make it runnable with newer JTreg versions as
>>> well?
>>>
>>> Regards,
>>> Volker
>>>
>>