RFR(S): 7901304: IDPREFIX should be configurable from the environment much like BUGURL already is

[Jonathan Gibbons]

On 04/30/2015 03:07 AM, Volker Simonis wrote:
> On Wed, Apr 29, 2015 at 11:46 PM, Jonathan Gibbons
> <jonathan.gibbons at oracle.com> wrote:
>> On 02/13/2015 10:01 AM, Volker Simonis wrote:
>>> Hi,
>>>
>>> could somebody please review and sponsor the following small change:
>>>
>>> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901304/
>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901304
>>>
>>> It is possible to configure the bug url for links to the corresponding
>>> OpenJDK bugs by setting the environment variable WEBREV_BUGURL.
>>>
>>> Unfortunately it is not possible to configure the IDPREFIX which is
>>> hard-wired to "JDK-". This makes it impossible to create links to the
>>> bug systems for projects like CODETOOLS.
>>>
>>> The fix is easy - just read IDPREFIX from the environment if there
>>> exists an environment variable called WEBREV_IDPREFIX (by the way, the
>>> result can be seen in the webrev which correctly links to the
>>> corresponding codetools bug :).
>>>
>>> I've also slightly reordered the place where WEBREV_BUGURL and
>>> WEBREV_IDPREFIX are initialized to make it possible to print their
>>> default values in the webrev usage text.
>>>
>>> Regards,
>>> Volker
>>
>> Volker,
>>
>> This looks like a useful patch.
>>
> Thanks!
>
>> Note that round about line 30, there is a variable WEBREV_UPDATED
>> which we have been inconsistent in updated, but have been more
>> consistent of late. The number gets updated; the additional string
>> after the "-" looks a bit moire cryptic.
>>
> Not sure if I understand you right. Do you want me to bump the version
> number in WEBREV_UPDATED in my change?
>
> I need a sponsor anyway as I can't commit to the code-tools repo. Will
> you sponsor this change?
>
> Thank you and best regards,
> Volker
>
>> -- Jon

I'll sponsor it; I'll update the WEBREV_UPDATED unless you send me a new 
patch before I get round to it.

-- Jon