RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue May 5 21:35:45 UTC 2015


On 05/05/2015 02:31 PM, Magnus Ihse Bursie wrote:
> On 2015-02-13 12:01, Volker Simonis wrote:
>> Hi,
>>
>> could somebody please review and sponsor the following small change
>> which adds a test for exactly one newline at the and of a file to
>> check:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901298/
>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901298
>
> Found this mail again now, when I wondered why it was not already fixed.
>
> The fix looks good to me, and I wish it was already in place :-). I'm 
> not a formal jcheck reviewer though. :(
>
> /Magnus

Magnus,

Please see the follow-up discussion on hg-tools-dev.
http://mail.openjdk.java.net/pipermail/hg-tools-dev/2015-April/thread.html

-- Jon


More information about the code-tools-dev mailing list