Webrev: "arithmetic syntax error" when working with non-commited changes
Stanislav Baiduzhyi
sbaiduzh at redhat.com
Wed May 20 08:26:02 UTC 2015
On Wednesday 13 May 2015 10:01:39 Stanislav Baiduzhyi wrote:
> On Tuesday 12 May 2015 17:06:37 Jonathan Gibbons wrote:
> > There has been some churn recently with respect to the variable
> > HG_LIST_FROM_COMMIT.
> >
> > See
> > http://hg.openjdk.java.net/code-tools/webrev/rev/935f1eaa4691
> > http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a
> >
> > Therefore, I would suggest whether this needs to be re-investigated in
> > the light of those recent changes. In particular, the tip has changed
> > since this thread started.
>
> Issue still exists in current tip. I've updated the webrev, link is the
> same:
> https://e5decb045a719fb58df46fd7e03c2f98cddc1ac6.googledrive.com/host/0B5Kp
> -cB1sXJrfk9NQTVHMTJTdWpYX3dWaExreWN0V0hQZ3d0eGIyZDltdHBCbmhYcXpzRFk/fix-arit
> hmetic/
I've experimented more with that empty value check because I still had a
feeling that it was not logical. Looks like changing from classical shell
braces [ to double braces [[ solves the issue already, no need for additional
check. So now it's literally 3 bytes change. Please apply it before any other
changes are going upstream.
--
Regards,
Stas
More information about the code-tools-dev
mailing list