From magnus.ihse.bursie at oracle.com Fri Oct 23 15:39:36 2015 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 23 Oct 2015 17:39:36 +0200 Subject: RFR: CODETOOLS-7901505 webrev.ksh extract of bug title fails after Jira 6 Upgrade Message-ID: <47E0FA7B-FC08-48C9-B8C1-AAE6CD8940A5@oracle.com> From the bug report: --- Since the Jira 6 upgrade, webrev.ksh does not correctly extract the bug id/title. It produces: Bug id: [JDK-8132541] (process) ProcessBuilder support for redirection to discard output - Java Bug System previously the and would have been removed by line 2749: msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` The '#' in the pattern seems to be no longer necessary. --- This patch applies the suggestion from the bug report: diff --git a/webrev.ksh b/webrev.ksh --- a/webrev.ksh +++ b/webrev.ksh @@ -27,7 +27,7 @@ # Documentation is available via 'webrev -h'. # -WEBREV_UPDATED=25.12-hg+openjdk.java.net +WEBREV_UPDATED=25.13-hg+openjdk.java.net HTML='<?xml version="1.0"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" @@ -2746,7 +2746,7 @@ url="${BUGURL}${id}" if [[ -n $WGET ]]; then - msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` + msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` fi if [[ -z $msg ]]; then msg="${id}" Example webrev without patch: http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.02/ Example webrev with patch: http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.03/ /Magnus From volker.simonis at gmail.com Mon Oct 26 08:37:22 2015 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 26 Oct 2015 09:37:22 +0100 Subject: RFR: CODETOOLS-7901505 webrev.ksh extract of bug title fails after Jira 6 Upgrade In-Reply-To: <47E0FA7B-FC08-48C9-B8C1-AAE6CD8940A5@oracle.com> References: <47E0FA7B-FC08-48C9-B8C1-AAE6CD8940A5@oracle.com> Message-ID: <CA+3eh13bu-rTw8mccY3c8oBqoxmnCZ_thbozTc4vr_WobNMw9w@mail.gmail.com> I'm not a formal CODETOOLS reviewer but I think the fix is good (I have the same in my local copy of webrev.ksh). Hopefully somebody will pick it up and sponsor it :) Regards, Volker On Fri, Oct 23, 2015 at 5:39 PM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote: > From the bug report: > --- > Since the Jira 6 upgrade, webrev.ksh does not correctly extract the bug id/title. > > It produces: > Bug id: <title>[JDK-8132541] (process) ProcessBuilder support for redirection to discard output - Java Bug System > > previously the and would have been removed by line 2749: > msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` > > The '#' in the pattern seems to be no longer necessary. > --- > > This patch applies the suggestion from the bug report: > > diff --git a/webrev.ksh b/webrev.ksh > --- a/webrev.ksh > +++ b/webrev.ksh > @@ -27,7 +27,7 @@ > # Documentation is available via 'webrev -h'. > # > > -WEBREV_UPDATED=25.12-hg+openjdk.java.net > +WEBREV_UPDATED=25.13-hg+openjdk.java.net > > HTML='<?xml version="1.0"?> > <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" > @@ -2746,7 +2746,7 @@ > url="${BUGURL}${id}" > > if [[ -n $WGET ]]; then > - msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` > + msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` > fi > if [[ -z $msg ]]; then > msg="${id}" > > > Example webrev without patch: > http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.02/ > > Example webrev with patch: > http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.03/ > > /Magnus > From jonathan.gibbons at oracle.com Mon Oct 26 21:15:38 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 26 Oct 2015 14:15:38 -0700 Subject: RFR: CODETOOLS-7901505 webrev.ksh extract of bug title fails after Jira 6 Upgrade In-Reply-To: <47E0FA7B-FC08-48C9-B8C1-AAE6CD8940A5@oracle.com> References: <47E0FA7B-FC08-48C9-B8C1-AAE6CD8940A5@oracle.com> Message-ID: <562E97FA.20600@oracle.com> I'll take care of this. -- Jon On 10/23/2015 08:39 AM, Magnus Ihse Bursie wrote: > From the bug report: > --- > Since the Jira 6 upgrade, webrev.ksh does not correctly extract the bug id/title. > > It produces: > Bug id: <title>[JDK-8132541] (process) ProcessBuilder support for redirection to discard output - Java Bug System > > previously the and would have been removed by line 2749: > msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` > > The '#' in the pattern seems to be no longer necessary. > --- > > This patch applies the suggestion from the bug report: > > diff --git a/webrev.ksh b/webrev.ksh > --- a/webrev.ksh > +++ b/webrev.ksh > @@ -27,7 +27,7 @@ > # Documentation is available via 'webrev -h'. > # > > -WEBREV_UPDATED=25.12-hg+openjdk.java.net > +WEBREV_UPDATED=25.13-hg+openjdk.java.net > > HTML='<?xml version="1.0"?> > <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" > @@ -2746,7 +2746,7 @@ > url="${BUGURL}${id}" > > if [[ -n $WGET ]]; then > - msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` > + msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` > fi > if [[ -z $msg ]]; then > msg="${id}" > > > Example webrev without patch: > http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.02/ > > Example webrev with patch: > http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.03/ > > /Magnus >