RFR: CODETOOLS-7901505 webrev.ksh extract of bug title fails after Jira 6 Upgrade

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Oct 23 15:39:36 UTC 2015


From the bug report:
---
Since the Jira 6 upgrade, webrev.ksh does not correctly extract the bug id/title. 

It produces: 
  Bug id: <title>[JDK-8132541] (process) ProcessBuilder support for redirection to discard output - Java Bug System</title> 

previously the <title> and </title> would have been removed by line 2749: 
            msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote` 

The '#' in the pattern seems to be no longer necessary. 
---

This patch applies the suggestion from the bug report:

diff --git a/webrev.ksh b/webrev.ksh
--- a/webrev.ksh
+++ b/webrev.ksh
@@ -27,7 +27,7 @@
 # Documentation is available via 'webrev -h'.
 #
 
-WEBREV_UPDATED=25.12-hg+openjdk.java.net
+WEBREV_UPDATED=25.13-hg+openjdk.java.net
 
 HTML='<?xml version="1.0"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
@@ -2746,7 +2746,7 @@
         url="${BUGURL}${id}"
 
         if [[ -n $WGET ]]; then
-            msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[#\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote`
+            msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote`
         fi
         if [[ -z $msg ]]; then
             msg="${id}"


Example webrev without patch:
http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.02/

Example webrev with patch:
http://cr.openjdk.java.net/~ihse/JDK-8140282-remove-test-directories/webrev.03/

/Magnus



More information about the code-tools-dev mailing list