From jonathan.gibbons at oracle.com  Fri Apr  1 00:42:29 2016
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Thu, 31 Mar 2016 17:42:29 -0700
Subject: RFR(XS): 7901508: JTreg with '-noshell' wrongly exectes shell
	tests with an implicit 'run shell' action
In-Reply-To: <CA+3eh11gS0Z9kVjuBJmu6BESTEin=G-dz42Mw8-ssTdyHH7LQw@mail.gmail.com>
References: <CA+3eh11gS0Z9kVjuBJmu6BESTEin=G-dz42Mw8-ssTdyHH7LQw@mail.gmail.com>
Message-ID: <56FDC3F5.10107@oracle.com>

Looks reasonable.

-- Jon

On 09/16/2015 10:18 AM, Volker Simonis wrote:
> Hi,
>
> could somebody please review and sponsor this small fix:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901508/
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901508
>
> The '-noshell' command line option should instruct JTreg to not
> execute tests which contain shell actions. Unfortunately this option
> is broken for shell tests which do not explicitly specify a run action
> with '@run shell ...'.
>
> Notice that specifying a run action is not necessary because the
> default for '.sh' files is '@run shell <filename>' anyway. There exist
> plenty of shell tests which do not specify the run action explicitly.
>
> The problem is that the pattern which checks for the run action
> wrongly assumes that the action can only be user-specified.
>
> Thank you and best regards,
> Volker


From erik.helin at oracle.com  Tue Apr 26 10:12:59 2016
From: erik.helin at oracle.com (Erik Helin)
Date: Tue, 26 Apr 2016 12:12:59 +0200
Subject: Proposal for new tool: defpath
Message-ID: <20160426101259.GA2096@ehelin.jrpg.bea.com>

Hi all,

I would like to propose a new tool: defpath. defpath is an hg [0]
extension that makes it easy to update the push-path for a Mercurial
repository. A user can type the command:

  $ hg defpath -d -u <USERNAME>

and the correct (for OpenJDK projects) push-path will be added to .hg/hgrc,
based on the default path (and the -u argument). Below is an
example of how the tool can be used:

  $ hg clone http://hg.openjdk.java.net/jdk9/hs
  $ cd hs
  $ hg defpath -d -u ehelin
  $ cat .hg/hgrc
  [paths]
  default = http://hg.openjdk.java.net/jdk9/hs
  default-push = ssh://ehelin at hg.openjdk.java.net/jdk9/hs

The defpath extension also works in combination with the
trees Mercurial extension. Working with a forest, a user can run:

  $ hg tclone http://hg.openjdk.java.net/jdk9/hs
  $ cd hs
  $ hg tdefpath -d -u <USERNAME>

and the push-path will be set for every repository in the forest.

The tool has been written by John Coomes and Mark Reinhold and can
be found at: http://cr.openjdk.java.net/~ehelin/defpath.py

I propose that the tool will use the same email list as the other
Mercurial tools on code-tools, hg-tools-dev at openjdk.java.net.

Thanks,
Erik

[0]: http://mercurial-scm.org/

From jonathan.gibbons at oracle.com  Tue Apr 26 15:24:11 2016
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Tue, 26 Apr 2016 08:24:11 -0700
Subject: Proposal for new tool: defpath
In-Reply-To: <20160426101259.GA2096@ehelin.jrpg.bea.com>
References: <20160426101259.GA2096@ehelin.jrpg.bea.com>
Message-ID: <571F881B.3080307@oracle.com>

Erik,

This sounds like a good idea.   If there is no contrary feedback in the
next few days, we should move ahead with this.

-- Jon

On 04/26/2016 03:12 AM, Erik Helin wrote:
> Hi all,
>
> I would like to propose a new tool: defpath. defpath is an hg [0]
> extension that makes it easy to update the push-path for a Mercurial
> repository. A user can type the command:
>
>    $ hg defpath -d -u <USERNAME>
>
> and the correct (for OpenJDK projects) push-path will be added to .hg/hgrc,
> based on the default path (and the -u argument). Below is an
> example of how the tool can be used:
>
>    $ hg clone http://hg.openjdk.java.net/jdk9/hs
>    $ cd hs
>    $ hg defpath -d -u ehelin
>    $ cat .hg/hgrc
>    [paths]
>    default = http://hg.openjdk.java.net/jdk9/hs
>    default-push = ssh://ehelin at hg.openjdk.java.net/jdk9/hs
>
> The defpath extension also works in combination with the
> trees Mercurial extension. Working with a forest, a user can run:
>
>    $ hg tclone http://hg.openjdk.java.net/jdk9/hs
>    $ cd hs
>    $ hg tdefpath -d -u <USERNAME>
>
> and the push-path will be set for every repository in the forest.
>
> The tool has been written by John Coomes and Mark Reinhold and can
> be found at: http://cr.openjdk.java.net/~ehelin/defpath.py
>
> I propose that the tool will use the same email list as the other
> Mercurial tools on code-tools, hg-tools-dev at openjdk.java.net.
>
> Thanks,
> Erik
>
> [0]: http://mercurial-scm.org/


From jonathan.gibbons at oracle.com  Fri Apr 29 22:00:35 2016
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Fri, 29 Apr 2016 15:00:35 -0700
Subject: Proposal for new tool: defpath
In-Reply-To: <571F881B.3080307@oracle.com>
References: <20160426101259.GA2096@ehelin.jrpg.bea.com>
	<571F881B.3080307@oracle.com>
Message-ID: <5723D983.5060605@oracle.com>

There has been no negative feedback;   I think we should proceed with this.

-- Jon

On 04/26/2016 08:24 AM, Jonathan Gibbons wrote:
> Erik,
>
> This sounds like a good idea.   If there is no contrary feedback in the
> next few days, we should move ahead with this.
>
> -- Jon
>
> On 04/26/2016 03:12 AM, Erik Helin wrote:
>> Hi all,
>>
>> I would like to propose a new tool: defpath. defpath is an hg [0]
>> extension that makes it easy to update the push-path for a Mercurial
>> repository. A user can type the command:
>>
>>    $ hg defpath -d -u <USERNAME>
>>
>> and the correct (for OpenJDK projects) push-path will be added to 
>> .hg/hgrc,
>> based on the default path (and the -u argument). Below is an
>> example of how the tool can be used:
>>
>>    $ hg clone http://hg.openjdk.java.net/jdk9/hs
>>    $ cd hs
>>    $ hg defpath -d -u ehelin
>>    $ cat .hg/hgrc
>>    [paths]
>>    default = http://hg.openjdk.java.net/jdk9/hs
>>    default-push = ssh://ehelin at hg.openjdk.java.net/jdk9/hs
>>
>> The defpath extension also works in combination with the
>> trees Mercurial extension. Working with a forest, a user can run:
>>
>>    $ hg tclone http://hg.openjdk.java.net/jdk9/hs
>>    $ cd hs
>>    $ hg tdefpath -d -u <USERNAME>
>>
>> and the push-path will be set for every repository in the forest.
>>
>> The tool has been written by John Coomes and Mark Reinhold and can
>> be found at: http://cr.openjdk.java.net/~ehelin/defpath.py
>>
>> I propose that the tool will use the same email list as the other
>> Mercurial tools on code-tools, hg-tools-dev at openjdk.java.net.
>>
>> Thanks,
>> Erik
>>
>> [0]: http://mercurial-scm.org/
>