RFR(XS): 7901508: JTreg with '-noshell' wrongly exectes shell tests with an implicit 'run shell' action

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Apr 1 00:42:29 UTC 2016

Looks reasonable.

-- Jon

On 09/16/2015 10:18 AM, Volker Simonis wrote:
> Hi,
> could somebody please review and sponsor this small fix:
> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901508/
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901508
> The '-noshell' command line option should instruct JTreg to not
> execute tests which contain shell actions. Unfortunately this option
> is broken for shell tests which do not explicitly specify a run action
> with '@run shell ...'.
> Notice that specifying a run action is not necessary because the
> default for '.sh' files is '@run shell <filename>' anyway. There exist
> plenty of shell tests which do not specify the run action explicitly.
> The problem is that the pattern which checks for the run action
> wrongly assumes that the action can only be user-specified.
> Thank you and best regards,
> Volker

More information about the code-tools-dev mailing list