From david.dehaven at oracle.com Thu Jan 7 20:18:11 2016 From: david.dehaven at oracle.com (David DeHaven) Date: Thu, 7 Jan 2016 12:18:11 -0800 Subject: RFR: CODETOOLS-7901466: Mercurial 3.4 breaks behavior of webrev -r Message-ID: <25091BFA-DB7C-4310-A3F2-CA503E7DDCF4@oracle.com> I?ve been using this patch since December and it seems to be working well with both Mercurial 2.8 and 3.6.2. I don?t think I can push to code-tools so will need a Committer to push for me. webrev (and example): http://cr.openjdk.java.net/~ddehaven/CODETOOLS-7901466/patched/ Also updated copyright year and version number. -DrD- From jonathan.gibbons at oracle.com Thu Jan 7 22:55:38 2016 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 07 Jan 2016 14:55:38 -0800 Subject: RFR: CODETOOLS-7901466: Mercurial 3.4 breaks behavior of webrev -r In-Reply-To: <25091BFA-DB7C-4310-A3F2-CA503E7DDCF4@oracle.com> References: <25091BFA-DB7C-4310-A3F2-CA503E7DDCF4@oracle.com> Message-ID: <568EECEA.60702@oracle.com> David, I'll push this for you. -- Jon On 01/07/2016 12:18 PM, David DeHaven wrote: > I?ve been using this patch since December and it seems to be working well with both Mercurial 2.8 and 3.6.2. I don?t think I can push to code-tools so will need a Committer to push for me. > > webrev (and example): > http://cr.openjdk.java.net/~ddehaven/CODETOOLS-7901466/patched/ > > Also updated copyright year and version number. > > -DrD- > From jonathan.gibbons at oracle.com Wed Jan 20 19:43:24 2016 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 20 Jan 2016 11:43:24 -0800 Subject: RFR : CODETOOLS-7901582 - webrev -f creates bad next links when transitioning between trees In-Reply-To: References: Message-ID: <569FE35C.4070603@oracle.com> On 01/19/2016 07:47 AM, Jim Laskey (Oracle) wrote: > https://bugs.openjdk.java.net/browse/CODETOOLS-7901582 > http://cr.openjdk.java.net/~jlaskey/webrev/webrev/index.html Jim, Thanks for the fix. SInce the changeset itself looks clean/OK, I think it's OK to push it, despite the weirdness if the sdiff version of the webrev. I'll go ahead and push this on your behalf. -- Jon From james.laskey at oracle.com Tue Jan 19 15:47:24 2016 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Tue, 19 Jan 2016 15:47:24 -0000 Subject: RFR : CODETOOLS-7901582 - webrev -f creates bad next links when transitioning between trees Message-ID: https://bugs.openjdk.java.net/browse/CODETOOLS-7901582 http://cr.openjdk.java.net/~jlaskey/webrev/webrev/index.html From james.laskey at oracle.com Wed Jan 20 20:04:37 2016 From: james.laskey at oracle.com (James Laskey) Date: Wed, 20 Jan 2016 20:04:37 -0000 Subject: RFR : CODETOOLS-7901582 - webrev -f creates bad next links when transitioning between trees In-Reply-To: <569FE35C.4070603@oracle.com> References: <569FE35C.4070603@oracle.com> Message-ID: <667B1A98-8C41-436A-AF75-B8FD9F5D32E7@oracle.com> Thank you. Sent from my iPhone > On Jan 20, 2016, at 3:43 PM, Jonathan Gibbons wrote: > > > >> On 01/19/2016 07:47 AM, Jim Laskey (Oracle) wrote: >> https://bugs.openjdk.java.net/browse/CODETOOLS-7901582 >> http://cr.openjdk.java.net/~jlaskey/webrev/webrev/index.html > > Jim, > > Thanks for the fix. SInce the changeset itself looks clean/OK, I think it's OK to push > it, despite the weirdness if the sdiff version of the webrev. > > I'll go ahead and push this on your behalf. > > -- Jon