From volker.simonis at gmail.com  Wed Mar 30 10:27:53 2016
From: volker.simonis at gmail.com (Volker Simonis)
Date: Wed, 30 Mar 2016 12:27:53 +0200
Subject: RFR(XS): 7901508: JTreg with '-noshell' wrongly exectes shell
	tests with an implicit 'run shell' action
In-Reply-To: <CA+3eh11gS0Z9kVjuBJmu6BESTEin=G-dz42Mw8-ssTdyHH7LQw@mail.gmail.com>
References: <CA+3eh11gS0Z9kVjuBJmu6BESTEin=G-dz42Mw8-ssTdyHH7LQw@mail.gmail.com>
Message-ID: <CA+3eh10_fqF4mUov0g_43GFQZTvCrmbwRYhYbLfbTrj89yNnBg@mail.gmail.com>

PING!

Can somebody please have a look at this tiny fix?

Thanks,
Volker


On Wed, Sep 16, 2015 at 7:18 PM, Volker Simonis
<volker.simonis at gmail.com> wrote:
> Hi,
>
> could somebody please review and sponsor this small fix:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901508/
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901508
>
> The '-noshell' command line option should instruct JTreg to not
> execute tests which contain shell actions. Unfortunately this option
> is broken for shell tests which do not explicitly specify a run action
> with '@run shell ...'.
>
> Notice that specifying a run action is not necessary because the
> default for '.sh' files is '@run shell <filename>' anyway. There exist
> plenty of shell tests which do not specify the run action explicitly.
>
> The problem is that the pattern which checks for the run action
> wrongly assumes that the action can only be user-specified.
>
> Thank you and best regards,
> Volker

From jonathan.gibbons at oracle.com  Thu Mar 31 15:04:54 2016
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Thu, 31 Mar 2016 08:04:54 -0700
Subject: RFR(XS): 7901508: JTreg with '-noshell' wrongly exectes shell
	tests with an implicit 'run shell' action
In-Reply-To: <CA+3eh10_fqF4mUov0g_43GFQZTvCrmbwRYhYbLfbTrj89yNnBg@mail.gmail.com>
References: <CA+3eh11gS0Z9kVjuBJmu6BESTEin=G-dz42Mw8-ssTdyHH7LQw@mail.gmail.com>
	<CA+3eh10_fqF4mUov0g_43GFQZTvCrmbwRYhYbLfbTrj89yNnBg@mail.gmail.com>
Message-ID: <56FD3C96.5020607@oracle.com>

On 03/30/2016 03:27 AM, Volker Simonis wrote:
> PING!
>
> Can somebody please have a look at this tiny fix?
>
> Thanks,
> Volker
>
>
> On Wed, Sep 16, 2015 at 7:18 PM, Volker Simonis
> <volker.simonis at gmail.com> wrote:
>> Hi,
>>
>> could somebody please review and sponsor this small fix:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901508/
>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901508
>>
>> The '-noshell' command line option should instruct JTreg to not
>> execute tests which contain shell actions. Unfortunately this option
>> is broken for shell tests which do not explicitly specify a run action
>> with '@run shell ...'.
>>
>> Notice that specifying a run action is not necessary because the
>> default for '.sh' files is '@run shell <filename>' anyway. There exist
>> plenty of shell tests which do not specify the run action explicitly.
>>
>> The problem is that the pattern which checks for the run action
>> wrongly assumes that the action can only be user-specified.
>>
>> Thank you and best regards,
>> Volker

Volker,

My apologies, I missed this first time round.   I'll look at this for you.

-- Jon