From rachna.goel at oracle.com Mon Oct 3 10:10:59 2016 From: rachna.goel at oracle.com (Rachna Goel) Date: Mon, 3 Oct 2016 15:40:59 +0530 Subject: Regarding TestNG test case with @run tag. Message-ID: <0bec9f37-2e02-9da9-135e-4fdf3adc5eb8@oracle.com> Hi, I am working on a fix in which TestNG test case, is to be added at /test/java/time/test/java/time. I have to specify system property for this fix as : @run testng/othervm -Djava.locale.providers=JRE TestNarrowMonthNamesAndDayNames However, upon executing with jtreg this test gives me following error. "error=Explicit action tag not allowed" One obvious reason to me for this error is : There is TEST.properties file /test/java/time which has set " TestNG.dirs = . ". Having the TEST.properties set TestNG.dirs causes it to ignore or error if an individual test includes @run, so we can not have any testcase specifying jtreg action tags such as @run, @compile in current dir. To confirm cause, I added same test case to test/sun/util/resources/TimeZone which makes it pass successfully. please suggest on how to override default behavior of TEST.properties file /test/java/time. or is there any other way I could add this test to mentioned path. PFA test case for your kind reference. Thanks, Rachna -------------- next part -------------- /* * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */ /* * This file is available under and governed by the GNU General Public * License version 2 only, as published by the Free Software Foundation. * However, the following notice accompanied the original version of this * file: * * Copyright (c) 2008-2012 Stephen Colebourne & Michael Nascimento Santos * * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * * Redistributions of source code must retain the above copyright notice, * this list of conditions and the following disclaimer. * * * Redistributions in binary form must reproduce the above copyright notice, * this list of conditions and the following disclaimer in the documentation * and/or other materials provided with the distribution. * * * Neither the name of JSR-310 nor the names of its contributors * may be used to endorse or promote products derived from this software * without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ /** * @test * * @run testng/othervm -Djava.locale.providers=JRE TestNarrowMonthNamesAndDayNames * * * @summary Test Narrow and NarrowStandalone month names are retrieved correctly. * */ package test.java.time; import static org.testng.Assert.assertEquals; import java.time.DayOfWeek; import java.time.Month; import java.time.format.TextStyle; import java.util.Arrays; import java.util.HashMap; import java.util.List; import java.util.Locale; import java.util.Map; import org.testng.annotations.BeforeMethod; import org.testng.annotations.DataProvider; import org.testng.annotations.Test; public class TestNarrowMonthNamesAndDayNames { private static final Map DAYNARROWS_EXPECTED = new HashMap<>(); private static final List MONTHVALUES = Arrays.asList(Month.values()); private static final List DAYVALUES = Arrays.asList(DayOfWeek.values()); private static final List TEXTSTYLELIST = Arrays.asList(TextStyle.valueOf("NARROW"), TextStyle.valueOf("NARROW_STANDALONE")); private static final List LOCARR = Arrays.asList(new Locale("en", "US"), new Locale("de", "DE"), new Locale("fr", "FR"), new Locale("no", "NO")); @BeforeMethod public void setUp() { DAYNARROWS_EXPECTED.put("en_US", new String[]{"M", "T", "W", "T", "F", "S", "S"}); DAYNARROWS_EXPECTED.put("de_DE", new String[]{"M", "D", "M", "D", "F", "S", "S"}); DAYNARROWS_EXPECTED.put("fr_FR", new String[]{"L", "M", "M", "J", "V", "S", "D"}); DAYNARROWS_EXPECTED.put("no_NO", new String[]{"M", "T", "O", "T", "F", "L", "S"}); } /** * Locale en_US, de_DE, fr_FR, no_NO will have same Narrow and Narrow_Standalone * month Names for COMPAT Provider. */ @DataProvider(name = "MonthNarrows") public Object[][] createData() { return new Object[][]{{new String[]{ "J", "F", "M", "A", "M", "J", "J", "A", "S", "O", "N", "D" }},}; } //----------------------------------------------------------------------- // Check Narrow and Narrow_standalone month name values //----------------------------------------------------------------------- @Test(dataProvider = "MonthNarrows") public void compareMonthNarrowValues(String[] narrowArray) { LOCARR.forEach((loc) -> { TEXTSTYLELIST.forEach((style) -> { MONTHVALUES.forEach((value) -> { String result = value.getDisplayName(style, loc); int index = MONTHVALUES.indexOf(value); assertEquals(result, narrowArray[index]); }); }); }); } //----------------------------------------------------------------------- // Check Narrow and Narrow_standalone Day name values //----------------------------------------------------------------------- @Test public void compareDayNarrowValues() { LOCARR.forEach((loc) -> { TEXTSTYLELIST.forEach((style) -> { DAYVALUES.forEach((value) -> { String result = value.getDisplayName(style, loc); String[] DayNarrowExpected = DAYNARROWS_EXPECTED.get(loc.toString()); int index = DAYVALUES.indexOf(value); assertEquals(result, DayNarrowExpected[index]); }); }); }); } } From jonathan.gibbons at oracle.com Mon Oct 3 16:55:46 2016 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 03 Oct 2016 09:55:46 -0700 Subject: Regarding TestNG test case with @run tag. In-Reply-To: <0bec9f37-2e02-9da9-135e-4fdf3adc5eb8@oracle.com> References: <0bec9f37-2e02-9da9-135e-4fdf3adc5eb8@oracle.com> Message-ID: <57F28D92.7010304@oracle.com> On 10/03/2016 03:10 AM, Rachna Goel wrote: > Hi, > > I am working on a fix in which TestNG test case, is to be added at > /test/java/time/test/java/time. > > I have to specify system property for this fix as : > > @run testng/othervm -Djava.locale.providers=JRE > TestNarrowMonthNamesAndDayNames > > However, upon executing with jtreg this test gives me following error. > > "error=Explicit action tag not allowed" > > One obvious reason to me for this error is : > > There is TEST.properties file /test/java/time which has set " > TestNG.dirs = . ". Having the TEST.properties set TestNG.dirs causes > it to ignore or error if an individual test includes @run, so we can > not have any testcase specifying jtreg action tags such as @run, > @compile in current dir. Yes, this is the specified behavior. > > To confirm cause, I added same test case to > test/sun/util/resources/TimeZone which makes it pass successfully. > > please suggest on how to override default behavior of TEST.properties > file /test/java/time. > or is there any other way I could add this test to mentioned path. > PFA test case for your kind reference. You cannot override the behavior within a directory specified by TestNG.dirs. To give a test specific properties, you need to place it outside any such directory. > > Thanks, > Rachna > > > From goetz.lindenmaier at sap.com Thu Oct 27 10:37:03 2016 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 27 Oct 2016 10:37:03 +0000 Subject: ping: RE: RFR(S): 7901696: jtreg must set LIBPATH on aix/os400 Message-ID: <8ab7e9010a744f9a82cd60815c946613@derote13de14.global.corp.sap> Hi, could someone please have a look at this change? Thanks, Goetz > -----Original Message----- > From: Lindenmaier, Goetz > Sent: Dienstag, 6. September 2016 11:15 > To: code-tools-dev at openjdk.java.net > Subject: RFR(S): 7901696: jtreg must set LIBPATH on aix/os400 > > Hi > > > > Jtreg sets LD_LIBRARY_PATH on aix and os400, where it must use > > LIBPATH. > > > > Please review this change. I please need a sponsor (or can I push myself?) > > http://cr.openjdk.java.net/~goetz/wr16/7901696-jtreg_LIBPATH/webrev.01/ > > > > Best regards, > > Goetz. From jonathan.gibbons at oracle.com Thu Oct 27 15:57:16 2016 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 27 Oct 2016 08:57:16 -0700 Subject: ping: RE: RFR(S): 7901696: jtreg must set LIBPATH on aix/os400 In-Reply-To: <8ab7e9010a744f9a82cd60815c946613@derote13de14.global.corp.sap> References: <8ab7e9010a744f9a82cd60815c946613@derote13de14.global.corp.sap> Message-ID: <8a19367a-7e26-c13d-f8ee-c0ce1cddadf4@oracle.com> Goetz, Sorry for the delay. The patch looks OK, but the jtreg classes have been shuffled since you created the patch. I can sponsor the change for you and take the shuffle into account, or you can submit a new webrev/patch, your choice. -- Jon On 10/27/16 3:37 AM, Lindenmaier, Goetz wrote: > Hi, > > could someone please have a look at this change? > > Thanks, > Goetz > >> -----Original Message----- >> From: Lindenmaier, Goetz >> Sent: Dienstag, 6. September 2016 11:15 >> To: code-tools-dev at openjdk.java.net >> Subject: RFR(S): 7901696: jtreg must set LIBPATH on aix/os400 >> >> Hi >> >> >> >> Jtreg sets LD_LIBRARY_PATH on aix and os400, where it must use >> >> LIBPATH. >> >> >> >> Please review this change. I please need a sponsor (or can I push myself?) >> >> http://cr.openjdk.java.net/~goetz/wr16/7901696-jtreg_LIBPATH/webrev.01/ >> >> >> >> Best regards, >> >> Goetz. From jonathan.gibbons at oracle.com Thu Oct 27 21:23:46 2016 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 27 Oct 2016 14:23:46 -0700 Subject: ping: RE: RFR(S): 7901780: jtreg must set LIBPATH on aix/os400 In-Reply-To: <8a19367a-7e26-c13d-f8ee-c0ce1cddadf4@oracle.com> References: <8ab7e9010a744f9a82cd60815c946613@derote13de14.global.corp.sap> <8a19367a-7e26-c13d-f8ee-c0ce1cddadf4@oracle.com> Message-ID: <58127062.8080607@oracle.com> Goetz, It was easy enough to edit the filenames in the patch, to account for the recent jtreg package reorg, without otherwise changing the content of the patch. I have therefore sponsored the patch on your behalf and pushed the change. One other bureaucratic change was necessary. This mail thread, and the changeset comment, was incorrectly using the wrong issue number. Not surprisingly, it turned out to be the issue for an earlier contribution of yours. Luckily, jcheck caught the mistake, and the summary in the mail subject line and the changeset comment was enough to identify the correct number to use. For the record: 7901696: os.simpleArch is x64 for linux-ppc64le in @require context 7901780: jtreg must set LIBPATH on aix/os400 -- Jon On 10/27/2016 08:57 AM, Jonathan Gibbons wrote: > Goetz, > > Sorry for the delay. The patch looks OK, but the jtreg classes have > been shuffled since you created the patch. I can sponsor the change > for you and take the shuffle into account, or you can submit a new > webrev/patch, your choice. > > -- Jon > > > On 10/27/16 3:37 AM, Lindenmaier, Goetz wrote: >> Hi, >> >> could someone please have a look at this change? >> >> Thanks, >> Goetz >> >>> -----Original Message----- >>> From: Lindenmaier, Goetz >>> Sent: Dienstag, 6. September 2016 11:15 >>> To: code-tools-dev at openjdk.java.net >>> Subject: RFR(S): 7901696: jtreg must set LIBPATH on aix/os400 >>> >>> Hi >>> >>> >>> >>> Jtreg sets LD_LIBRARY_PATH on aix and os400, where it must use >>> >>> LIBPATH. >>> >>> >>> >>> Please review this change. I please need a sponsor (or can I push >>> myself?) >>> >>> http://cr.openjdk.java.net/~goetz/wr16/7901696-jtreg_LIBPATH/webrev.01/ >>> >>> >>> >>> Best regards, >>> >>> Goetz. > From goetz.lindenmaier at sap.com Fri Oct 28 06:36:43 2016 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 28 Oct 2016 06:36:43 +0000 Subject: ping: RE: RFR(S): 7901780: jtreg must set LIBPATH on aix/os400 In-Reply-To: <58127062.8080607@oracle.com> References: <8ab7e9010a744f9a82cd60815c946613@derote13de14.global.corp.sap> <8a19367a-7e26-c13d-f8ee-c0ce1cddadf4@oracle.com> <58127062.8080607@oracle.com> Message-ID: Hi Jon, thanks for sponsoring, the change! Yes, I actually messed up the bug-ids. Sorry I wasn't fast enough to do these fixes myself, but I'm on CEST schedule. Best regards, Goetz. > -----Original Message----- > From: code-tools-dev [mailto:code-tools-dev-bounces at openjdk.java.net] > On Behalf Of Jonathan Gibbons > Sent: Donnerstag, 27. Oktober 2016 23:24 > To: code-tools-dev at openjdk.java.net > Subject: Re: ping: RE: RFR(S): 7901780: jtreg must set LIBPATH on aix/os400 > > Goetz, > > It was easy enough to edit the filenames in the patch, to account for > the recent jtreg package reorg, without otherwise changing the content > of the patch. I have therefore sponsored the patch on your behalf and > pushed the change. > > One other bureaucratic change was necessary. This mail thread, and the > changeset comment, was incorrectly using the wrong issue number. Not > surprisingly, it turned out to be the issue for an earlier contribution > of yours. Luckily, jcheck caught the mistake, and the summary in the > mail subject line and the changeset comment was enough to identify the > correct number to use. > > For the record: > > 7901696: os.simpleArch is x64 for linux-ppc64le in @require context > 7901780: jtreg must set LIBPATH on aix/os400 > > -- Jon > > On 10/27/2016 08:57 AM, Jonathan Gibbons wrote: > > Goetz, > > > > Sorry for the delay. The patch looks OK, but the jtreg classes have > > been shuffled since you created the patch. I can sponsor the change > > for you and take the shuffle into account, or you can submit a new > > webrev/patch, your choice. > > > > -- Jon > > > > > > On 10/27/16 3:37 AM, Lindenmaier, Goetz wrote: > >> Hi, > >> > >> could someone please have a look at this change? > >> > >> Thanks, > >> Goetz > >> > >>> -----Original Message----- > >>> From: Lindenmaier, Goetz > >>> Sent: Dienstag, 6. September 2016 11:15 > >>> To: code-tools-dev at openjdk.java.net > >>> Subject: RFR(S): 7901696: jtreg must set LIBPATH on aix/os400 > >>> > >>> Hi > >>> > >>> > >>> > >>> Jtreg sets LD_LIBRARY_PATH on aix and os400, where it must use > >>> > >>> LIBPATH. > >>> > >>> > >>> > >>> Please review this change. I please need a sponsor (or can I push > >>> myself?) > >>> > >>> http://cr.openjdk.java.net/~goetz/wr16/7901696- > jtreg_LIBPATH/webrev.01/ > >>> > >>> > >>> > >>> Best regards, > >>> > >>> Goetz. > >