From jonathan.gibbons at oracle.com Mon Aug 21 22:03:13 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 21 Aug 2017 15:03:13 -0700 Subject: RFR: CODETOOLS-7901950: jcheck does not work with Mercurial 4.1 In-Reply-To: References: Message-ID: <599B58A1.8010002@oracle.com> jcheck and defpath updates pushed. -- Jon On 05/17/2017 03:24 AM, Magnus Ihse Bursie wrote: > Looks good to me. > > Can someone with write access please push these changes? > > /Magnus > > On 2017-04-18 19:35, Erik Joelsson wrote: >> The way a Mercurial plugin interacts with Mercurial has changed over >> time. The technique used in jcheck and defpath has been deprecated >> for a while and in 4.1, it no longer works. >> >> I have a patch that adopts the new method using decorators, >> introduced in Mercurial 1.9. It also contains a fallback workaround >> that keeps compatibility with older versions. >> >> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901950 >> >> Webrev: >> http://cr.openjdk.java.net/~erikj/CODETOOLS-7901950/jcheck-webrev.01/ >> >> >> I have the same changes ready for defpath which doesn't have it's own >> component in Jira. >> >> Webrev: >> http://cr.openjdk.java.net/~erikj/CODETOOLS-7901950/defpath-webrev.01/ >> >> /Erik >> > From eric.caspole at oracle.com Thu Aug 24 21:01:10 2017 From: eric.caspole at oracle.com (Eric Caspole) Date: Thu, 24 Aug 2017 17:01:10 -0400 Subject: CodeTools proposal: "jdk-microbenchmarks" Message-ID: <62edfd17-87a0-d095-d33b-78a470ba5a73@oracle.com> Name: jdk-microbenchmarks Summary: A collection of JMH [0] based microbenchmarks focused on the JDK APIs and JVM functionality. Proposed by: Eric Caspole Rationale: There is not yet any similar collection of JMH benchmarks in OpenJDK, and we have a collection of >200 microbenchmarks covering some of the JDK API that we could place into OpenJDK from earlier closed jdk work. We have seen that JDK developers create useful JMH based micros in the course of their work, but since there is no well known place to save and reuse them, they are forgotten or discarded after a bug is fixed etc, but these micros could be reused for regression testing. This collection of microbenchmarks is intended to remain focused on JDK APIs and JVM features primarily for the current release and the upcoming release in development. At some future time this collection may be used in release performance/regression testing. We would like to place this as a OpenJDK/codetools sub-project. [0] - http://openjdk.java.net/projects/code-tools/jmh/ From jonathan.gibbons at oracle.com Thu Aug 24 21:09:07 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 24 Aug 2017 14:09:07 -0700 Subject: CodeTools proposal: "jdk-microbenchmarks" In-Reply-To: <62edfd17-87a0-d095-d33b-78a470ba5a73@oracle.com> References: <62edfd17-87a0-d095-d33b-78a470ba5a73@oracle.com> Message-ID: <599F4073.6090103@oracle.com> Eric, This seems like a good addition to the Code Tools world. -- Jon On 08/24/2017 02:01 PM, Eric Caspole wrote: > > Name: jdk-microbenchmarks > > Summary: A collection of JMH [0] based microbenchmarks focused on the > JDK APIs and JVM functionality. > > Proposed by: Eric Caspole > > Rationale: > > There is not yet any similar collection of JMH benchmarks in OpenJDK, > and we have a collection of >200 microbenchmarks covering some of the > JDK API that we could place into OpenJDK from earlier closed jdk work. > > We have seen that JDK developers create useful JMH based micros in the > course of their work, but since there is no well known place to save > and reuse them, they are forgotten or discarded after a bug is fixed > etc, but these micros could be reused for regression testing. > > This collection of microbenchmarks is intended to remain focused on > JDK APIs and JVM features primarily for the current release and the > upcoming release in development. At some future time this collection > may be used in release performance/regression testing. > > We would like to place this as a OpenJDK/codetools sub-project. > > > [0] - http://openjdk.java.net/projects/code-tools/jmh/ From martijnverburg at gmail.com Fri Aug 25 09:00:54 2017 From: martijnverburg at gmail.com (Martijn Verburg) Date: Fri, 25 Aug 2017 10:00:54 +0100 Subject: CodeTools proposal: "jdk-microbenchmarks" In-Reply-To: <599F4073.6090103@oracle.com> References: <62edfd17-87a0-d095-d33b-78a470ba5a73@oracle.com> <599F4073.6090103@oracle.com> Message-ID: +1 - Great idea - it will allow a central place for peer reviewed benchmarks. Cheers, Martijn On 24 August 2017 at 22:09, Jonathan Gibbons wrote: > Eric, > > This seems like a good addition to the Code Tools world. > > -- Jon > > > On 08/24/2017 02:01 PM, Eric Caspole wrote: > >> >> Name: jdk-microbenchmarks >> >> Summary: A collection of JMH [0] based microbenchmarks focused on the JDK >> APIs and JVM functionality. >> >> Proposed by: Eric Caspole >> >> Rationale: >> >> There is not yet any similar collection of JMH benchmarks in OpenJDK, and >> we have a collection of >200 microbenchmarks covering some of the JDK API >> that we could place into OpenJDK from earlier closed jdk work. >> >> We have seen that JDK developers create useful JMH based micros in the >> course of their work, but since there is no well known place to save and >> reuse them, they are forgotten or discarded after a bug is fixed etc, but >> these micros could be reused for regression testing. >> >> This collection of microbenchmarks is intended to remain focused on JDK >> APIs and JVM features primarily for the current release and the upcoming >> release in development. At some future time this collection may be used in >> release performance/regression testing. >> >> We would like to place this as a OpenJDK/codetools sub-project. >> >> >> [0] - http://openjdk.java.net/projects/code-tools/jmh/ >> > > From stuart.monteith at linaro.org Tue Aug 29 08:57:57 2017 From: stuart.monteith at linaro.org (Stuart Monteith) Date: Tue, 29 Aug 2017 09:57:57 +0100 Subject: CodeTools proposal: "jdk-microbenchmarks" In-Reply-To: References: <62edfd17-87a0-d095-d33b-78a470ba5a73@oracle.com> <599F4073.6090103@oracle.com> Message-ID: Hi, Is this work that would be done under JEP-230? http://openjdk.java.net/jeps/230 BR, Stuart On 25 August 2017 at 10:00, Martijn Verburg wrote: > +1 - Great idea - it will allow a central place for peer reviewed > benchmarks. > > Cheers, > Martijn > > On 24 August 2017 at 22:09, Jonathan Gibbons > wrote: > >> Eric, >> >> This seems like a good addition to the Code Tools world. >> >> -- Jon >> >> >> On 08/24/2017 02:01 PM, Eric Caspole wrote: >> >>> >>> Name: jdk-microbenchmarks >>> >>> Summary: A collection of JMH [0] based microbenchmarks focused on the JDK >>> APIs and JVM functionality. >>> >>> Proposed by: Eric Caspole >>> >>> Rationale: >>> >>> There is not yet any similar collection of JMH benchmarks in OpenJDK, and >>> we have a collection of >200 microbenchmarks covering some of the JDK API >>> that we could place into OpenJDK from earlier closed jdk work. >>> >>> We have seen that JDK developers create useful JMH based micros in the >>> course of their work, but since there is no well known place to save and >>> reuse them, they are forgotten or discarded after a bug is fixed etc, but >>> these micros could be reused for regression testing. >>> >>> This collection of microbenchmarks is intended to remain focused on JDK >>> APIs and JVM features primarily for the current release and the upcoming >>> release in development. At some future time this collection may be used in >>> release performance/regression testing. >>> >>> We would like to place this as a OpenJDK/codetools sub-project. >>> >>> >>> [0] - http://openjdk.java.net/projects/code-tools/jmh/ >>> >> >> From eric.caspole at oracle.com Tue Aug 29 14:02:28 2017 From: eric.caspole at oracle.com (Eric Caspole) Date: Tue, 29 Aug 2017 10:02:28 -0400 Subject: CodeTools proposal: "jdk-microbenchmarks" In-Reply-To: References: <62edfd17-87a0-d095-d33b-78a470ba5a73@oracle.com> <599F4073.6090103@oracle.com> Message-ID: Hi Stuart, We deliberately moved JEP-230 back to candidate out of 9 due to resource constraints and that situation will continue. In order to make the benchmarks available and useful in OpenJDK, placing them in code-tools is the best solution for the time being. Maybe in the future JEP-230 can be worked on more actively where the benchmarks can be in the jdk source tree. Regards, Eric On 08/29/2017 04:57 AM, Stuart Monteith wrote: > Hi, > Is this work that would be done under JEP-230? > http://openjdk.java.net/jeps/230 > > BR, > Stuart > > > > On 25 August 2017 at 10:00, Martijn Verburg wrote: >> +1 - Great idea - it will allow a central place for peer reviewed >> benchmarks. >> >> Cheers, >> Martijn >> >> On 24 August 2017 at 22:09, Jonathan Gibbons >> wrote: >> >>> Eric, >>> >>> This seems like a good addition to the Code Tools world. >>> >>> -- Jon >>> >>> >>> On 08/24/2017 02:01 PM, Eric Caspole wrote: >>> >>>> >>>> Name: jdk-microbenchmarks >>>> >>>> Summary: A collection of JMH [0] based microbenchmarks focused on the JDK >>>> APIs and JVM functionality. >>>> >>>> Proposed by: Eric Caspole >>>> >>>> Rationale: >>>> >>>> There is not yet any similar collection of JMH benchmarks in OpenJDK, and >>>> we have a collection of >200 microbenchmarks covering some of the JDK API >>>> that we could place into OpenJDK from earlier closed jdk work. >>>> >>>> We have seen that JDK developers create useful JMH based micros in the >>>> course of their work, but since there is no well known place to save and >>>> reuse them, they are forgotten or discarded after a bug is fixed etc, but >>>> these micros could be reused for regression testing. >>>> >>>> This collection of microbenchmarks is intended to remain focused on JDK >>>> APIs and JVM features primarily for the current release and the upcoming >>>> release in development. At some future time this collection may be used in >>>> release performance/regression testing. >>>> >>>> We would like to place this as a OpenJDK/codetools sub-project. >>>> >>>> >>>> [0] - http://openjdk.java.net/projects/code-tools/jmh/ >>>> >>> >>>