From erik.joelsson at oracle.com Fri Jun 1 21:04:05 2018 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 1 Jun 2018 14:04:05 -0700 Subject: RFR: CODETOOLS-7902177: Make trees work with Mercurial 4.2 - 4.6 Message-ID: Hello, I recently installed Ubuntu 18.04 which comes with HG 4.5.3 and discovered there were issues with the trees extension again. The problems start with version 4.2 and up. Here is a patch that makes it work for all versions 1.1 to 4.6, tested with the internal test suite. There are multiple API changes that needed to be worked around, but nothing here should be too controversial and I've added comments explaining the less obvious cases. I also had to update the URL to the official Mercurial repo which is used as the source for testing against all Mercurial versions, as well as update the tests to be compatible with the latest version of the Mercurial test runner and new output from some mercurial commands. There is also a test internal extension "verlist" that wasn't compatible with the 4.5.3 system mercurial on my new system. Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902177 Webrev: http://cr.openjdk.java.net/~erikj/CODETOOLS-7902177/webrev.01/ /Erik From martinrb at google.com Fri Jun 1 21:26:51 2018 From: martinrb at google.com (Martin Buchholz) Date: Fri, 1 Jun 2018 14:26:51 -0700 Subject: RFR: CODETOOLS-7902177: Make trees work with Mercurial 4.2 - 4.6 In-Reply-To: References: Message-ID: Hej Erik, Thanks for fixing but ... Are you aware of the thread on hg-tools-dev https://openjdk.markmail.org/thread/hla7tbyg6sg2kgqg Maybe you could append to that thread instead? On Fri, Jun 1, 2018 at 2:04 PM, Erik Joelsson wrote: > Hello, > > I recently installed Ubuntu 18.04 which comes with HG 4.5.3 and discovered > there were issues with the trees extension again. The problems start with > version 4.2 and up. Here is a patch that makes it work for all versions 1.1 > to 4.6, tested with the internal test suite. > > There are multiple API changes that needed to be worked around, but > nothing here should be too controversial and I've added comments explaining > the less obvious cases. I also had to update the URL to the official > Mercurial repo which is used as the source for testing against all > Mercurial versions, as well as update the tests to be compatible with the > latest version of the Mercurial test runner and new output from some > mercurial commands. There is also a test internal extension "verlist" that > wasn't compatible with the 4.5.3 system mercurial on my new system. > > Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902177 > > Webrev: http://cr.openjdk.java.net/~erikj/CODETOOLS-7902177/webrev.01/ > > /Erik > > From erik.joelsson at oracle.com Fri Jun 1 21:49:51 2018 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 1 Jun 2018 14:49:51 -0700 Subject: RFR: CODETOOLS-7902177: Make trees work with Mercurial 4.2 - 4.6 In-Reply-To: References: Message-ID: <958a08a9-fa36-ad59-225c-80af2b664a70@oracle.com> Oh, I was not aware of that mailing list, I just checked here. Mark's version looks like it has more effort put into it. If that gets pushed I can add the missing bits for 4.6. /Erik On 2018-06-01 14:26, Martin Buchholz wrote: > Hej Erik, > > Thanks for fixing but ... > Are you aware of the thread on hg-tools-dev > https://openjdk.markmail.org/thread/hla7tbyg6sg2kgqg > Maybe you could append to that thread instead? > > > On Fri, Jun 1, 2018 at 2:04 PM, Erik Joelsson > > wrote: > > Hello, > > I recently installed Ubuntu 18.04 which comes with HG 4.5.3 and > discovered there were issues with the trees extension again. The > problems start with version 4.2 and up. Here is a patch that makes > it work for all versions 1.1 to 4.6, tested with the internal test > suite. > > There are multiple API changes that needed to be worked around, > but nothing here should be too controversial and I've added > comments explaining the less obvious cases. I also had to update > the URL to the official Mercurial repo which is used as the source > for testing against all Mercurial versions, as well as update the > tests to be compatible with the latest version of the Mercurial > test runner and new output from some mercurial commands. There is > also a test internal extension "verlist" that wasn't compatible > with the 4.5.3 system mercurial on my new system. > > Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902177 > > > Webrev: > http://cr.openjdk.java.net/~erikj/CODETOOLS-7902177/webrev.01/ > > > /Erik > > From mark.reinhold at oracle.com Fri Jun 1 21:57:34 2018 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 01 Jun 2018 14:57:34 -0700 Subject: RFR: CODETOOLS-7902177: Make trees work with Mercurial 4.2 - 4.6 In-Reply-To: <958a08a9-fa36-ad59-225c-80af2b664a70@oracle.com> References: <958a08a9-fa36-ad59-225c-80af2b664a70@oracle.com> Message-ID: <20180601145734.491831136@eggemoggin.niobe.net> 2018/6/1 14:49:51 -0700, erik.joelsson at oracle.com: > Oh, I was not aware of that mailing list, I just checked here. Mark's > version looks like it has more effort put into it. If that gets pushed I > can add the missing bits for 4.6. Thanks for the reminder. I?ll push it shortly. - Mark From jonathan.gibbons at oracle.com Mon Jun 4 20:51:50 2018 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 04 Jun 2018 13:51:50 -0700 Subject: CFV: New Code Tools Committer: Erik Joelsson Message-ID: <5B15A666.8060502@oracle.com> |I hereby nominate Erik Joelsson to Code Tools Committer. Although Erik is not a frequent contributor to the Code Tools project, he has contributed to the smaller repos containing Mercurial tools such as defpath, jcheck and trees, as well as webrev, and he has considerable experience as a Committer and Reviewer in his work as a member of the build team. Votes are due by 2pm PDT, June 18. Only current Code Tools Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Jonathan Gibbons [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote| From goetz.lindenmaier at sap.com Tue Jun 5 06:18:09 2018 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 5 Jun 2018 06:18:09 +0000 Subject: New Code Tools Committer: Erik Joelsson In-Reply-To: <5B15A666.8060502@oracle.com> References: <5B15A666.8060502@oracle.com> Message-ID: <02679df76dba4dbba776432632ccae05@sap.com> vote: yes Best, Goetz. > -----Original Message----- > From: code-tools-dev [mailto:code-tools-dev-bounces at openjdk.java.net] > On Behalf Of Jonathan Gibbons > Sent: Montag, 4. Juni 2018 22:52 > To: code-tools-dev ; Erik Joelsson > > Subject: CFV: New Code Tools Committer: Erik Joelsson > > |I hereby nominate Erik Joelsson to Code Tools Committer. > > Although Erik is not a frequent contributor to the Code Tools project, > he has contributed to the smaller repos containing Mercurial tools > such as defpath, jcheck and trees, as well as webrev, and he has > considerable experience as a Committer and Reviewer in his work as > a member of the build team. > > Votes are due by 2pm PDT, June 18. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Jonathan Gibbons > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote| From iris.clark at oracle.com Tue Jun 5 15:45:39 2018 From: iris.clark at oracle.com (Iris Clark) Date: Tue, 5 Jun 2018 08:45:39 -0700 (PDT) Subject: CFV: New Code Tools Committer: Erik Joelsson In-Reply-To: <5B15A666.8060502@oracle.com> References: <5B15A666.8060502@oracle.com> Message-ID: Vote: yes Iris From jonathan.gibbons at oracle.com Tue Jun 5 15:50:57 2018 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 5 Jun 2018 08:50:57 -0700 Subject: CFV: New Code Tools Committer: Erik Joelsson In-Reply-To: <5B15A666.8060502@oracle.com> References: <5B15A666.8060502@oracle.com> Message-ID: <353f9cbf-7ade-5b17-d10e-1e71e1308f77@oracle.com> Vote: yes On 6/4/18 1:51 PM, Jonathan Gibbons wrote: > |I hereby nominate Erik Joelsson to Code Tools Committer. > > Although Erik is not a frequent contributor to the Code Tools project, > he has contributed to the smaller repos containing Mercurial tools > such as defpath, jcheck and trees, as well as webrev, and he has > considerable experience as a Committer and Reviewer in his work as > a member of the build team. > > Votes are due by 2pm PDT, June 18. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Jonathan Gibbons > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote| > From jonathan.gibbons at oracle.com Mon Jun 25 18:46:23 2018 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 25 Jun 2018 11:46:23 -0700 Subject: Result: New Code Tools Committer: Erik Joelsson In-Reply-To: <5B15A666.8060502@oracle.com> References: <5B15A666.8060502@oracle.com> Message-ID: Voting for Erik Joelsson [1] is now closed. Yes: 2 Veto: 0 Abstain: 0 There was 1 invalid vote. According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Jonathan Gibbons [1] http://mail.openjdk.java.net/pipermail/code-tools-dev/2018-June/000405.html On 6/4/18 1:51 PM, Jonathan Gibbons wrote: > |I hereby nominate Erik Joelsson to Code Tools Committer. > > Although Erik is not a frequent contributor to the Code Tools project, > he has contributed to the smaller repos containing Mercurial tools > such as defpath, jcheck and trees, as well as webrev, and he has > considerable experience as a Committer and Reviewer in his work as > a member of the build team. > > Votes are due by 2pm PDT, June 18. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Jonathan Gibbons > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote| >