RFR: CODETOOLS-7902177: Make trees work with Mercurial 4.2 - 4.6

Erik Joelsson erik.joelsson at oracle.com
Fri Jun 1 21:49:51 UTC 2018

Oh, I was not aware of that mailing list, I just checked here. Mark's 
version looks like it has more effort put into it. If that gets pushed I 
can add the missing bits for 4.6.


On 2018-06-01 14:26, Martin Buchholz wrote:
> Hej Erik,
> Thanks for fixing but ...
> Are you aware of the thread on hg-tools-dev
> https://openjdk.markmail.org/thread/hla7tbyg6sg2kgqg
> Maybe you could append to that thread instead?
> On Fri, Jun 1, 2018 at 2:04 PM, Erik Joelsson 
> <erik.joelsson at oracle.com <mailto:erik.joelsson at oracle.com>> wrote:
>     Hello,
>     I recently installed Ubuntu 18.04 which comes with HG 4.5.3 and
>     discovered there were issues with the trees extension again. The
>     problems start with version 4.2 and up. Here is a patch that makes
>     it work for all versions 1.1 to 4.6, tested with the internal test
>     suite.
>     There are multiple API changes that needed to be worked around,
>     but nothing here should be too controversial and I've added
>     comments explaining the less obvious cases. I also had to update
>     the URL to the official Mercurial repo which is used as the source
>     for testing against all Mercurial versions, as well as update the
>     tests to be compatible with the latest version of the Mercurial
>     test runner and new output from some mercurial commands. There is
>     also a test internal extension "verlist" that wasn't compatible
>     with the 4.5.3 system mercurial on my new system.
>     Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902177
>     <https://bugs.openjdk.java.net/browse/CODETOOLS-7902177>
>     Webrev:
>     http://cr.openjdk.java.net/~erikj/CODETOOLS-7902177/webrev.01/
>     <http://cr.openjdk.java.net/%7Eerikj/CODETOOLS-7902177/webrev.01/>
>     /Erik

More information about the code-tools-dev mailing list