RFR for CODETOOLS-7902293 and 7902317 jcheck extension broken in recent builds of hg

[Magnus Ihse Bursie]

On 2018-09-20 06:47, Tim Bell wrote:
> Hello
>
> Two changes in recent builds of hg broke jcheck:
>
> 1) CODETOOLS-7902292: util.Abort() was moved/copied from util to error 
> in hg 1.3 and was removed from util in 4.6.  This is the same fix used 
> on trees.py back in July [1].
>
> 2) CODETOOLS-7902317: date-related utils moved from util to 
> utils/dateutil in early 2018 (hg 4.7).
>
> http://cr.openjdk.java.net/~tbell/CODETOOLS-7902293-7902317/webrev/

Basically looks good. (But I'm still not a formal Reviewer :-())

However, I'm thinking that -- in line with the name error_Abort for 
error.Abort -- maybe an even better name than datestr_F would be 
dateutil_datestr? The "_F" part (for function?) looks a bit odd.

/Magnus

>
> Tested with hg versions 0.9.5, 2.9, 3.2.3, 4.7
>
> Thanks in advance.  I will also need a sponsor to push the change for me.
>
> Tim
>
> [1] Ref lines 140 ... 146: 
> http://hg.openjdk.java.net/code-tools/trees/comparison/592eba45b774/trees.py 
>