JMH JDK Microbenchmarks refer to Oracle internal infras?

[xiaofeng Young]

Hi Eric,
     works well, thank you very much!

Felix Yang
________________________________
From: eric.caspole at oracle.com <eric.caspole at oracle.com>
Sent: Thursday, April 11, 2019 6:32
To: xiaofeng Young; code-tools-dev at openjdk.java.net
Subject: Re: JMH JDK Microbenchmarks refer to Oracle internal infras?


Hi Felix,

I fixed this here:

http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/rev/d0fab231915f


I moved the test needing the in memory compiler to the JDK 11 dir where it probably should have been in the first place. So now it builds with 8, 11, 12 etc.

Give it a try.

Thanks for finding these problems!

Eric


On 4/10/19 6:14 AM, xiaofeng Young wrote:
Hi Eric,
     thanks for the quick update. After remove the repo, it exposes another issue to fail with  jdk 8. micros-util/src/main/java/org/openjdk/bench/util/InMemoryJavaCompiler.java refers a constant PATCH_MODULE_PATH, overrides methods of getLocationForModule() and inferModuleName()  , which are all since jdk 9.

Not sure if these are necessary. I removed them and the tests run well.  See the patch below:

 http://cr.openjdk.java.net/~xiaofeya/code-tools/webrev.00/<http://cr.openjdk.java.net/%7Exiaofeya/code-tools/webrev.00/>

Thanks,
Felix Yang
________________________________
From: code-tools-dev <code-tools-dev-bounces at openjdk.java.net><mailto:code-tools-dev-bounces at openjdk.java.net> on behalf of Eric Caspole <eric.caspole at oracle.com><mailto:eric.caspole at oracle.com>
Sent: Monday, April 8, 2019 22:41
To: code-tools-dev at openjdk.java.net<mailto:code-tools-dev at openjdk.java.net>
Subject: Re: JMH JDK Microbenchmarks refer to Oracle internal infras?

Hi Felix,
Thanks for pointing this out, that repo is not used in the build and I
will fix the pom in the repo later today.

In the mean time you can remove it:

$ hg diff
diff -r a644f3612e8d pom.xml
--- a/pom.xml   Tue Mar 26 15:56:51 2019 -0400
+++ b/pom.xml   Mon Apr 08 10:38:29 2019 -0400
@@ -291,13 +291,6 @@
          </dependency>
      </dependencies>

-    <repositories>
-        <repository>
-            <id>Stockholm Repository</id>
-
<url>http://maven.se.oracle.com/nexus/content/groups/public</url>
-        </repository>
-    </repositories>
-

Regards,
Eric


On 4/8/19 05:52, xiaofeng Young wrote:
> Hi,
>     not sure if this alias is suitable. I'm trying to build and run JDK micro-benchmarks with following guides
> Wiki: http://openjdk.java.net/projects/code-tools/jmh-jdk-microbenchmarks/
> Repo: http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/README.md
>
> After cloning the repo, a simple build with "mvn clean install" fails. It refers an oracle infra, http://maven.se.oracle.com/nexus/content/groups/public.
> http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml
>
>      <repositories><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l294><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l294>
>          <repository><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l295><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l295>
>              <id>Stockholm Repository</id><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l296><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l296>
>              <url>http://maven.se.oracle.com/nexus/content/groups/public</url><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l297><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l297>
>          </repository><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l298><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l298>
>      </repositories><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l299><http://hg.openjdk.java.net/code-tools/jmh-jdk-microbenchmarks/file/a644f3612e8d/pom.xml#l299>
>
>
> Is it an internal one? How can I fix or workaround?
>
> See the mvn failure:
>
> [INFO] OpenJDK Microbenchmark Corpus (JDK 8) .............. FAILURE [  0.259 s]
> [INFO] OpenJDK Microbenchmark Corpus (Uber-Package) 1.0-SNAPSHOT SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1.019 s
> [INFO] Finished at: 2019-04-08T17:26:12+08:00
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal on project micros-jdk8: Could not resolve dependencies for project org.openjdk:micros-jdk8:jar:1.0-SNAPSHOT: Failed to collect dependencies at org.openjdk:micros-util:jar:1.0-SNAPSHOT: Failed to read artifact descriptor for org.openjdk:micros-util:jar:1.0-SNAPSHOT: Could not transfer artifact org.openjdk:micros-util:pom:1.0-SNAPSHOT from/to Stockholm Repository (http://maven.se.oracle.com/nexus/content/groups/public): maven.se.oracle.com: Unknown host maven.se.oracle.com -> [Help 1]
>
> Thank you very much!
> Felix Yang
>