From kevin.rushforth at oracle.com Mon Dec 9 21:27:14 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 9 Dec 2019 13:27:14 -0800 Subject: jcheck extension doesn't work with HG 5.x Message-ID: <5cdc276d-c032-086f-2d49-47c7d4d192a7@oracle.com> The jcheck extension doesn't work with Mercurial 5.x. Has anyone else reported this yet? I can file a bug if that would be helpful. -- Kevin From tim.bell at oracle.com Mon Dec 9 22:02:21 2019 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 9 Dec 2019 14:02:21 -0800 Subject: jcheck extension doesn't work with HG 5.x In-Reply-To: <5cdc276d-c032-086f-2d49-47c7d4d192a7@oracle.com> References: <5cdc276d-c032-086f-2d49-47c7d4d192a7@oracle.com> Message-ID: On 12/9/19 1:27 PM, Kevin Rushforth wrote: > The jcheck extension doesn't work with Mercurial 5.x. Has anyone else > reported this yet? I can file a bug if that would be helpful. What is the error output in your case? Possibly an example of: CODETOOLS-7902467 "jcheck fails with mercurial 5: object of type 'branchcache' has no len()" https://bugs.openjdk.java.net/browse/CODETOOLS-7902467 Tim From kevin.rushforth at oracle.com Mon Dec 9 22:16:00 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 9 Dec 2019 14:16:00 -0800 Subject: jcheck extension doesn't work with HG 5.x In-Reply-To: References: <5cdc276d-c032-086f-2d49-47c7d4d192a7@oracle.com> Message-ID: Yes, this is the same bug we ran into. The error message and log is the same. -- Kevin On 12/9/2019 2:02 PM, Tim Bell wrote: > On 12/9/19 1:27 PM, Kevin Rushforth wrote: >> The jcheck extension doesn't work with Mercurial 5.x. Has anyone else >> reported this yet? I can file a bug if that would be helpful. > > What is the error output in your case?? Possibly an example of: > > CODETOOLS-7902467 "jcheck fails with mercurial 5: object of type > 'branchcache' has no len()" > > https://bugs.openjdk.java.net/browse/CODETOOLS-7902467 > > > Tim From tim.bell at oracle.com Fri Dec 20 17:24:19 2019 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 20 Dec 2019 09:24:19 -0800 Subject: RFR (small): CODETOOLS-7902467: jcheck fails with mercurial 5: object of type 'branchcache' has no len() Message-ID: <86233765-161b-3f90-b2b6-99d8ef909bab@oracle.com> Mercurial release 5 removed the dict interface from the branchcache class. jcheck was snooping on the length of that dict as a fast way to check for non default branches. The bug report: https://bugs.openjdk.java.net/browse/CODETOOLS-7902467 The webrev: http://cr.openjdk.java.net/~tbell/CODETOOLS-7902467/webrev/ Tested on hg versions: 2.6.2 3.6, 3.7, 3.8, 3.9.2, 4.5.3, 4.6.1, 4.6.2,4.7.1, 4.7.2, 4.7, 4.8.2, 4.9.1, 5.0.1, 5.1.2, 5.2.1 Thanks in advance. I am an Author in the Code Tools Project [1], so if this looks good, I would also ask a sponsor to push it for me. Tim [1] https://openjdk.java.net/census#code-tools