[PATCH] Fix for EXE_SUFFIX being set for WSL having no effect

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Jan 18 18:12:48 UTC 2019



On 01/17/2019 05:40 PM, Jonathan Gibbons wrote:
>
>
> On 01/17/2019 03:28 PM, Andrew Luo wrote:
>> While fixing shell tests, I noticed that EXE_SUFFIX was having no 
>> effect... That's because we're appending to env after setting 
>> WSLENV... Simple patch attached.
>>
>> Thanks,
>>
>> -Andrew
>
> Thanks for testing and reporting.
>
> Please don't update test/langtools; I'll be doing those.
>
> I recommend getting consensus from other teams before we go ahead with 
> this solution and do a mass update of tests.
>
> -- Jon

Just for the record, here are some stats about the number of shell files 
in the test/jdk directories

59: test/jdk/sun/security
47: test/jdk/java/lang
30: test/jdk/sun/tools
12: test/jdk/java/awt
10: test/jdk/tools/jjs
8: test/jdk/sun/rmi
8: test/jdk/java/security
6: test/jdk/jdk/jfr
6: test/jdk/javax/imageio
5: test/jdk/sun/management
5: test/jdk/java/util
4: test/jdk/javax/script
3: test/jdk/tools/launcher
3: test/jdk/java/nio
3: test/jdk/com/sun
2: test/jdk/javax/swing
2: test/jdk/javax/crypto
1: test/jdk/sun/net
1: test/jdk/sun/jvmstat
1: test/jdk/sun/java2d
1: test/jdk/jdk/security
1: test/jdk/javax/xml
1: test/jdk/javax/security
1: test/jdk/javax/rmi
1: test/jdk/javax/print
1: test/jdk/javax/accessibility
1: test/jdk/java/rmi
1: test/jdk/java/io
1: test/jdk/com/oracle

and hotspot ...

8: test/hotspot/jtreg/compiler/aot
3: test/hotspot/jtreg/vmTestbase/vm
2: test/hotspot/jtreg/vmTestbase/jit
1: test/hotspot/jtreg/vmTestbase/nsk
1: test/hotspot/jtreg/vmTestbase/metaspace
1: test/hotspot/jtreg/vmTestbase/gc
1: test/hotspot/jtreg/serviceability/7170638
1: test/hotspot/jtreg/runtime/StackGuardPages
1: test/hotspot/jtreg/runtime/StackGap
1: test/hotspot/jtreg/runtime/CommandLine
1: test/hotspot/jtreg/runtime/7162488
1: test/hotspot/jtreg/compiler/unsafe
1: test/hotspot/jtreg/compiler/graalunit

and langtools...

7: test/langtools/tools/javac
1: test/langtools/tools/doclint




More information about the code-tools-dev mailing list