From alexandre.iline at oracle.com  Mon Jun 10 20:00:36 2019
From: alexandre.iline at oracle.com (Alexandre (Shura) Iline)
Date: Mon, 10 Jun 2019 13:00:36 -0700
Subject: Result: New Code Tools Committer: Abdul Muneer Kolarkunnu
Message-ID: <C7D73515-0353-4C3D-8F15-E1F2B5DF1547@oracle.com>

Voting for Abdul Muneer Kolarkunnu [1] is now closed. 

Yes: 0
Veto: 0
Abstain: 0 

According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. 
  
Alexander (Shura) Ilin

 [1] https://mail.openjdk.java.net/pipermail/code-tools-dev/2019-May/000547.html


From mikael.vidstedt at oracle.com  Sat Jun 29 08:02:16 2019
From: mikael.vidstedt at oracle.com (Mikael Vidstedt)
Date: Sat, 29 Jun 2019 01:02:16 -0700
Subject: RFR(XS): 7902486: jcheck still fails with mercurial 4.8+
Message-ID: <5F0B7A19-014B-4029-A0B8-750AE069D7CF@oracle.com>


Please review this change which fixes a problem with jcheck and hg 4.8+:

http://cr.openjdk.java.net/~mikael/webrevs/jcheck/7902486/webrev.00/webrev/

Also inline here for your convenience:

diff -r 4ac08a4210ec jcheck.py
--- a/jcheck.py Wed May 29 10:25:28 2019 -0700
+++ b/jcheck.py Sat Jun 29 00:44:27 2019 -0700
@@ -801,7 +801,7 @@
         nop = lambda c, fns: None
         iter = cmdutil.walkchangerevs(repo, _matchall(repo), opts, nop)
         for ctx in iter:
-            ch.check(ctx, ctx.node())
+            ch.check(ctx.rev(), ctx.node())
     except (AttributeError, TypeError):
         # AttributeError:  matchall does not exist in hg < 1.1
         # TypeError:  walkchangerevs args differ in hg <= 1.3.1

Cheers,
Mikael


From mikael.vidstedt at oracle.com  Sat Jun 29 08:03:24 2019
From: mikael.vidstedt at oracle.com (Mikael Vidstedt)
Date: Sat, 29 Jun 2019 01:03:24 -0700
Subject: RFR(XS): 7902486: jcheck still fails with mercurial 4.8+
In-Reply-To: <5F0B7A19-014B-4029-A0B8-750AE069D7CF@oracle.com>
References: <5F0B7A19-014B-4029-A0B8-750AE069D7CF@oracle.com>
Message-ID: <C2FC9681-8F42-4A0D-8F29-C552FF088BFE@oracle.com>


Forgot the link to the issue:

Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902486

Cheers,
Mikael

> On Jun 29, 2019, at 1:02 AM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
> 
> 
> Please review this change which fixes a problem with jcheck and hg 4.8+:
> 
> http://cr.openjdk.java.net/~mikael/webrevs/jcheck/7902486/webrev.00/webrev/
> 
> Also inline here for your convenience:
> 
> diff -r 4ac08a4210ec jcheck.py
> --- a/jcheck.py Wed May 29 10:25:28 2019 -0700
> +++ b/jcheck.py Sat Jun 29 00:44:27 2019 -0700
> @@ -801,7 +801,7 @@
>         nop = lambda c, fns: None
>         iter = cmdutil.walkchangerevs(repo, _matchall(repo), opts, nop)
>         for ctx in iter:
> -            ch.check(ctx, ctx.node())
> +            ch.check(ctx.rev(), ctx.node())
>     except (AttributeError, TypeError):
>         # AttributeError:  matchall does not exist in hg < 1.1
>         # TypeError:  walkchangerevs args differ in hg <= 1.3.1
> 
> Cheers,
> Mikael
>