RFR(XS): 7902486: jcheck still fails with mercurial 4.8+
Mikael Vidstedt
mikael.vidstedt at oracle.com
Sat Jun 29 08:03:24 UTC 2019
Forgot the link to the issue:
Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902486
Cheers,
Mikael
> On Jun 29, 2019, at 1:02 AM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
>
>
> Please review this change which fixes a problem with jcheck and hg 4.8+:
>
> http://cr.openjdk.java.net/~mikael/webrevs/jcheck/7902486/webrev.00/webrev/
>
> Also inline here for your convenience:
>
> diff -r 4ac08a4210ec jcheck.py
> --- a/jcheck.py Wed May 29 10:25:28 2019 -0700
> +++ b/jcheck.py Sat Jun 29 00:44:27 2019 -0700
> @@ -801,7 +801,7 @@
> nop = lambda c, fns: None
> iter = cmdutil.walkchangerevs(repo, _matchall(repo), opts, nop)
> for ctx in iter:
> - ch.check(ctx, ctx.node())
> + ch.check(ctx.rev(), ctx.node())
> except (AttributeError, TypeError):
> # AttributeError: matchall does not exist in hg < 1.1
> # TypeError: walkchangerevs args differ in hg <= 1.3.1
>
> Cheers,
> Mikael
>
More information about the code-tools-dev
mailing list