RFR: CODETOOLS-7902417: jtreg build with build-all.sh should work on cygwin

[Andrew Luo]

I'm a little bit late to this but actually WSL is already working I believe; building using build-all.sh worked out of the box the first time I tried with WSL (several months ago).

Thanks,

-Andrew

-----Original Message-----
From: code-tools-dev <code-tools-dev-bounces at openjdk.java.net> On Behalf Of Jonathan Gibbons
Sent: Thursday, March 7, 2019 11:32 AM
To: Langer, Christoph <christoph.langer at sap.com>; code-tools-dev at openjdk.java.net
Subject: Re: RFR: CODETOOLS-7902417: jtreg build with build-all.sh should work on cygwin

Christoph,

I have pushed this change, with one minor alteration ... in the edit for Rules.gmk, I changed the name of the temporary file to follow the convention used for naming of similar file manifest.txt found nearby.

-- Jon

On 03/06/2019 08:16 AM, Jonathan Gibbons wrote:
> Christoph,
>
> I'll take a look at this today; I can check Linux/Mac, and sponsor it 
> if all seems OK.
>
> At some point, someone is going to want support for WSL (Windows 
> Subsystem for Linux) as well, but I realize that is only for Windows 10.
>
> -- Jon
>
> On 3/6/19 6:59 AM, Langer, Christoph wrote:
>> Hi,
>>
>> I tried to build jtreg with the cool script “build-all.sh” today. 
>> It’s great because it resolves and builds all dependencies. ��
>>
>> However, I used Cygwin on my windows box and had to figure out that 
>> it would not work out of the box there, as claimed on 
>> http://openjdk.java.net/jtreg/build.html
>>
>> I made a few modifications, mainly to the script. I also had to 
>> change a make file where I had to generate options for a jar call 
>> into a command file because it was too much for the command line.
>>
>> Please review my changes and if you like it, please sponsor it ��
>>
>> Webrev: 
>> http://cr.openjdk.java.net/~clanger/webrevs/CODETOOLS-7902417.0/
>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902417
>>
>> I, however, just built with Cygwin. Someone needs to check that I 
>> didn’t break things for Unix/Linux/Mac…
>>
>> Thanks and best regards
>> Christoph
>>