[RFR] 7902421: jcheck fails with mercurial 4.8

Andrew John Hughes gnu.andrew at redhat.com
Mon May 13 17:33:00 UTC 2019

On 22/03/2019 00:59, Andrew John Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902421
> Webrev: https://cr.openjdk.java.net/~andrew/codetools/7902421/webrev.01/
> Mercurial pull requests started failing after upgrading to 4.8.1:
> File "/home/andrew/projects/openjdk/jcheck/jcheck.py", line 745, in hook
>     ch.check(repo.changelog.node(rev))
>   File "/home/andrew/projects/openjdk/jcheck/jcheck.py", line 688, in check
>     ctx = context.changectx(self.repo, node)
> This seems to be because context.changectx now takes an additional argument:
> ArgSpec(args=['self', 'repo', 'rev', 'node'], varargs=None,
> keywords=None, defaults=None)
> so I made changes to pass through the rev argument. This fixes the
> problem and I can pull in changes again.
> I couldn't see any clear mention in the Mercurial code of why this rev
> argument is now required or any explanation of the change on their
> website. Not being overly familiar with either the Mercurial or jcheck
> code, this may be the wrong approach, but it seems to be working so far
> for me.

Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

More information about the code-tools-dev mailing list