[RFR] 7902421: jcheck fails with mercurial 4.8

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon May 13 18:33:06 UTC 2019


Code Tools is not set up to require official "R"eviewers, and so it 
should be enough to have consensus from enough suitably-informed people 
who are familiar with the code in question.

IMO, jcheck is a somewhat special because because of how deeply it is 
embedded within the infrastructure, so we need to be extra careful about 
updates, but it does seem like that is consensus that this is a 
reasonable patch.

-- Jon

On 05/13/2019 11:21 AM, Andrew John Hughes wrote:
> On 13/05/2019 18:39, Erik Joelsson wrote:
>> Looks ok to me.
>> /Erik
>> On 2019-05-13 10:33, Andrew John Hughes wrote:
>>> On 22/03/2019 00:59, Andrew John Hughes wrote:
>>>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902421
>>>> Webrev: https://cr.openjdk.java.net/~andrew/codetools/7902421/webrev.01/
>>>> Mercurial pull requests started failing after upgrading to 4.8.1:
>>>> File "/home/andrew/projects/openjdk/jcheck/jcheck.py", line 745, in hook
>>>>       ch.check(repo.changelog.node(rev))
>>>>     File "/home/andrew/projects/openjdk/jcheck/jcheck.py", line 688,
>>>> in check
>>>>       ctx = context.changectx(self.repo, node)
>>>> This seems to be because context.changectx now takes an additional
>>>> argument:
>>>> ArgSpec(args=['self', 'repo', 'rev', 'node'], varargs=None,
>>>> keywords=None, defaults=None)
>>>> so I made changes to pass through the rev argument. This fixes the
>>>> problem and I can pull in changes again.
>>>> I couldn't see any clear mention in the Mercurial code of why this rev
>>>> argument is now required or any explanation of the change on their
>>>> website. Not being overly familiar with either the Mercurial or jcheck
>>>> code, this may be the wrong approach, but it seems to be working so far
>>>> for me.
>>> Ping?
> Thanks.
> Do I need an official reviewer from
> https://openjdk.java.net/census#code-tools to ok this too or is the ok
> from yourself & Arthur enough to push this?

More information about the code-tools-dev mailing list