[RFR] 7902421: jcheck fails with mercurial 4.8
jonathan.gibbons at oracle.com
Wed May 29 00:35:07 UTC 2019
Erik reviewed it and has commit rights.
Given that Erik reviewed it, I can sponsor it, but I would prefer to do
so at the beginning of a work day instead of at the end of a work day: I
don't want to "push and run".
I'll push the change tomorrow morning (Wed May 29) if no one else has
already done so.
On 5/28/19 3:00 PM, Andrew John Hughes wrote:
> On 13/05/2019 19:33, Jonathan Gibbons wrote:
>> Code Tools is not set up to require official "R"eviewers, and so it
>> should be enough to have consensus from enough suitably-informed people
>> who are familiar with the code in question.
>> IMO, jcheck is a somewhat special because because of how deeply it is
>> embedded within the infrastructure, so we need to be extra careful about
>> updates, but it does seem like that is consensus that this is a
>> reasonable patch.
>> -- Jon
> Thanks Jon.
> I don't have commit access to push this myself, so maybe someone could
> do so on my behalf. Maybe Aleksey? :-)
More information about the code-tools-dev