From leonid.kuskov at oracle.com Fri Apr 3 00:38:57 2020 From: leonid.kuskov at oracle.com (Leonid Kuskov) Date: Thu, 2 Apr 2020 17:38:57 -0700 Subject: RFR Asmtools: CODETOOLS-7902618 CODETOOLS-7902643 CODETOOLS-7902644 CODETOOLS-7902648 Message-ID: Hello, Please review a set of fixes and improvements that I want to move from the development repository to OS: CODETOOLS-7902618 Asmtools does not support jasm output/input for TypeAnnotations CODETOOLS-7902643 Asmtools(jasm) does not support signature attributes in field_info, component_info CODETOOLS-7902644 Asmtools (jcoder) fails if an jcod file contains CONSTANT_Utf8_info with non-normative char sequences CODETOOLS-7902648 jasm has no clues about how to interpret CONSTANT_MethodHandle_info:reference_kind in an invokedynamic instruction Webrev: http://cr.openjdk.java.net/~lkuskov/7902618_7902643_7902644_7902648/webrev.00/ The asmtools with fixes has been tested well during test development of JCK 15 Thanks, Leonid From dmitry.bessonov at oracle.com Tue Apr 14 18:27:50 2020 From: dmitry.bessonov at oracle.com (Dmitry Bessonov) Date: Tue, 14 Apr 2020 19:27:50 +0100 Subject: CFV: New Code Tools Committer: Leonid Kuskov Message-ID: I hereby nominate Leonid Kuskov to Code Tools Committer. Leonid has been working on maintenance and development of the Code Tools JCov and ASMTools projects for several years. He has contributed 9 changesets to the Code Tools "jcov" repo and 27 changesets to the Code Tools "asmtools" repo. Having him as a Code Tools Committer would reinforce development of JCov and ASMTools projects and help keep them relevant and valuable tools. Votes are due by the end of April 28, 2020. Only current Code Tools Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Dmitry Bessonov [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From erik.helin at oracle.com Wed Apr 15 06:11:06 2020 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 15 Apr 2020 08:11:06 +0200 Subject: CFV: New Code Tools Committer: Leonid Kuskov In-Reply-To: References: Message-ID: <0f6a45c3-5ddb-6296-65c6-344fc11c9765@oracle.com> Vote: yes Thanks, Erik On 4/14/20 8:27 PM, Dmitry Bessonov wrote: > I hereby nominate Leonid Kuskov to Code Tools Committer. > > Leonid has been working on maintenance and development of the Code Tools > JCov and ASMTools projects for several years. He has contributed 9 changesets > to the Code Tools "jcov" repo and 27 changesets to the Code Tools "asmtools" repo. > Having him as a Code Tools Committer would reinforce development of JCov and > ASMTools projects and help keep them relevant and valuable tools. > > Votes are due by the end of April 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Dmitry Bessonov > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From victor.rudometov at oracle.com Wed Apr 15 07:25:50 2020 From: victor.rudometov at oracle.com (victor.rudometov at oracle.com) Date: Wed, 15 Apr 2020 10:25:50 +0300 Subject: CFV: New Code Tools Committer: Leonid Kuskov In-Reply-To: References: Message-ID: Vote: yes Victor On 4/14/20 21:27, Dmitry Bessonov wrote: > I hereby nominate Leonid Kuskov to Code Tools Committer. > > Leonid has been working on maintenance and development of the Code Tools > JCov and ASMTools projects for several years. He has contributed 9 changesets > to the Code Tools "jcov" repo and 27 changesets to the Code Tools "asmtools" repo. > Having him as a Code Tools Committer would reinforce development of JCov and > ASMTools projects and help keep them relevant and valuable tools. > > Votes are due by the end of April 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Dmitry Bessonov > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From dmitry.bessonov at oracle.com Wed Apr 15 10:57:35 2020 From: dmitry.bessonov at oracle.com (Dmitry Bessonov) Date: Wed, 15 Apr 2020 11:57:35 +0100 Subject: CFV: New Code Tools Committer: Leonid Kuskov In-Reply-To: References: Message-ID: Vote: yes dmitry > On 14 Apr 2020, at 19:27, Dmitry Bessonov wrote: > > I hereby nominate Leonid Kuskov to Code Tools Committer. > > Leonid has been working on maintenance and development of the Code Tools > JCov and ASMTools projects for several years. He has contributed 9 changesets > to the Code Tools "jcov" repo and 27 changesets to the Code Tools "asmtools" repo. > Having him as a Code Tools Committer would reinforce development of JCov and > ASMTools projects and help keep them relevant and valuable tools. > > Votes are due by the end of April 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Dmitry Bessonov > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From jonathan.gibbons at oracle.com Wed Apr 15 14:27:11 2020 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 15 Apr 2020 07:27:11 -0700 Subject: CFV: New Code Tools Committer: Leonid Kuskov In-Reply-To: References: Message-ID: <2502a101-dd01-59d6-cdbd-7038d1817214@oracle.com> Vote: yes On 4/14/20 11:27 AM, Dmitry Bessonov wrote: > I hereby nominate Leonid Kuskov to Code Tools Committer. > > Leonid has been working on maintenance and development of the Code Tools > JCov and ASMTools projects for several years. He has contributed 9 changesets > to the Code Tools "jcov" repo and 27 changesets to the Code Tools "asmtools" repo. > Having him as a Code Tools Committer would reinforce development of JCov and > ASMTools projects and help keep them relevant and valuable tools. > > Votes are due by the end of April 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Dmitry Bessonov > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From erik.joelsson at oracle.com Wed Apr 15 15:33:42 2020 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 15 Apr 2020 08:33:42 -0700 Subject: CFV: New Code Tools Committer: Leonid Kuskov In-Reply-To: References: Message-ID: Vote: yes /Erik On 2020-04-14 11:27, Dmitry Bessonov wrote: > I hereby nominate Leonid Kuskov to Code Tools Committer. > > Leonid has been working on maintenance and development of the Code Tools > JCov and ASMTools projects for several years. He has contributed 9 changesets > to the Code Tools "jcov" repo and 27 changesets to the Code Tools "asmtools" repo. > Having him as a Code Tools Committer would reinforce development of JCov and > ASMTools projects and help keep them relevant and valuable tools. > > Votes are due by the end of April 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Dmitry Bessonov > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From iris.clark at oracle.com Wed Apr 15 17:14:06 2020 From: iris.clark at oracle.com (Iris Clark) Date: Wed, 15 Apr 2020 10:14:06 -0700 (PDT) Subject: CFV: New Code Tools Committer: Leonid Kuskov In-Reply-To: References: Message-ID: <8edd8a60-c065-4d1e-b050-b7b973190535@default> Vote: yes Iris From stefan.karlsson at oracle.com Mon Apr 20 08:29:20 2020 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Mon, 20 Apr 2020 10:29:20 +0200 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" Message-ID: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> Hi all, Please review this patch to get rid of some warnings from webrev: https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 After an update to my system I got awk 5.0.1, and now webrev complains about: "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" A couple of @'s seems to be incorrectly escaped. This patch replaces \@\@ with @@. I've generated webrevs with: - awk 4.2.1 without fix - awk 4.2.1 with fix - awk 5.0.1 without fix - awk 5.0.1 with fix and verified that they all generate the same output (except some timestamps). Thanks, StefanK From magnus.ihse.bursie at oracle.com Mon Apr 20 08:34:50 2020 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 20 Apr 2020 10:34:50 +0200 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" In-Reply-To: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> References: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> Message-ID: <336af248-d63d-20c8-565b-01dcb64929a5@oracle.com> On 2020-04-20 10:29, Stefan Karlsson wrote: > Hi all, > > Please review this patch to get rid of some warnings from webrev: > > https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ Looks good to me. /Magnus > https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 > > After an update to my system I got awk 5.0.1, and now webrev complains > about: > "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known > regexp operator" > > A couple of @'s seems to be incorrectly escaped. This patch replaces > \@\@ with @@. > > I've generated webrevs with: > - awk 4.2.1 without fix > - awk 4.2.1 with fix > - awk 5.0.1 without fix > - awk 5.0.1 with fix > > and verified that they all generate the same output (except some > timestamps). > > Thanks, > StefanK From stefan.karlsson at oracle.com Mon Apr 20 08:48:39 2020 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Mon, 20 Apr 2020 10:48:39 +0200 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" In-Reply-To: <336af248-d63d-20c8-565b-01dcb64929a5@oracle.com> References: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> <336af248-d63d-20c8-565b-01dcb64929a5@oracle.com> Message-ID: <2835b6c2-cf89-99f4-859b-159a9fc0acfb@oracle.com> Thanks, Magnus. StefanK On 2020-04-20 10:34, Magnus Ihse Bursie wrote: > On 2020-04-20 10:29, Stefan Karlsson wrote: >> Hi all, >> >> Please review this patch to get rid of some warnings from webrev: >> >> https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ > Looks good to me. > > /Magnus >> https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 >> >> After an update to my system I got awk 5.0.1, and now webrev complains >> about: >> "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known >> regexp operator" >> >> A couple of @'s seems to be incorrectly escaped. This patch replaces >> \@\@ with @@. >> >> I've generated webrevs with: >> - awk 4.2.1 without fix >> - awk 4.2.1 with fix >> - awk 5.0.1 without fix >> - awk 5.0.1 with fix >> >> and verified that they all generate the same output (except some >> timestamps). >> >> Thanks, >> StefanK > From erik.joelsson at oracle.com Mon Apr 20 12:41:23 2020 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 20 Apr 2020 05:41:23 -0700 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" In-Reply-To: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> References: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> Message-ID: <7688ce73-6825-57af-9956-6ce3ab89f43c@oracle.com> Looks good. /Erik On 2020-04-20 01:29, Stefan Karlsson wrote: > Hi all, > > Please review this patch to get rid of some warnings from webrev: > > https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ > https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 > > After an update to my system I got awk 5.0.1, and now webrev complains > about: > "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known > regexp operator" > > A couple of @'s seems to be incorrectly escaped. This patch replaces > \@\@ with @@. > > I've generated webrevs with: > - awk 4.2.1 without fix > - awk 4.2.1 with fix > - awk 5.0.1 without fix > - awk 5.0.1 with fix > > and verified that they all generate the same output (except some > timestamps). > > Thanks, > StefanK From stefan.karlsson at oracle.com Mon Apr 20 14:01:34 2020 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Mon, 20 Apr 2020 16:01:34 +0200 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" In-Reply-To: <7688ce73-6825-57af-9956-6ce3ab89f43c@oracle.com> References: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> <7688ce73-6825-57af-9956-6ce3ab89f43c@oracle.com> Message-ID: Thanks, Erik. StefanK On 2020-04-20 14:41, Erik Joelsson wrote: > Looks good. > > /Erik > > On 2020-04-20 01:29, Stefan Karlsson wrote: >> Hi all, >> >> Please review this patch to get rid of some warnings from webrev: >> >> https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ >> https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 >> >> After an update to my system I got awk 5.0.1, and now webrev complains >> about: >> "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known >> regexp operator" >> >> A couple of @'s seems to be incorrectly escaped. This patch replaces >> \@\@ with @@. >> >> I've generated webrevs with: >> - awk 4.2.1 without fix >> - awk 4.2.1 with fix >> - awk 5.0.1 without fix >> - awk 5.0.1 with fix >> >> and verified that they all generate the same output (except some >> timestamps). >> >> Thanks, >> StefanK From christoph.langer at sap.com Thu Apr 23 05:47:19 2020 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 23 Apr 2020 05:47:19 +0000 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" In-Reply-To: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> References: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> Message-ID: Hi Stefan, thanks for fixing this... it annoyed me in my Windows/Cygwin setup a lot ?? Fix looks good and I can confirm that it works. Best regards Christoph > -----Original Message----- > From: code-tools-dev On > Behalf Of Stefan Karlsson > Sent: Montag, 20. April 2020 10:29 > To: code-tools-dev at openjdk.java.net > Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp > escape sequence `\@' is not a known regexp operator" > > Hi all, > > Please review this patch to get rid of some warnings from webrev: > > https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ > https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 > > After an update to my system I got awk 5.0.1, and now webrev complains > about: > "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known > regexp operator" > > A couple of @'s seems to be incorrectly escaped. This patch replaces > \@\@ with @@. > > I've generated webrevs with: > - awk 4.2.1 without fix > - awk 4.2.1 with fix > - awk 5.0.1 without fix > - awk 5.0.1 with fix > > and verified that they all generate the same output (except some > timestamps). > > Thanks, > StefanK From stefan.karlsson at oracle.com Thu Apr 23 07:22:12 2020 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Thu, 23 Apr 2020 09:22:12 +0200 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" In-Reply-To: References: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> Message-ID: <48feafb0-aef9-d599-a5da-d68fd0693cbf@oracle.com> Thanks, Christoph. I'm merely a jdk Reviewer and have no status in the code-tools project :) Could someone sponsor this change? Thanks, StefanK On 2020-04-23 07:47, Langer, Christoph wrote: > Hi Stefan, > > thanks for fixing this... it annoyed me in my Windows/Cygwin setup a lot ?? > > Fix looks good and I can confirm that it works. > > Best regards > Christoph > >> -----Original Message----- >> From: code-tools-dev On >> Behalf Of Stefan Karlsson >> Sent: Montag, 20. April 2020 10:29 >> To: code-tools-dev at openjdk.java.net >> Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp >> escape sequence `\@' is not a known regexp operator" >> >> Hi all, >> >> Please review this patch to get rid of some warnings from webrev: >> >> https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ >> https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 >> >> After an update to my system I got awk 5.0.1, and now webrev complains >> about: >> "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known >> regexp operator" >> >> A couple of @'s seems to be incorrectly escaped. This patch replaces >> \@\@ with @@. >> >> I've generated webrevs with: >> - awk 4.2.1 without fix >> - awk 4.2.1 with fix >> - awk 5.0.1 without fix >> - awk 5.0.1 with fix >> >> and verified that they all generate the same output (except some >> timestamps). >> >> Thanks, >> StefanK From christoph.langer at sap.com Thu Apr 23 09:06:52 2020 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 23 Apr 2020 09:06:52 +0000 Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known regexp operator" In-Reply-To: <48feafb0-aef9-d599-a5da-d68fd0693cbf@oracle.com> References: <360f79eb-75e2-f765-86f1-9b62f0738084@oracle.com> <48feafb0-aef9-d599-a5da-d68fd0693cbf@oracle.com> Message-ID: I only made it to author there, so somebody else needs to sponsor it ?? /Christoph > -----Original Message----- > From: Stefan Karlsson > Sent: Donnerstag, 23. April 2020 09:22 > To: Langer, Christoph ; code-tools- > dev at openjdk.java.net > Subject: Re: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp > escape sequence `\@' is not a known regexp operator" > > Thanks, Christoph. > > I'm merely a jdk Reviewer and have no status in the code-tools project > :) Could someone sponsor this change? > > Thanks, > StefanK > > On 2020-04-23 07:47, Langer, Christoph wrote: > > Hi Stefan, > > > > thanks for fixing this... it annoyed me in my Windows/Cygwin setup a lot > ?? > > > > Fix looks good and I can confirm that it works. > > > > Best regards > > Christoph > > > >> -----Original Message----- > >> From: code-tools-dev On > >> Behalf Of Stefan Karlsson > >> Sent: Montag, 20. April 2020 10:29 > >> To: code-tools-dev at openjdk.java.net > >> Subject: RFR: 7902652: Webrev: prints "awk: cmd. line:8: warning: regexp > >> escape sequence `\@' is not a known regexp operator" > >> > >> Hi all, > >> > >> Please review this patch to get rid of some warnings from webrev: > >> > >> https://cr.openjdk.java.net/~stefank/CODETOOLS-7902652/webrev.01/ > >> https://bugs.openjdk.java.net/browse/CODETOOLS-7902652 > >> > >> After an update to my system I got awk 5.0.1, and now webrev complains > >> about: > >> "awk: cmd. line:8: warning: regexp escape sequence `\@' is not a known > >> regexp operator" > >> > >> A couple of @'s seems to be incorrectly escaped. This patch replaces > >> \@\@ with @@. > >> > >> I've generated webrevs with: > >> - awk 4.2.1 without fix > >> - awk 4.2.1 with fix > >> - awk 5.0.1 without fix > >> - awk 5.0.1 with fix > >> > >> and verified that they all generate the same output (except some > >> timestamps). > >> > >> Thanks, > >> StefanK