From leonid.kuskov at oracle.com Tue Feb 4 01:22:18 2020 From: leonid.kuskov at oracle.com (Leonid Kuskov) Date: Mon, 3 Feb 2020 17:22:18 -0800 Subject: RFR: Asmtools support: JEP 360 Sealed Types(Preview) Message-ID: Hi, Please review the asmtools update for [1] at http://cr.openjdk.java.net/~lkuskov/7902525/webrev.00/ 1]CODETOOLS-7902525 Asmtools support: JEP 360 Sealed Types(Preview) Thanks, Leonid From erik.helin at oracle.com Fri Feb 14 13:17:48 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 14 Feb 2020 14:17:48 +0100 Subject: RFR: 7902610: Make jcheck tests work with Mercurial 4.3+ Message-ID: <34729332-98ec-8240-666d-ccf078469155@oracle.com> Hi all, please review this small patch that ensures that `make test` in the jcheck repository works with Mercurial version 4.3 and newer. The patch simply applies the same fix to jcheck_test.py that was applied to jcheck.py in 80ed80843d64 [0]. Webrev: - http://cr.openjdk.java.net/~ehelin/7902610/00/ Issue: - https://bugs.openjdk.java.net/browse/CODETOOLS-7902610 Testing: - `make test` passes on Linux x64 with hg 4.9 I'm not a committer in code-tools [1] so it would be great if someone could sponsor the patch for me. Thanks, Erik [0]: https://hg.openjdk.java.net/code-tools/jcheck/rev/80ed80843d64 [1]: http://openjdk.java.net/census#code-tools From tim.bell at oracle.com Fri Feb 14 14:16:35 2020 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 14 Feb 2020 06:16:35 -0800 Subject: RFR: 7902610: Make jcheck tests work with Mercurial 4.3+ In-Reply-To: <34729332-98ec-8240-666d-ccf078469155@oracle.com> References: <34729332-98ec-8240-666d-ccf078469155@oracle.com> Message-ID: On 2/14/20 5:17 AM, Erik Helin wrote: > please review this small patch that ensures that `make test` in the > jcheck repository works with Mercurial version 4.3 and newer. The patch > simply applies the same fix to jcheck_test.py that was applied to > jcheck.py in 80ed80843d64 [0]. > > Webrev: > - http://cr.openjdk.java.net/~ehelin/7902610/00/ > > Issue: > - https://bugs.openjdk.java.net/browse/CODETOOLS-7902610 > > Testing: > - `make test` passes on Linux x64 with hg 4.9 > > I'm not a committer in code-tools [1] so it would be great if someone > could sponsor the patch for me. > > Thanks, > Erik > > [0]: https://hg.openjdk.java.net/code-tools/jcheck/rev/80ed80843d64 > [1]: http://openjdk.java.net/census#code-tools I am an Author, not a Reviewer in code-tools. I confirm this fix and say thumbs up with a small 't'. Tim From erik.helin at oracle.com Fri Feb 14 14:29:20 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 14 Feb 2020 15:29:20 +0100 Subject: RFR: 7902611: Add support for Mercurial 5.3 Message-ID: <16102f04-349b-d176-eb63-90afa202d911@oracle.com> Hi all, please review this patch that adds support to jcheck for Mercurial 5.3. There are two changes to Mercurial's API that affects jcheck: - c5548b0b6847 scmutil: convert status data object from a tuple to an attrs (API) Review: https://phab.mercurial-scm.org/D7406 Commit: https://www.mercurial-scm.org/repo/hg/rev/c5548b0b6847 - 1e87851dba63 changectx: add a "maybe filtered" filtered attribute Review: https://phab.mercurial-scm.org/D7483 Commit: https://www.mercurial-scm.org/repo/hg/rev/1e87851dba63 The first commit changed the class `scmutil.status` to inherit from `object` instead of `tuple`. The fix for this is easy since `scmutil.status implements `__iter__` - we can just feed the result of `repo.status()` to the `tuple` constructor and we have a `tuple` again. This is backwards compatible with the old API since `tuple(tuple([1,2,3]))` result in `tuple(1,2,3)` - i.e. applying `tuple` on a tuple is no-op. The second commit added an argument with a default value to the constructor for `context.changectx`. jcheck already has a workaround for this constructor since it was changed back in 3d35304bd09b [0], the jcheck workarouud was introduced in jcheck 4ac08a4210ec [1]. The problem is that the fix in 4ac08a4210ec was a bit too strict - it expects the `context.changectx` constructor to take _exactly_ 4 arguments. When the fifth argument with a defaul value was added, then this workaround fails. I changed this workaround to first try to use the oldest version of the `context.changectx` constructor, and if that fails with a `TypeError`, use the more recent variant of the constructor. Issue: - https://bugs.openjdk.java.net/browse/CODETOOLS-7902611 Webrev: - https://cr.openjdk.java.net/~ehelin/7902611/00/ Testing: - `make test` passes with hg 4.9 and 5.3 Thanks, Erik [0]: https://www.mercurial-scm.org/repo/hg/rev/3d35304bd09b [1]: https://hg.openjdk.java.net/code-tools/jcheck/rev/4ac08a4210ec From erik.helin at oracle.com Fri Feb 14 14:37:13 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 14 Feb 2020 15:37:13 +0100 Subject: RFR: 7902610: Make jcheck tests work with Mercurial 4.3+ In-Reply-To: References: <34729332-98ec-8240-666d-ccf078469155@oracle.com> Message-ID: On 2/14/20 3:16 PM, Tim Bell wrote: > On 2/14/20 5:17 AM, Erik Helin wrote: > >> please review this small patch that ensures that `make test` in the >> jcheck repository works with Mercurial version 4.3 and newer. The >> patch simply applies the same fix to jcheck_test.py that was applied >> to jcheck.py in 80ed80843d64 [0]. >> >> Webrev: >> - http://cr.openjdk.java.net/~ehelin/7902610/00/ >> >> Issue: >> - https://bugs.openjdk.java.net/browse/CODETOOLS-7902610 >> >> Testing: >> - `make test` passes on Linux x64 with hg 4.9 >> >> I'm not a committer in code-tools [1] so it would be great if someone >> could sponsor the patch for me. >> >> Thanks, >> Erik >> >> [0]: https://hg.openjdk.java.net/code-tools/jcheck/rev/80ed80843d64 >> [1]: http://openjdk.java.net/census#code-tools > > I am an Author, not a Reviewer in code-tools.? I confirm this fix and > say thumbs up with a small 't'. Thanks for reviewing, Erik > Tim From jonathan.gibbons at oracle.com Sat Feb 15 00:55:05 2020 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 14 Feb 2020 16:55:05 -0800 Subject: CFV: New Code Tools Committer: Erik Helin Message-ID: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> I hereby nominate Erik Helin (Erik Duveblad) to Code Tools Committer. Erik has made the following commits across all code-tools repositories: code-tools/jtreg: - 7902083: Simplify building jtreg ? http://hg.openjdk.java.net/code-tools/jtreg/rev/48096bc3d911 - Convert to use of ANT_JAR ? http://hg.openjdk.java.net/code-tools/jtreg/rev/64661a3c3033 - Use the same javac for all compilations ? http://hg.openjdk.java.net/code-tools/jtreg/rev/621cc34dec01 - 7902072: Add support for imported license files ? 7902069: jtreg-4.2-b10 build failure looking for jcov.jar ? http://hg.openjdk.java.net/code-tools/jtreg/rev/9ab747435a70 (partial) - Convert to use of JCOV_JAR and JCOV_NETWORK_SAVER_JAR ? http://hg.openjdk.java.net/code-tools/jtreg/rev/144f9e52fb7e - Convert to use of ASMTOOLS_JAR ? http://hg.openjdk.java.net/code-tools/jtreg/rev/0cc965822f71 - 7901995: Allow BUILDDIR to be specified ? http://hg.openjdk.java.net/code-tools/jtreg/rev/ccd2976912a9 (partial) code-tools/asmtools: - Introduce BUILD_DIR property ? http://hg.openjdk.java.net/code-tools/asmtools/rev/f2cacbad3e0c code-tools/jcov: - Always create build.dir and tmp.dir ? http://hg.openjdk.java.net/code-tools/jcov/rev/4cfae0867822 - Use checksum to ensure correct asm dependency is used ? http://hg.openjdk.java.net/code-tools/jcov/rev/16cbc6c62174 code-tools/jtharness: - Ensure all javac tasks have source set ? http://hg.openjdk.java.net/code-tools/jtharness/rev/562a8aa35d4c - CODETOOLS-7901981 Update asm dependency ? http://hg.openjdk.java.net/code-tools/jtharness/rev/df5f3f3fe4b3 In addition to the above, he has? also ported code-tools/defpath, code-tools/jcheck and code-tools/webrev to Java as part of project Skara. Votes are due by the end of February 28, 2020. Only current Code Tools Committers [1] are eligible to vote on this nomination.? Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. -- Jonathan Gibbons [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From eric.caspole at oracle.com Tue Feb 18 15:50:28 2020 From: eric.caspole at oracle.com (Eric Caspole) Date: Tue, 18 Feb 2020 10:50:28 -0500 Subject: CFV: New Code Tools Committer: Erik Helin In-Reply-To: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> References: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> Message-ID: <5c43fca0-f7b2-2e30-ec22-ea048cf1052b@oracle.com> Vote: yes Eric On 2/14/20 19:55, Jonathan Gibbons wrote: > > I hereby nominate Erik Helin (Erik Duveblad) to Code Tools Committer. > > Erik has made the following commits across all code-tools repositories: > > code-tools/jtreg: > - 7902083: Simplify building jtreg > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/48096bc3d911 > > - Convert to use of ANT_JAR > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/64661a3c3033 > > - Use the same javac for all compilations > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/621cc34dec01 > > - 7902072: Add support for imported license files > ? 7902069: jtreg-4.2-b10 build failure looking for jcov.jar > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/9ab747435a70 (partial) > > - Convert to use of JCOV_JAR and JCOV_NETWORK_SAVER_JAR > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/144f9e52fb7e > > - Convert to use of ASMTOOLS_JAR > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/0cc965822f71 > > - 7901995: Allow BUILDDIR to be specified > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/ccd2976912a9 (partial) > > code-tools/asmtools: > - Introduce BUILD_DIR property > ? http://hg.openjdk.java.net/code-tools/asmtools/rev/f2cacbad3e0c > > code-tools/jcov: > - Always create build.dir and tmp.dir > ? http://hg.openjdk.java.net/code-tools/jcov/rev/4cfae0867822 > > - Use checksum to ensure correct asm dependency is used > ? http://hg.openjdk.java.net/code-tools/jcov/rev/16cbc6c62174 > > code-tools/jtharness: > - Ensure all javac tasks have source set > ? http://hg.openjdk.java.net/code-tools/jtharness/rev/562a8aa35d4c > - CODETOOLS-7901981 Update asm dependency > ? http://hg.openjdk.java.net/code-tools/jtharness/rev/df5f3f3fe4b3 > > In addition to the above, he has? also ported code-tools/defpath, > code-tools/jcheck and code-tools/webrev to Java as part of project Skara. > > > Votes are due by the end of February 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -- Jonathan Gibbons > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From iris.clark at oracle.com Tue Feb 18 16:01:05 2020 From: iris.clark at oracle.com (Iris Clark) Date: Tue, 18 Feb 2020 08:01:05 -0800 (PST) Subject: CFV: New Code Tools Committer: Erik Helin In-Reply-To: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> References: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> Message-ID: <7ef9ff24-86ab-4e03-a41e-1caeedb55bdb@default> Vote: yes Iris From erik.joelsson at oracle.com Tue Feb 18 18:29:41 2020 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 18 Feb 2020 10:29:41 -0800 Subject: RFR: 7902610: Make jcheck tests work with Mercurial 4.3+ In-Reply-To: <34729332-98ec-8240-666d-ccf078469155@oracle.com> References: <34729332-98ec-8240-666d-ccf078469155@oracle.com> Message-ID: <977b9b87-ee7b-1fe4-80d7-0e37963f4a5b@oracle.com> Looks good. /Erik On 2020-02-14 05:17, Erik Helin wrote: > Hi all, > > please review this small patch that ensures that `make test` in the > jcheck repository works with Mercurial version 4.3 and newer. The > patch simply applies the same fix to jcheck_test.py that was applied > to jcheck.py in 80ed80843d64 [0]. > > Webrev: > - http://cr.openjdk.java.net/~ehelin/7902610/00/ > > Issue: > - https://bugs.openjdk.java.net/browse/CODETOOLS-7902610 > > Testing: > - `make test` passes on Linux x64 with hg 4.9 > > I'm not a committer in code-tools [1] so it would be great if someone > could sponsor the patch for me. > > Thanks, > Erik > > [0]: https://hg.openjdk.java.net/code-tools/jcheck/rev/80ed80843d64 > [1]: http://openjdk.java.net/census#code-tools From erik.joelsson at oracle.com Tue Feb 18 18:33:30 2020 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 18 Feb 2020 10:33:30 -0800 Subject: RFR: 7902611: Add support for Mercurial 5.3 In-Reply-To: <16102f04-349b-d176-eb63-90afa202d911@oracle.com> References: <16102f04-349b-d176-eb63-90afa202d911@oracle.com> Message-ID: Looks good. /Erik On 2020-02-14 06:29, Erik Helin wrote: > Hi all, > > please review this patch that adds support to jcheck for Mercurial > 5.3. There are two changes to Mercurial's API that affects jcheck: > > - c5548b0b6847 > ? scmutil: convert status data object from a tuple to an attrs (API) > > ? Review: https://phab.mercurial-scm.org/D7406 > ? Commit: https://www.mercurial-scm.org/repo/hg/rev/c5548b0b6847 > > - 1e87851dba63 > ? changectx: add a "maybe filtered" filtered attribute > > ? Review: https://phab.mercurial-scm.org/D7483 > ? Commit: https://www.mercurial-scm.org/repo/hg/rev/1e87851dba63 > > The first commit changed the class `scmutil.status` to inherit from > `object` instead of `tuple`. The fix for this is easy since > `scmutil.status implements `__iter__` - we can just feed the result of > `repo.status()` to the `tuple` constructor and we have a `tuple` > again. This is backwards compatible with the old API since > `tuple(tuple([1,2,3]))` result in `tuple(1,2,3)` - i.e. applying > `tuple` on a tuple is no-op. > > The second commit added an argument with a default value to the > constructor for `context.changectx`. jcheck already has a workaround > for this constructor since it was changed back in 3d35304bd09b [0], > the jcheck workarouud was introduced in jcheck 4ac08a4210ec [1]. The > problem is that the fix in 4ac08a4210ec was a bit too strict - it > expects the `context.changectx` constructor to take _exactly_ 4 > arguments. When the fifth argument with a defaul value was added, then > this workaround fails. I changed this workaround to first try to use > the oldest version of the `context.changectx` constructor, and if that > fails with a `TypeError`, use the more recent variant of the constructor. > > Issue: > - https://bugs.openjdk.java.net/browse/CODETOOLS-7902611 > > Webrev: > - https://cr.openjdk.java.net/~ehelin/7902611/00/ > > Testing: > - `make test` passes with hg 4.9 and 5.3 > > Thanks, > Erik > > [0]: https://www.mercurial-scm.org/repo/hg/rev/3d35304bd09b > [1]: https://hg.openjdk.java.net/code-tools/jcheck/rev/4ac08a4210ec From erik.joelsson at oracle.com Tue Feb 18 18:34:31 2020 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 18 Feb 2020 10:34:31 -0800 Subject: CFV: New Code Tools Committer: Erik Helin In-Reply-To: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> References: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> Message-ID: <7229555f-ea5c-4e36-122f-6053a117bc38@oracle.com> Vote: yes /Erik From victor.rudometov at oracle.com Thu Feb 20 09:13:54 2020 From: victor.rudometov at oracle.com (victor.rudometov at oracle.com) Date: Thu, 20 Feb 2020 12:13:54 +0300 Subject: CFV: New Code Tools Committer: Erik Helin In-Reply-To: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> References: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> Message-ID: Vote: yes Victor. On 2/15/20 03:55, Jonathan Gibbons wrote: > > I hereby nominate Erik Helin (Erik Duveblad) to Code Tools Committer. > > Erik has made the following commits across all code-tools repositories: > > code-tools/jtreg: > - 7902083: Simplify building jtreg > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/48096bc3d911 > > - Convert to use of ANT_JAR > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/64661a3c3033 > > - Use the same javac for all compilations > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/621cc34dec01 > > - 7902072: Add support for imported license files > ? 7902069: jtreg-4.2-b10 build failure looking for jcov.jar > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/9ab747435a70 (partial) > > - Convert to use of JCOV_JAR and JCOV_NETWORK_SAVER_JAR > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/144f9e52fb7e > > - Convert to use of ASMTOOLS_JAR > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/0cc965822f71 > > - 7901995: Allow BUILDDIR to be specified > ? http://hg.openjdk.java.net/code-tools/jtreg/rev/ccd2976912a9 (partial) > > code-tools/asmtools: > - Introduce BUILD_DIR property > ? http://hg.openjdk.java.net/code-tools/asmtools/rev/f2cacbad3e0c > > code-tools/jcov: > - Always create build.dir and tmp.dir > ? http://hg.openjdk.java.net/code-tools/jcov/rev/4cfae0867822 > > - Use checksum to ensure correct asm dependency is used > ? http://hg.openjdk.java.net/code-tools/jcov/rev/16cbc6c62174 > > code-tools/jtharness: > - Ensure all javac tasks have source set > ? http://hg.openjdk.java.net/code-tools/jtharness/rev/562a8aa35d4c > - CODETOOLS-7901981 Update asm dependency > ? http://hg.openjdk.java.net/code-tools/jtharness/rev/df5f3f3fe4b3 > > In addition to the above, he has? also ported code-tools/defpath, > code-tools/jcheck and code-tools/webrev to Java as part of project Skara. > > > Votes are due by the end of February 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -- Jonathan Gibbons > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From dmitry.bessonov at oracle.com Thu Feb 20 13:33:59 2020 From: dmitry.bessonov at oracle.com (Dmitry Bessonov) Date: Thu, 20 Feb 2020 16:33:59 +0300 Subject: CFV: New Code Tools Committer: Erik Helin In-Reply-To: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> References: <06f49610-3186-c07f-8abd-aa37948731e1@oracle.com> Message-ID: <3016489E-830F-425F-92E2-F4C508C431C0@oracle.com> Vote: yes dmitry