RFR: 7902610: Make jcheck tests work with Mercurial 4.3+

Erik Helin erik.helin at oracle.com
Fri Feb 14 14:37:13 UTC 2020


On 2/14/20 3:16 PM, Tim Bell wrote:
> On 2/14/20 5:17 AM, Erik Helin wrote:
> 
>> please review this small patch that ensures that `make test` in the 
>> jcheck repository works with Mercurial version 4.3 and newer. The 
>> patch simply applies the same fix to jcheck_test.py that was applied 
>> to jcheck.py in 80ed80843d64 [0].
>>
>> Webrev:
>> - http://cr.openjdk.java.net/~ehelin/7902610/00/
>>
>> Issue:
>> - https://bugs.openjdk.java.net/browse/CODETOOLS-7902610
>>
>> Testing:
>> - `make test` passes on Linux x64 with hg 4.9
>>
>> I'm not a committer in code-tools [1] so it would be great if someone 
>> could sponsor the patch for me.
>>
>> Thanks,
>> Erik
>>
>> [0]: https://hg.openjdk.java.net/code-tools/jcheck/rev/80ed80843d64
>> [1]: http://openjdk.java.net/census#code-tools
> 
> I am an Author, not a Reviewer in code-tools.  I confirm this fix and 
> say thumbs up with a small 't'.

Thanks for reviewing,
Erik

> Tim



More information about the code-tools-dev mailing list