From erik.joelsson at oracle.com Thu Jan 2 09:25:11 2020 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 2 Jan 2020 10:25:11 +0100 Subject: RFR (small): CODETOOLS-7902467: jcheck fails with mercurial 5: object of type 'branchcache' has no len() In-Reply-To: <86233765-161b-3f90-b2b6-99d8ef909bab@oracle.com> References: <86233765-161b-3f90-b2b6-99d8ef909bab@oracle.com> Message-ID: Looks good. /Erik On 2019-12-20 18:24, Tim Bell wrote: > Mercurial release 5 removed the dict interface from the branchcache > class. jcheck was snooping on the length of that dict as a fast way to > check for non default branches. > > The bug report: > ? https://bugs.openjdk.java.net/browse/CODETOOLS-7902467 > > The webrev: > ? http://cr.openjdk.java.net/~tbell/CODETOOLS-7902467/webrev/ > > Tested on hg versions: > ? 2.6.2 > ? 3.6, 3.7, 3.8, 3.9.2, > ? 4.5.3, 4.6.1, 4.6.2,4.7.1, 4.7.2, 4.7, 4.8.2, 4.9.1, > ? 5.0.1, 5.1.2, 5.2.1 > > Thanks in advance. > > I am an Author in the Code Tools Project [1], so if this looks good, I > would also ask a sponsor to push it for me. > > Tim > > [1] https://openjdk.java.net/census#code-tools From leonid.kuskov at oracle.com Mon Jan 6 21:49:48 2020 From: leonid.kuskov at oracle.com (Leonid Kuskov) Date: Mon, 6 Jan 2020 13:49:48 -0800 Subject: RFR Asmtools: CODETOOLS-7902549, CODETOOLS-7902563 Message-ID: <688329b7-012c-d872-9149-c0ecee71fb12@oracle.com> Hi, Please review a set of fixes and improvements that I want to move from a development repository to OS: https://bugs.openjdk.java.net/browse/CODETOOLS-7902549 https://bugs.openjdk.java.net/browse/CODETOOLS-7902563 && Codebase, build updated to support JDK 8 Webrev: http://cr.openjdk.java.net/~lkuskov/7902549_7902563/webrev.00/ Best Regards, Leonid