From manukumar.vs at oracle.com Thu Jul 2 04:01:25 2020 From: manukumar.vs at oracle.com (Manukumar V S) Date: Thu, 2 Jul 2020 04:01:25 +0000 (UTC) Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility Message-ID: Hi, Can you please review these changes in defpath.py to make it compatible with Python 3.0: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility Webrev: http://cr.openjdk.java.net/~mvs/CODETOOLS-7902711/webrev.00/ Thanks Manukumar V S From manukumar.vs at oracle.com Thu Jul 9 07:09:00 2020 From: manukumar.vs at oracle.com (Manukumar V S) Date: Thu, 9 Jul 2020 00:09:00 -0700 (PDT) Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility In-Reply-To: References: Message-ID: <218213e3-21bb-4034-8031-b99430dc878b@default> Gentle reminder!!!... -----Original Message----- From: Manukumar V S Sent: Thursday, July 2, 2020 9:31 AM To: code-tools-dev at openjdk.java.net Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility Hi, Can you please review these changes in defpath.py to make it compatible with Python 3.0: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility Webrev: http://cr.openjdk.java.net/~mvs/CODETOOLS-7902711/webrev.00/ Thanks Manukumar V S From erik.joelsson at oracle.com Thu Jul 9 19:48:40 2020 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 9 Jul 2020 12:48:40 -0700 Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility In-Reply-To: <218213e3-21bb-4034-8031-b99430dc878b@default> References: <218213e3-21bb-4034-8031-b99430dc878b@default> Message-ID: <840094db-a1a1-5359-ca43-8960738c1553@oracle.com> Looks good to me. /Erik On 2020-07-09 00:09, Manukumar V S wrote: > Gentle reminder!!!... > > -----Original Message----- > From: Manukumar V S > Sent: Thursday, July 2, 2020 9:31 AM > To: code-tools-dev at openjdk.java.net > Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility > > Hi, > > Can you please review these changes in defpath.py to make it compatible with Python 3.0: > > CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility > > Webrev: > http://cr.openjdk.java.net/~mvs/CODETOOLS-7902711/webrev.00/ > > > Thanks > Manukumar V S From tim.bell at oracle.com Thu Jul 9 19:56:28 2020 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 9 Jul 2020 12:56:28 -0700 Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility In-Reply-To: <218213e3-21bb-4034-8031-b99430dc878b@default> References: <218213e3-21bb-4034-8031-b99430dc878b@default> Message-ID: Hello I'm not a Reviewer in CODETOOLS, but as an Author I can say the fix looks good. Tested OK using hg 2.6.2 (Python 2.7.5), so I confirm the old path still works. Tim [1] https://openjdk.java.net/census#code-tools On 2020-07-09 00:09, Manukumar V S wrote: > Gentle reminder!!!... > > -----Original Message----- > From: Manukumar V S > Sent: Thursday, July 2, 2020 9:31 AM > To: code-tools-dev at openjdk.java.net > Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility > > Hi, > > Can you please review these changes in defpath.py to make it compatible with Python 3.0: > > CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility > > Webrev: > http://cr.openjdk.java.net/~mvs/CODETOOLS-7902711/webrev.00/ > > > Thanks > Manukumar V S > From jonathan.gibbons at oracle.com Thu Jul 9 20:01:20 2020 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 9 Jul 2020 13:01:20 -0700 Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility In-Reply-To: <218213e3-21bb-4034-8031-b99430dc878b@default> References: <218213e3-21bb-4034-8031-b99430dc878b@default> Message-ID: <2dfeaf35-76e9-d576-0824-439fd7637349@oracle.com> Hi, Given the reviews by Erik and Tim, it looks like this patch is good to go.? Do you need me to sponsor this change for you? -- Jon On 7/9/20 12:09 AM, Manukumar V S wrote: > Gentle reminder!!!... > > -----Original Message----- > From: Manukumar V S > Sent: Thursday, July 2, 2020 9:31 AM > To: code-tools-dev at openjdk.java.net > Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility > > Hi, > > Can you please review these changes in defpath.py to make it compatible with Python 3.0: > > CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility > > Webrev: > http://cr.openjdk.java.net/~mvs/CODETOOLS-7902711/webrev.00/ > > > Thanks > Manukumar V S From manukumar.vs at oracle.com Fri Jul 10 05:03:13 2020 From: manukumar.vs at oracle.com (Manukumar V S) Date: Thu, 9 Jul 2020 22:03:13 -0700 (PDT) Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility In-Reply-To: <2dfeaf35-76e9-d576-0824-439fd7637349@oracle.com> References: <218213e3-21bb-4034-8031-b99430dc878b@default> <2dfeaf35-76e9-d576-0824-439fd7637349@oracle.com> Message-ID: <61761d13-1376-4b79-97a5-cc3c83810662@default> Hi Jonathan, Yes, Can you please sponsor my change. Thanks in advance. -Manukumar V S -----Original Message----- From: Jonathan Gibbons Sent: Friday, July 10, 2020 1:31 AM To: Manukumar V S ; code-tools-dev at openjdk.java.net Subject: Re: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility Hi, Given the reviews by Erik and Tim, it looks like this patch is good to go.? Do you need me to sponsor this change for you? -- Jon On 7/9/20 12:09 AM, Manukumar V S wrote: > Gentle reminder!!!... > > -----Original Message----- > From: Manukumar V S > Sent: Thursday, July 2, 2020 9:31 AM > To: code-tools-dev at openjdk.java.net > Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 > compatibility > > Hi, > > Can you please review these changes in defpath.py to make it compatible with Python 3.0: > > CODETOOLS-7902711 > defpath > upgrade needed for Python 3 compatibility > > Webrev: > http://cr.openjdk.java.net/~mvs/CODETOOLS-7902711/webrev.00/ > > > Thanks > Manukumar V S From kusrinivasan at vmware.com Mon Jul 13 01:41:49 2020 From: kusrinivasan at vmware.com (Kumar Srinivasan) Date: Mon, 13 Jul 2020 01:41:49 +0000 Subject: RFR: Fix for CODETOOLS-7902719 Message-ID: Hi Jon, Please review fixes for [1] with Webrev at [2]. Windows jtreg testing needs some serious TLC explained later. Descriptions of changes: 1. make/Defs.gmk: on windows the absolute directory is incorrectly computed. 2. make/build-all.sh: its a fix again for windows I think the line termination is in play. 3. Tool.java self explanatory with this the AOT tests work fine now. 4. faq.md: added the new environment variables 5. tag-spec.html: the tidy on my Mac complained about tables not having ?Summary? so I added these. Please let me know if you have any comments. Thanks Kumar Srinivasan [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902719 [2] http://cr.openjdk.java.net/~ksrini/CODETOOLS-7902719/webrev.00/ Windows Saga: 1.This needs Cygwin + Xwin + X11 support, there are tests that sets the DISPLAY for applet and UI tests. 2. I touched the following files to pass, the failures can be categorized into well known Windows issues, Cygwin absolute paths (/tmp vs c:/cygwin64/tmp), incorrect path separator(:), not taking into account line terminators (\n\r). C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.regtest.tool.ok C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.diff.ok C:/cygwin64/tmp/jtreg-src/build/AgentOut.ok C:/cygwin64/tmp/jtreg-src/build/autovm.ok C:/cygwin64/tmp/jtreg-src/build/ReportOnlyTest.ok C:/cygwin64/tmp/jtreg-src/build/BuildWildcards.ok C:/cygwin64/tmp/jtreg-src/build/BuildPatternTest.ok C:/cygwin64/tmp/jtreg-src/build/ClassDirsTest.ok C:/cygwin64/tmp/jtreg-src/build/CompileArgFileTest.ok C:/cygwin64/tmp/jtreg-src/build/ShowGroupTest.ok C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.classes.ok C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.jar.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.agentvm.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.othervm.ok C:/cygwin64/tmp/jtreg-src/build/RequiresTest.ok C:/cygwin64/tmp/jtreg-src/build/StatsTxt.1.ok C:/cygwin64/tmp/jtreg-src/build/StatsTxt.2.ok C:/cygwin64/tmp/jtreg-src/build/StatusFilter.ok From jonathan.gibbons at oracle.com Mon Jul 13 03:10:58 2020 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Sun, 12 Jul 2020 20:10:58 -0700 Subject: RFR: Fix for CODETOOLS-7902719 In-Reply-To: References: Message-ID: <68cec2fd-6d3d-6a0b-111a-114c6a884c7e@oracle.com> I'm guessing you're using the default tidy on your Mac, which doesn't know about HTML5. Look for a new tidy, version 5.6.0 $ /usr/bin/tidy -version HTML Tidy for Mac OS X released on 31 October 2006 - Apple Inc. build 16.4 $ /usr/local/bin/tidy -version HTML Tidy for Apple macOS version 5.6.0 With that, you should not need to add the summary attributes. Also, it's not your issue, but it is adjacent: can you fix a typo in faq.md: s/propogated/propagated/ * The following are propogated from the user's environment: I'll test out your fixes on Linux and Mac tomorrow. -- Jon On 7/12/20 6:41 PM, Kumar Srinivasan wrote: > Hi Jon, > > Please review fixes for [1] with Webrev at ?[2]. > > Windows jtreg testing needs some serious TLC explained later. > > Descriptions of changes: > 1. make/Defs.gmk: on windows the absolute directory is incorrectly > computed. > 2. make/build-all.sh: its a fix again for windows I think the line > termination is in play. > 3. Tool.java self explanatory with this the AOT tests work fine now. > 4. faq.md: added the new environment variables > 5. tag-spec.html: the tidy on my Mac complained about tables not > having ?Summary? so I added these. > > Please let me know if you have any comments. > > Thanks > Kumar Srinivasan > > [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902719 > [2] http://cr.openjdk.java.net/~ksrini/CODETOOLS-7902719/webrev.00/ > > > > Windows Saga: > 1.This needs Cygwin + Xwin + X11 support, there are tests that sets > the DISPLAY for applet and UI tests. > > 2. I touched the following files to pass, the failures can be > categorized into well known Windows issues, Cygwin absolute paths > (/tmp vs c:/cygwin64/tmp), incorrect path separator(:), not taking > into account line terminators (\n\r). > C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.regtest.tool.ok > C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.diff.ok > C:/cygwin64/tmp/jtreg-src/build/AgentOut.ok > C:/cygwin64/tmp/jtreg-src/build/autovm.ok > C:/cygwin64/tmp/jtreg-src/build/ReportOnlyTest.ok > C:/cygwin64/tmp/jtreg-src/build/BuildWildcards.ok > C:/cygwin64/tmp/jtreg-src/build/BuildPatternTest.ok > C:/cygwin64/tmp/jtreg-src/build/ClassDirsTest.ok > C:/cygwin64/tmp/jtreg-src/build/CompileArgFileTest.ok > C:/cygwin64/tmp/jtreg-src/build/ShowGroupTest.ok > C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.classes.ok > C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.jar.ok > C:/cygwin64/tmp/jtreg-src/build/TestNativePath.ok > C:/cygwin64/tmp/jtreg-src/build/TestNativePath.agentvm.ok > C:/cygwin64/tmp/jtreg-src/build/TestNativePath.othervm.ok > C:/cygwin64/tmp/jtreg-src/build/RequiresTest.ok > C:/cygwin64/tmp/jtreg-src/build/StatsTxt.1.ok > C:/cygwin64/tmp/jtreg-src/build/StatsTxt.2.ok > C:/cygwin64/tmp/jtreg-src/build/StatusFilter.ok From kusrinivasan at vmware.com Mon Jul 13 20:03:32 2020 From: kusrinivasan at vmware.com (Kumar Srinivasan) Date: Mon, 13 Jul 2020 20:03:32 +0000 Subject: RFR: Fix for CODETOOLS-7902719 In-Reply-To: <68cec2fd-6d3d-6a0b-111a-114c6a884c7e@oracle.com> References: <68cec2fd-6d3d-6a0b-111a-114c6a884c7e@oracle.com> Message-ID: <7D658D6C-A12C-4F9B-B204-625F6F6E31D9@vmware.com> Jon, Ahh, I did not have new tidy, but I installed one using brew, fyi $ brew install tidy-html5 >8 >8 8< 8< Pouring tidy-html5-5.6.0.mojave.bottle.tar.gz Fixed s/propogate/propagate/g FWIW: I tested on Ubuntu both build and test and it seems to be fine. Kumar On Jul 12, 2020, at 8:10 PM, Jonathan Gibbons > wrote: I'm guessing you're using the default tidy on your Mac, which doesn't know about HTML5. Look for a new tidy, version 5.6.0 $ /usr/bin/tidy -version HTML Tidy for Mac OS X released on 31 October 2006 - Apple Inc. build 16.4 $ /usr/local/bin/tidy -version HTML Tidy for Apple macOS version 5.6.0 With that, you should not need to add the summary attributes. Also, it's not your issue, but it is adjacent: can you fix a typo in faq.md: s/propogated/propagated/ * The following are propogated from the user's environment: I'll test out your fixes on Linux and Mac tomorrow. -- Jon On 7/12/20 6:41 PM, Kumar Srinivasan wrote: Hi Jon, Please review fixes for [1] with Webrev at [2]. Windows jtreg testing needs some serious TLC explained later. Descriptions of changes: 1. make/Defs.gmk: on windows the absolute directory is incorrectly computed. 2. make/build-all.sh: its a fix again for windows I think the line termination is in play. 3. Tool.java self explanatory with this the AOT tests work fine now. 4. faq.md: added the new environment variables 5. tag-spec.html: the tidy on my Mac complained about tables not having ?Summary? so I added these. Please let me know if you have any comments. Thanks Kumar Srinivasan [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902719 [2] http://cr.openjdk.java.net/~ksrini/CODETOOLS-7902719/webrev.00/ Windows Saga: 1.This needs Cygwin + Xwin + X11 support, there are tests that sets the DISPLAY for applet and UI tests. 2. I touched the following files to pass, the failures can be categorized into well known Windows issues, Cygwin absolute paths (/tmp vs c:/cygwin64/tmp), incorrect path separator(:), not taking into account line terminators (\n\r). C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.regtest.tool.ok C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.diff.ok C:/cygwin64/tmp/jtreg-src/build/AgentOut.ok C:/cygwin64/tmp/jtreg-src/build/autovm.ok C:/cygwin64/tmp/jtreg-src/build/ReportOnlyTest.ok C:/cygwin64/tmp/jtreg-src/build/BuildWildcards.ok C:/cygwin64/tmp/jtreg-src/build/BuildPatternTest.ok C:/cygwin64/tmp/jtreg-src/build/ClassDirsTest.ok C:/cygwin64/tmp/jtreg-src/build/CompileArgFileTest.ok C:/cygwin64/tmp/jtreg-src/build/ShowGroupTest.ok C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.classes.ok C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.jar.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.agentvm.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.othervm.ok C:/cygwin64/tmp/jtreg-src/build/RequiresTest.ok C:/cygwin64/tmp/jtreg-src/build/StatsTxt.1.ok C:/cygwin64/tmp/jtreg-src/build/StatsTxt.2.ok C:/cygwin64/tmp/jtreg-src/build/StatusFilter.ok From kusrinivasan at vmware.com Mon Jul 13 20:05:50 2020 From: kusrinivasan at vmware.com (Kumar Srinivasan) Date: Mon, 13 Jul 2020 20:05:50 +0000 Subject: RFR: Fix for CODETOOLS-7902719 In-Reply-To: <7D658D6C-A12C-4F9B-B204-625F6F6E31D9@vmware.com> References: <68cec2fd-6d3d-6a0b-111a-114c6a884c7e@oracle.com> <7D658D6C-A12C-4F9B-B204-625F6F6E31D9@vmware.com> Message-ID: <61E4B6D5-68B3-4DC6-BA2B-561A950FC06E@vmware.com> Oops here is the updated Webrev: http://cr.openjdk.java.net/~ksrini/CODETOOLS-7902719/webrev.01/ Kumar On Jul 13, 2020, at 1:03 PM, Kumar Srinivasan > wrote: Jon, Ahh, I did not have new tidy, but I installed one using brew, fyi $ brew install tidy-html5 >8 >8 8< 8< Pouring tidy-html5-5.6.0.mojave.bottle.tar.gz Fixed s/propogate/propagate/g FWIW: I tested on Ubuntu both build and test and it seems to be fine. Kumar On Jul 12, 2020, at 8:10 PM, Jonathan Gibbons > wrote: I'm guessing you're using the default tidy on your Mac, which doesn't know about HTML5. Look for a new tidy, version 5.6.0 $ /usr/bin/tidy -version HTML Tidy for Mac OS X released on 31 October 2006 - Apple Inc. build 16.4 $ /usr/local/bin/tidy -version HTML Tidy for Apple macOS version 5.6.0 With that, you should not need to add the summary attributes. Also, it's not your issue, but it is adjacent: can you fix a typo in faq.md: s/propogated/propagated/ * The following are propogated from the user's environment: I'll test out your fixes on Linux and Mac tomorrow. -- Jon On 7/12/20 6:41 PM, Kumar Srinivasan wrote: Hi Jon, Please review fixes for [1] with Webrev at [2]. Windows jtreg testing needs some serious TLC explained later. Descriptions of changes: 1. make/Defs.gmk: on windows the absolute directory is incorrectly computed. 2. make/build-all.sh: its a fix again for windows I think the line termination is in play. 3. Tool.java self explanatory with this the AOT tests work fine now. 4. faq.md: added the new environment variables 5. tag-spec.html: the tidy on my Mac complained about tables not having ?Summary? so I added these. Please let me know if you have any comments. Thanks Kumar Srinivasan [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902719 [2] http://cr.openjdk.java.net/~ksrini/CODETOOLS-7902719/webrev.00/ Windows Saga: 1.This needs Cygwin + Xwin + X11 support, there are tests that sets the DISPLAY for applet and UI tests. 2. I touched the following files to pass, the failures can be categorized into well known Windows issues, Cygwin absolute paths (/tmp vs c:/cygwin64/tmp), incorrect path separator(:), not taking into account line terminators (\n\r). C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.regtest.tool.ok C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.diff.ok C:/cygwin64/tmp/jtreg-src/build/AgentOut.ok C:/cygwin64/tmp/jtreg-src/build/autovm.ok C:/cygwin64/tmp/jtreg-src/build/ReportOnlyTest.ok C:/cygwin64/tmp/jtreg-src/build/BuildWildcards.ok C:/cygwin64/tmp/jtreg-src/build/BuildPatternTest.ok C:/cygwin64/tmp/jtreg-src/build/ClassDirsTest.ok C:/cygwin64/tmp/jtreg-src/build/CompileArgFileTest.ok C:/cygwin64/tmp/jtreg-src/build/ShowGroupTest.ok C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.classes.ok C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.jar.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.agentvm.ok C:/cygwin64/tmp/jtreg-src/build/TestNativePath.othervm.ok C:/cygwin64/tmp/jtreg-src/build/RequiresTest.ok C:/cygwin64/tmp/jtreg-src/build/StatsTxt.1.ok C:/cygwin64/tmp/jtreg-src/build/StatsTxt.2.ok C:/cygwin64/tmp/jtreg-src/build/StatusFilter.ok From jonathan.gibbons at oracle.com Mon Jul 13 20:48:30 2020 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 13 Jul 2020 13:48:30 -0700 Subject: RFR: Fix for CODETOOLS-7902719 In-Reply-To: <61E4B6D5-68B3-4DC6-BA2B-561A950FC06E@vmware.com> References: <68cec2fd-6d3d-6a0b-111a-114c6a884c7e@oracle.com> <7D658D6C-A12C-4F9B-B204-625F6F6E31D9@vmware.com> <61E4B6D5-68B3-4DC6-BA2B-561A950FC06E@vmware.com> Message-ID: <5144ec7c-ac9e-6d87-9dc8-b08b51b6b009@oracle.com> Yeah, I use the brew version of tidy as well. -- Jon On 7/13/20 1:05 PM, Kumar Srinivasan wrote: > Oops here is the updated Webrev: > http://cr.openjdk.java.net/~ksrini/CODETOOLS-7902719/webrev.01/ > > Kumar > > >> On Jul 13, 2020, at 1:03 PM, Kumar Srinivasan >> > wrote: >> >> Jon, >> >> Ahh, I did not have new tidy, but I installed one using brew, fyi >> >> $ brew install tidy-html5 >> >8 >8 ?8< 8< >> Pouring tidy-html5-5.6.0.mojave.bottle.tar.gz >> >> Fixed s/propogate/propagate/g >> >> >> FWIW: I tested on Ubuntu both build and test and it seems to be fine. >> >> Kumar >> >> >> >> >>> On Jul 12, 2020, at 8:10 PM, Jonathan Gibbons >>> > >>> wrote: >>> >>> I'm guessing you're using the default tidy on your Mac, which >>> doesn't know about HTML5. >>> Look for a new tidy, version 5.6.0 >>> >>> $ /usr/bin/tidy -version >>> HTML Tidy for Mac OS X released on 31 October 2006 - Apple Inc. >>> build 16.4 >>> $ /usr/local/bin/tidy -version >>> HTML Tidy for Apple macOS version 5.6.0 >>> >>> With that, you should not need to add the summary attributes. >>> >>> Also, it's not your issue, but it is adjacent: can you fix a typo in >>> faq.md: s/propogated/propagated/ >>> * The following are propogated from the user's environment: >>> I'll test out your fixes on Linux and Mac tomorrow. >>> >>> -- Jon >>> >>> On 7/12/20 6:41 PM, Kumar Srinivasan wrote: >>>> Hi Jon, >>>> >>>> Please review fixes for [1] with Webrev at ?[2]. >>>> >>>> Windows jtreg testing needs some serious TLC explained later. >>>> >>>> Descriptions of changes: >>>> 1. make/Defs.gmk: on windows the absolute directory is incorrectly >>>> computed. >>>> 2. make/build-all.sh: its a fix again for windows I think the line >>>> termination is in play. >>>> 3. Tool.java self explanatory with this the AOT tests work fine now. >>>> 4. faq.md: added the new environment variables >>>> 5. tag-spec.html: the tidy on my Mac complained about tables not >>>> having ?Summary? so I added these. >>>> >>>> Please let me know if you have any comments. >>>> >>>> Thanks >>>> Kumar Srinivasan >>>> >>>> [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902719 >>>> >>>> [2] http://cr.openjdk.java.net/~ksrini/CODETOOLS-7902719/webrev.00/ >>>> >>>> >>>> >>>> >>>> Windows Saga: >>>> 1.This needs Cygwin + Xwin + X11 support, there are tests that sets >>>> the DISPLAY for applet and UI tests. >>>> >>>> 2. I touched the following files to pass, the failures can be >>>> categorized into well known Windows issues, Cygwin absolute paths >>>> (/tmp vs c:/cygwin64/tmp), incorrect path separator(:), not taking >>>> into account line terminators (\n\r). >>>> C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.regtest.tool.ok >>>> C:/cygwin64/tmp/jtreg-src/build/i18n.com.sun.javatest.diff.ok >>>> C:/cygwin64/tmp/jtreg-src/build/AgentOut.ok >>>> C:/cygwin64/tmp/jtreg-src/build/autovm.ok >>>> C:/cygwin64/tmp/jtreg-src/build/ReportOnlyTest.ok >>>> C:/cygwin64/tmp/jtreg-src/build/BuildWildcards.ok >>>> C:/cygwin64/tmp/jtreg-src/build/BuildPatternTest.ok >>>> C:/cygwin64/tmp/jtreg-src/build/ClassDirsTest.ok >>>> C:/cygwin64/tmp/jtreg-src/build/CompileArgFileTest.ok >>>> C:/cygwin64/tmp/jtreg-src/build/ShowGroupTest.ok >>>> C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.classes.ok >>>> C:/cygwin64/tmp/jtreg-src/build/TestJDKVersion.jar.ok >>>> C:/cygwin64/tmp/jtreg-src/build/TestNativePath.ok >>>> C:/cygwin64/tmp/jtreg-src/build/TestNativePath.agentvm.ok >>>> C:/cygwin64/tmp/jtreg-src/build/TestNativePath.othervm.ok >>>> C:/cygwin64/tmp/jtreg-src/build/RequiresTest.ok >>>> C:/cygwin64/tmp/jtreg-src/build/StatsTxt.1.ok >>>> C:/cygwin64/tmp/jtreg-src/build/StatsTxt.2.ok >>>> C:/cygwin64/tmp/jtreg-src/build/StatusFilter.ok >> > From manukumar.vs at oracle.com Thu Jul 16 15:34:04 2020 From: manukumar.vs at oracle.com (Manukumar V S) Date: Thu, 16 Jul 2020 08:34:04 -0700 (PDT) Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility In-Reply-To: <61761d13-1376-4b79-97a5-cc3c83810662@default> References: <218213e3-21bb-4034-8031-b99430dc878b@default> <2dfeaf35-76e9-d576-0824-439fd7637349@oracle.com> <61761d13-1376-4b79-97a5-cc3c83810662@default> Message-ID: <5e2ad185-5636-4fcd-8533-70b0da598c01@default> Hi Jonathan, Gentle reminder... Thanks Manukumar V S -----Original Message----- From: Manukumar V S Sent: Friday, July 10, 2020 10:33 AM To: Jonathan Gibbons ; code-tools-dev at openjdk.java.net Subject: RE: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility Hi Jonathan, Yes, Can you please sponsor my change. Thanks in advance. -Manukumar V S -----Original Message----- From: Jonathan Gibbons Sent: Friday, July 10, 2020 1:31 AM To: Manukumar V S ; code-tools-dev at openjdk.java.net Subject: Re: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 compatibility Hi, Given the reviews by Erik and Tim, it looks like this patch is good to go.? Do you need me to sponsor this change for you? -- Jon On 7/9/20 12:09 AM, Manukumar V S wrote: > Gentle reminder!!!... > > -----Original Message----- > From: Manukumar V S > Sent: Thursday, July 2, 2020 9:31 AM > To: code-tools-dev at openjdk.java.net > Subject: RFR: CODETOOLS-7902711 defpath upgrade needed for Python 3 > compatibility > > Hi, > > Can you please review these changes in defpath.py to make it compatible with Python 3.0: > > CODETOOLS-7902711 > defpath > upgrade needed for Python 3 compatibility > > Webrev: > http://cr.openjdk.java.net/~mvs/CODETOOLS-7902711/webrev.00/ > > > Thanks > Manukumar V S