From githubadam at gmail.com Fri May 1 15:13:37 2020 From: githubadam at gmail.com (Adam Carroll) Date: Fri, 1 May 2020 17:13:37 +0200 Subject: jpackage signing fails with Mac jdk-14.0.1+7 Message-ID: Using JDK 14.0.1 on the Mac, jpackage fails when signing is requested. This problem was observed using AdoptOpenJDK. I reported the problem to that project and they suggested that I report the problem here. Platform: Mac OS Catalina v10.15.4 Architecture: x86 Description: This problem was seen using AdoptOpenJDK 14.0.1+7. Using the Mac signing option for jpackage ... --mac-sign ... I see the following error (extra path information removed): /var/folders/rh/...../HelloFX.app: is already signed However, if the --mac-sign option is removed, the build works without a problem. Reproducing the problem: I've created a minimal, single-class JavaFX application along with the necessary scripts to reproduce the problem: https://github.com/AdamCarroll/jdk14-jpackage-mac First clone the repo: $ git clone git at github.com:AdamCarroll/jdk14-jpackage-mac.git Checkout the tag: $ git checkout 1.0.0 Run the build (very fast as there's only one class): $ ./gradlew clean build Now run the jpackage command with the --mac-sign option as follows (this is included in the file bin/create-signed-dmg.sh): $ jpackage \ --type dmg \ --module-path 'build/modules' \ --verbose \ --add-modules javafx.controls \ --input 'build/libraries' \ --dest "build/bundle" \ --name HelloFX \ --main-jar 'jdk14-jpackage-mac.jar' \ --main-class 'demo.HelloFX' \ --mac-sign You will now see a long error that includes the following: /var/folders/rh/...jdk.incubator.jpackage..../HelloFX.app: is already signed java.io.IOException: Command [codesign, -s, Developer ID Application: Your Name Here (XXXXXXXXXX), -vvvv, /var/folders/rh/...jdk.incubator.jpackage.../HelloFX.app] exited with 1 code at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.Executor.executeExpectSuccess(Executor.java:73) at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:179) at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:150) ... If you now run the same command but without the --mac-sign option (or alternatively use the script bin/create-unsigned-dmg.sh), everything works without problems. You can find the original issue report to the AdoptOpenJDK repository here: https://github.com/AdoptOpenJDK/openjdk-build/issues/1718 From kevin.rushforth at oracle.com Fri May 1 15:19:52 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 1 May 2020 08:19:52 -0700 Subject: jpackage signing fails with Mac jdk-14.0.1+7 In-Reply-To: References: Message-ID: Redirecting to core-libs-dev (with a Bcc to code-tools-dev) Code signing for macOS, along with the addition of notarization, has been improved for JDK 15. You might want to try the EA builds of JDK 15, which are available here: https://jdk.java.net/15/ -- Kevin On 5/1/2020 8:13 AM, Adam Carroll wrote: > Using JDK 14.0.1 on the Mac, jpackage fails when signing is requested. > This problem was observed using AdoptOpenJDK. I reported the problem to > that project and they suggested that I report the problem here. > > Platform: > > Mac OS Catalina v10.15.4 > > Architecture: > > x86 > > Description: > > This problem was seen using AdoptOpenJDK 14.0.1+7. > > Using the Mac signing option for jpackage ... --mac-sign ... I see the > following error (extra path information removed): > > /var/folders/rh/...../HelloFX.app: is already signed > > However, if the --mac-sign option is removed, the build works without a > problem. > > Reproducing the problem: > > I've created a minimal, single-class JavaFX application along with the > necessary scripts to reproduce the problem: > https://github.com/AdamCarroll/jdk14-jpackage-mac > > First clone the repo: > > $ git clone git at github.com:AdamCarroll/jdk14-jpackage-mac.git > > Checkout the tag: > > $ git checkout 1.0.0 > > Run the build (very fast as there's only one class): > > $ ./gradlew clean build > > Now run the jpackage command with the --mac-sign option as follows (this is > included in the file bin/create-signed-dmg.sh): > > $ jpackage \ > --type dmg \ > --module-path 'build/modules' \ > --verbose \ > --add-modules javafx.controls \ > --input 'build/libraries' \ > --dest "build/bundle" \ > --name HelloFX \ > --main-jar 'jdk14-jpackage-mac.jar' \ > --main-class 'demo.HelloFX' \ > --mac-sign > > You will now see a long error that includes the following: > > /var/folders/rh/...jdk.incubator.jpackage..../HelloFX.app: is already signed > java.io.IOException: Command [codesign, -s, Developer ID Application: Your > Name Here (XXXXXXXXXX), -vvvv, > /var/folders/rh/...jdk.incubator.jpackage.../HelloFX.app] exited with 1 code > at > jdk.incubator.jpackage/jdk.incubator.jpackage.internal.Executor.executeExpectSuccess(Executor.java:73) > at > jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:179) > at > jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:150) > ... > > If you now run the same command but without the --mac-sign option (or > alternatively use the script bin/create-unsigned-dmg.sh), everything works > without problems. > > You can find the original issue report to the AdoptOpenJDK repository here: > https://github.com/AdoptOpenJDK/openjdk-build/issues/1718 From kevin.rushforth at oracle.com Fri May 1 15:43:22 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 1 May 2020 08:43:22 -0700 Subject: jpackage signing fails with Mac jdk-14.0.1+7 In-Reply-To: References: Message-ID: <01d6f9aa-a4fa-6b28-df16-29fb8bb713f3@oracle.com> FYI, I redirected this to core-libs-dev, which is where jpackage issues are discussed. My attempt to "Bcc" to this list is pending moderator approval, so here is what I wrote: ======================================================== Redirecting to core-libs-dev (with a Bcc to code-tools-dev) Code signing for macOS, along with the addition of notarization, has been improved for JDK 15. You might want to try the EA builds of JDK 15, which are available here: https://jdk.java.net/15/ -- Kevin On 5/1/2020 8:13 AM, Adam Carroll wrote: > Using JDK 14.0.1 on the Mac, jpackage fails when signing is requested. > This problem was observed using AdoptOpenJDK. I reported the problem to > that project and they suggested that I report the problem here. > > Platform: > > Mac OS Catalina v10.15.4 > > Architecture: > > x86 > > Description: > > This problem was seen using AdoptOpenJDK 14.0.1+7. > > Using the Mac signing option for jpackage ... --mac-sign ... I see the > following error (extra path information removed): > > /var/folders/rh/...../HelloFX.app: is already signed > > However, if the --mac-sign option is removed, the build works without a > problem. > > Reproducing the problem: > > I've created a minimal, single-class JavaFX application along with the > necessary scripts to reproduce the problem: > https://github.com/AdamCarroll/jdk14-jpackage-mac > > First clone the repo: > > $ git clone git at github.com:AdamCarroll/jdk14-jpackage-mac.git > > Checkout the tag: > > $ git checkout 1.0.0 > > Run the build (very fast as there's only one class): > > $ ./gradlew clean build > > Now run the jpackage command with the --mac-sign option as follows (this is > included in the file bin/create-signed-dmg.sh): > > $ jpackage \ > --type dmg \ > --module-path 'build/modules' \ > --verbose \ > --add-modules javafx.controls \ > --input 'build/libraries' \ > --dest "build/bundle" \ > --name HelloFX \ > --main-jar 'jdk14-jpackage-mac.jar' \ > --main-class 'demo.HelloFX' \ > --mac-sign > > You will now see a long error that includes the following: > > /var/folders/rh/...jdk.incubator.jpackage..../HelloFX.app: is already signed > java.io.IOException: Command [codesign, -s, Developer ID Application: Your > Name Here (XXXXXXXXXX), -vvvv, > /var/folders/rh/...jdk.incubator.jpackage.../HelloFX.app] exited with 1 code > at > jdk.incubator.jpackage/jdk.incubator.jpackage.internal.Executor.executeExpectSuccess(Executor.java:73) > at > jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:179) > at > jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:150) > ... > > If you now run the same command but without the --mac-sign option (or > alternatively use the script bin/create-unsigned-dmg.sh), everything works > without problems. > > You can find the original issue report to the AdoptOpenJDK repository here: > https://github.com/AdoptOpenJDK/openjdk-build/issues/1718 From dmitry.bessonov at oracle.com Fri May 1 17:33:21 2020 From: dmitry.bessonov at oracle.com (Dmitry Bessonov) Date: Fri, 1 May 2020 18:33:21 +0100 Subject: Result: New Code Tools Committer: Leonid Kuskov In-Reply-To: References: Message-ID: Voting for Leonid Kuskov [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Dmitry Bessonov [1] https://mail.openjdk.java.net/pipermail/code-tools-dev/2020-April/000580.html > On 14 Apr 2020, at 19:27, Dmitry Bessonov wrote: > > I hereby nominate Leonid Kuskov to Code Tools Committer. > > Leonid has been working on maintenance and development of the Code Tools > JCov and ASMTools projects for several years. He has contributed 9 changesets > to the Code Tools "jcov" repo and 27 changesets to the Code Tools "asmtools" repo. > Having him as a Code Tools Committer would reinforce development of JCov and > ASMTools projects and help keep them relevant and valuable tools. > > Votes are due by the end of April 28, 2020. > > Only current Code Tools Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Dmitry Bessonov > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote >